--- loncom/interface/statistics/lonstudentsubmissions.pm	2010/09/12 17:37:24	1.54.10.2
+++ loncom/interface/statistics/lonstudentsubmissions.pm	2010/08/24 14:05:19	1.61
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonstudentsubmissions.pm,v 1.54.10.2 2010/09/12 17:37:24 raeburn Exp $
+# $Id: lonstudentsubmissions.pm,v 1.61 2010/08/24 14:05:19 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -37,7 +37,6 @@ use Apache::lonstathelpers;
 use HTML::Entities();
 use Time::Local();
 use Spreadsheet::WriteExcel();
-use Crypt::PasswdMD5;
 use lib '/home/httpd/lib/perl/';
 use LONCAPA;
   
@@ -77,6 +76,10 @@ sub BuildStudentSubmissionsPage {
                                    '<div class="LC_info">'.&mt('Loading student data...').'</div>');
     $r->rflush();
     #
+    my %anoncounter =
+         &Apache::lonnet::dump('nohist_anonsurveys',
+                        $env{'course.'.$env{'request.course.id'}.'.domain'},
+                        $env{'course.'.$env{'request.course.id'}.'.num'});
     if (exists($env{'form.problemchoice'}) && 
         ! exists($env{'form.SelectAnother'})) {
         foreach my $button (@SubmitButtons) {
@@ -98,30 +101,83 @@ sub BuildStudentSubmissionsPage {
         # Determine which problems we are to analyze
         my @Symbs = 
             &Apache::lonstathelpers::get_selected_symbs('problemchoice');
-        foreach my $selected (@Symbs) {
-            $r->print('<input type="hidden" name="problemchoice" value="'.
-                      $selected.'" />'.$/);
+
+        # If there are multi-part problems with anonymous survey and named
+        # parts check if named was picked for display.
+        #
+        my %mixed_named; 
+        foreach my $envkey (%env) {
+            if ($envkey =~ /^form\.mixed_(\d+:\d+)$/) {
+                my $item = $1; 
+                if ($env{$envkey} =~ /^symb_(.+)$/) {
+                    my $symb = &unescape($1);
+                    if (ref($mixed_named{$symb}) eq 'ARRAY') {
+                        push(@{$mixed_named{$symb}},$item);
+                    } else {
+                        @{$mixed_named{$symb}} = ($item);
+                    }
+                }
+            }
         }
         #
         # Get resource objects
         my $navmap = Apache::lonnavmaps::navmap->new();
         if (!defined($navmap)) {
+            foreach my $selected (@Symbs) {
+                $r->print('<input type="hidden" name="problemchoice" value="'.
+                          &escape($selected).'" />'.$/);
+                if (ref($mixed_named{$selected}) eq 'ARRAY') {
+                    foreach my $item (@{$mixed_named{$selected}}) {
+                        $r->print('<input type="hidden" name="mixed_'.$item.'" value="'.&escape($selected).'" />'.$/);
+                    }
+                }
+            }
             $r->print('<div class="LC_error">'.&mt("Internal error").'</div>');
             return;
         }
         my %already_seen;
-        my (@Problems,$show_named);
-        unless (&Apache::loncommon::needs_gci_custom()) {
-            $show_named = 1;  
-        }
+        my (@Problems,@anonProbs,@namedProbs,$show_named);
         foreach my $symb (@Symbs) {
             my $resource = $navmap->getBySymb($symb);
-            push(@Problems,$resource);
+            my ($hasanon,$hasnamed);
+            if (ref($resource)) {
+                foreach my $partid (@{$resource->parts}) {
+                    if (($anoncounter{$symb."\0".$partid}) || ($resource->is_anonsurvey($partid))) {
+                        unless (exists($mixed_named{$symb})) {
+                            $hasanon = 1;
+                        }
+                    } else {
+                        $hasnamed = 1;
+                    }
+                }
+                if ($hasanon) {
+                    push(@anonProbs,$resource);
+                } elsif ($hasnamed) {
+                    push(@namedProbs,$resource);
+                }
+            }
+        }
+        if (@namedProbs > 0) {
+            @Problems = @namedProbs;
+            $show_named = 1;
+        } elsif (@anonProbs > 0) {
+            @Problems = @anonProbs;
+        } 
+        foreach my $selected (@Symbs) {
+            $r->print('<input type="hidden" name="problemchoice" value="'.
+                      &escape($selected).'" />'.$/);
+            if (ref($mixed_named{$selected}) eq 'ARRAY') {
+                foreach my $item (@{$mixed_named{$selected}}) {
+                    $r->print('<input type="hidden" name="mixed_'.$item.'" value="'.&escape($selected).'" />'.$/);
+                }
+            }
         }
         # If these are to be anonymized, do a random shuffle of @Students. 
         unless ($show_named) {
             &array_shuffle(\@Students);
         }
+        #
+
         my $threshold = $env{'course.'.$env{'request.course.id'}.'.internal.anonsurvey_threshold'};
         if ($threshold eq '') {
             my %domconfig =
@@ -136,12 +192,11 @@ sub BuildStudentSubmissionsPage {
                 $threshold = 10;
             }
         }
-        # 
         $r->print('<h4>'.
                   &Apache::lonstatistics::section_and_enrollment_description().
                   '</h4>');
         if (! scalar(@Problems) || ! defined($Problems[0])) {
-            $r->print('resource is undefined');
+            $r->print(&mt('resource is undefined'));
         } elsif (!$show_named && @Students < $threshold) {
             $r->print(&mt('The number of students matching the selection criteria is too few for display of submission data for anonymous surveys.').'<br />'.&mt('There must be at least [quant,_1,student].',$threshold).' '.&mt('Contact a Domain Coordinator if you need the threshold to be changed for this course.'));
         } else {
@@ -155,11 +210,11 @@ sub BuildStudentSubmissionsPage {
                 }
             }
             if ($env{'form.output'} eq 'excel') {
-                &prepare_excel_output($r,\@Problems,\@Students,$show_named);
+                &prepare_excel_output($r,\@Problems,\@Students,\%anoncounter,$show_named);
             } elsif ($env{'form.output'} eq 'csv') {
-                &prepare_csv_output($r,\@Problems,\@Students,$show_named);
+                &prepare_csv_output($r,\@Problems,\@Students,\%anoncounter,$show_named);
             } else {
-                &prepare_html_output($r,\@Problems,\@Students,$show_named);
+                &prepare_html_output($r,\@Problems,\@Students,\%anoncounter,$show_named);
             }
         }
         $r->print('<hr />');
@@ -168,13 +223,13 @@ sub BuildStudentSubmissionsPage {
                   &mt('Prepare Report').'" />');
         $r->print('&nbsp;'x5);
         $r->print('<p>'.
-                  &mt('Computing correct answers greatly increasese the amount of time required to prepare a report.').
+                  &mt('Computing correct answers greatly increases the amount of time required to prepare a report.').
                   '</p>');
         $r->print('<p>'.
                   &mt('Please select problems and use the [_1]Prepare Report[_2] button to continue.','<b>','</b>').
                   '</p>');
         $r->print(&Apache::lonstathelpers::MultipleProblemSelector
-                  (undef,'problemchoice','Statistics'));
+                  (undef,'problemchoice','Statistics',\%anoncounter));
     }
 }
 
@@ -195,7 +250,6 @@ sub array_shuffle {
 ##
 ## get_extra_response_headers
 ##
-
 sub get_extra_response_headers {
     my ($show_named) = @_;
     my @extra_resp_headers;
@@ -253,9 +307,8 @@ sub get_headers {
 #########################################################
 #########################################################
 sub prepare_html_output {
-    my ($r,$problems,$students,$show_named) = @_;
+    my ($r,$problems,$students,$anoncounter,$show_named) = @_;
     my $c = $r->connection();
-    my $salt = '$1$'.$Apache::lonnet::perlvar{'AnonymousSalt'};
     #
     # Set a flag for the case when there is just one problem
     my $single_response = 0;
@@ -293,13 +346,21 @@ sub prepare_html_output {
     foreach my $prob (@$problems) {
         my %analysis = &Apache::lonstathelpers::get_problem_data($prob->src);
         $problem_analysis{$prob->src}=\%analysis;
+        my $symb = $prob->symb();
         #
         my $prob_span = 0;
         my $single_part = 0;
         if (scalar(@{$prob->parts}) == 1) {
             $single_part = 1;
         }
+        my $shown_parts = 0;
         foreach my $partid (@{$prob->parts}) {
+            if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                next if ($show_named);
+            } else {
+                next unless ($show_named);
+            }
+            $shown_parts ++;
             my $part_span = 0;
             my $responses = [$prob->responseIds($partid)];
             my $resptypes = [$prob->responseType($partid)];
@@ -340,6 +401,7 @@ sub prepare_html_output {
             }
             $prob_span += $part_span;
         }
+        next if (!$shown_parts);
         my $title = $prob->compTitle;
         if ($prob_span > 0) {
             $headers{'problem'}.= qq{<th colspan="$prob_span">$title</th>};
@@ -390,11 +452,7 @@ sub prepare_html_output {
                 $student_row_data .= '</td>';
             }
         } else {
-            my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'},
-                                                           $salt);
-            $anonid = substr($anonid,length($salt)+1);
-            $student_row_data = '<td valign="top" colspan="'.$student_column_count.'">'.
-                                $anonid.'</td>';
+            $student_row_data = '<td valign="top" colspan="'.$student_column_count.'">'.&mt('Anonymized').'</td>';
         }
         #
         # Figure out what it is we need to output for this student
@@ -402,8 +460,14 @@ sub prepare_html_output {
         my %prob_data;
         my $maxrow;
         foreach my $prob (@$problems) {
-            $prob_data{$prob->symb}={};
+            my $symb = $prob->symb;
+            $prob_data{$symb}={};
             foreach my $partid (@{$prob->parts}) {
+                if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                    next if ($show_named);
+                } else {
+                    next unless ($show_named);
+                }
                 my @responses = $prob->responseIds($partid);
                 my @response_type = $prob->responseType($partid);
                 for (my $i=0;$i<=$#responses;$i++) {
@@ -693,20 +757,26 @@ sub html_non_essay_results {
 #########################################################
 #########################################################
 sub prepare_excel_output {
-    my ($r,$Problems,$Students,$show_named) = @_;
+    my ($r,$Problems,$Students,$anoncounter,$show_named) = @_;
     my $c = $r->connection();
-    my $salt = '$1$'.$Apache::lonnet::perlvar{'AnonymousSalt'};
     #
     #
     # Determine the number of columns in the spreadsheet
     my $columncount = 3; # username, domain, id
-    my @extra_resp_headers = &get_extra_response_headers();
+    my @extra_resp_headers = &get_extra_response_headers($show_named);
     my $lastprob;
     my %problem_analysis;
     foreach my $prob (@$Problems) {
+        my $symb = $prob->symb();
         my %analysis = &Apache::lonstathelpers::get_problem_data($prob->src);
         $problem_analysis{$prob->src}=\%analysis;
         foreach my $partid (@{$prob->parts}) {
+            if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                next if ($show_named);
+            } else {
+                next unless ($show_named);
+            }
+
             my $responses = [$prob->responseIds($partid)];
             my $resptypes = [$prob->responseType($partid)];
             for (my $i=0;$i<scalar(@$responses);$i++) {
@@ -724,8 +794,10 @@ sub prepare_excel_output {
     if ($columncount > 255) {
         $r->print('<h1>'.&mt('Unable to complete request').'</h1>'.$/.
                   '<p>'.&mt('LON-CAPA is unable to produce your Excel spreadsheet because your selections will result in more than 255 columns.  Excel allows only 255 columns in a spreadsheet.').'</p>'.$/.
-                  '<p>'.&mt('Consider selecting fewer problems to generate reports on, or reducing the number of items per problem.  Or use HTML or CSV output.').'</p>'.$/.
-                  '<p>'.&mt('The last problem that will fit in the current spreadsheet is [_1].',$lastprob->compTitle).'</p>');
+                  '<p>'.&mt('Consider selecting fewer problems to generate reports on, or reducing the number of items per problem.  Or use HTML or CSV output.').'</p>'.$/);
+        if (ref($lastprob)) {
+            $r->print('<p>'.&mt('The last problem that will fit in the current spreadsheet is [_1].',$lastprob->compTitle).'</p>');
+        }
         $r->rflush();
         return;
     }
@@ -768,7 +840,7 @@ sub prepare_excel_output {
     if ($show_named) {
         @StudentColumns = qw(username domain id section);
     } else {
-        @StudentColumns = qw(username);
+         @StudentColumns = qw(username);
     }
     foreach (@StudentColumns) {
         $worksheet->write($header_row,$cols_output++,ucfirst($_),
@@ -778,9 +850,15 @@ sub prepare_excel_output {
     my %start_col;
     foreach my $prob (@$Problems) {
         my $title = $prob->compTitle;
+        my $symb = $prob->symb();
         $worksheet->write($title_row,$cols_output,
                           $title,$format->{'h3'});
         foreach my $partid (@{$prob->parts}) {
+            if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                next if ($show_named);
+            } else {
+                next unless ($show_named);
+            }
             $worksheet->write($partid_row,$cols_output,
                               $prob->part_display($partid));
             my $responses = [$prob->responseIds($partid)];
@@ -816,21 +894,24 @@ sub prepare_excel_output {
         last if ($c->aborted());
         $cols_output = 0;
         my $student_row = $max_row;
-        my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'},
-                                                       $salt);
-        $anonid = substr($anonid,length($salt)+1);
         foreach my $field (@StudentColumns) {
             if ($show_named) {
                 $worksheet->write($student_row,$cols_output++,
                                   $student->{$field});
             } else {
                 $worksheet->write($student_row,$cols_output++,
-                                      $anonid);
+                                      &mt('Anonymized'));
             }
         }
         my $last_student_col = $cols_output-1;
         foreach my $prob (@$Problems) {
+            my $symb = $prob->symb();
             foreach my $partid (@{$prob->parts}) {
+                if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                    next if ($show_named);
+                } else {
+                    next unless ($show_named);
+                }
                 my @Response = $prob->responseIds($partid);
                 my @ResponseType = $prob->responseType($partid);
                 for (my $i=0;$i<=$#Response;$i++) {
@@ -886,7 +967,7 @@ sub prepare_excel_output {
                                       $student->{$field});
                 } else {
                     $worksheet->write($row,$cols++,
-                                      $anonid);
+                                      &mt('Anonymized'));
                 }
             }
         }
@@ -997,9 +1078,8 @@ sub excel_format_item {
 #########################################################
 #########################################################
 sub prepare_csv_output {
-    my ($r,$problems,$students,$show_named) = @_;
+    my ($r,$problems,$students,$anoncounter,$show_named) = @_;
     my $c = $r->connection();
-    my $salt = '$1$'.$Apache::lonnet::perlvar{'AnonymousSalt'};
     #
     $r->print('<h2>'.
               &mt('Generating CSV report of student responses').'</h2>');
@@ -1019,11 +1099,13 @@ sub prepare_csv_output {
             time.'_'.rand(1000000000).'.csv';
     unless ($outputfile = Apache::File->new('>/home/httpd'.$filename)) {
         $r->log_error("Couldn't open $filename for output $!");
-        $r->print('<div class="LC_error">'
-                 .&mt('Problems occurred in writing the CSV file. '
-                     .'This error has been logged. '
-                     .'Please alert your LON-CAPA administrator.')
-                 .'</div>');
+        $r->print(
+            '<p class="LC_error">'
+           .&mt('Problems occurred in writing the CSV file.')
+           .' '.&mt('This error has been logged.')
+           .' '.&mt('Please alert your LON-CAPA administrator.')
+           .'</p>'
+        );
         $outputfile = undef;
     }
     #
@@ -1031,12 +1113,13 @@ sub prepare_csv_output {
     my @extra_resp_headers = &get_extra_response_headers($show_named);
     #
     # Create the table header
-    my @student_columns;
+    my @student_columns = ('username','domain','id','section');
     if ($show_named) {
         @student_columns = qw(username domain id section);
     } else {
         @student_columns = qw(username);
     }
+    my $student_column_count = scalar(@student_columns);
     #
     my %headers;
     push(@{$headers{'student'}},@student_columns);
@@ -1050,10 +1133,16 @@ sub prepare_csv_output {
     my %start_col;
     my $max_column = scalar(@student_columns);
     foreach my $prob (@$problems) {
+        my $symb = $prob->symb();
         my %analysis = &Apache::lonstathelpers::get_problem_data($prob->src);
         $problem_analysis{$prob->src}=\%analysis;
         $headers{'problem'}->[$max_column] = $prob->compTitle;
         foreach my $partid (@{$prob->parts}) {
+            if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                next if ($show_named);
+            } else {
+                next unless ($show_named);
+            }
             $headers{'part'}->[$max_column] = $prob->part_display($partid);
             my $responses = [$prob->responseIds($partid)];
             my $resptypes = [$prob->responseType($partid)];
@@ -1085,12 +1174,15 @@ sub prepare_csv_output {
     # Main loop
     foreach my $student (@$students) {
         last if ($c->aborted());
-        my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'},
-                                                       $salt);
-       $anonid = substr($anonid,length($salt)+1);
         my @rows;
         foreach my $prob (@$problems) {
+            my $symb = $prob->symb;
             foreach my $partid (@{$prob->parts}) {
+                if (($prob->is_anonsurvey($partid)) || ($anoncounter->{$symb."\0".$partid})) {
+                    next if ($show_named); 
+                } else {
+                    next unless ($show_named);
+                }
                 my @responses = $prob->responseIds($partid);
                 my @response_type = $prob->responseType($partid);
                 for (my $i=0;$i<=$#responses;$i++) {
@@ -1134,10 +1226,10 @@ sub prepare_csv_output {
                                         map { $student->{$_}; }
                                         @student_columns).'"';
             } else {
-                $student_row_data = '"'.$anonid.'"';
+                $student_row_data = '"'.&mt('Anonymized').'"';
             }
             print $outputfile $student_row_data;
-            for (my $i=scalar(@student_columns);$i<$max_column;$i++) {
+            for (my $i=$student_column_count;$i<$max_column;$i++) {
                 my $value = &Apache::loncommon::csv_translate($row->[$i]);
                 $value ||='';
                 print $outputfile ',"'.$value.'"';
@@ -1183,7 +1275,7 @@ sub CreateInterface {
     foreach ('HTML','Excel','CSV') {
         $output_selector .= '    <option value="'.lc($_).'"';
         if ($env{'form.output'} eq lc($_)) {
-            $output_selector .= ' selected="selected" ';
+            $output_selector .= ' selected="selected"';
         }
         $output_selector .='>'.&mt($_).'</option>'.$/;
     } 
@@ -1197,6 +1289,7 @@ sub CreateInterface {
     $Str .= &Apache::loncommon::start_data_table_header_row();
     $Str .= '<th>'.&mt('Sections').'</th>';
     $Str .= '<th>'.&mt('Groups').'</th>';
+    $Str .= '<th>'.&mt('Student Data').&Apache::loncommon::help_open_topic("Chart_Student_Data").'</th>';
     $Str .= '<th>'.&mt('Access Status').'</th>';
     $Str .= '<th>'.&mt('Options').'</th>';
     $Str .= '<th>'.&mt('Output Format').'</th>';
@@ -1211,6 +1304,10 @@ sub CreateInterface {
     $Str .= &Apache::lonstatistics::GroupSelect('Group','multiple',5);
     $Str .= '</td>';
     #
+    $Str .= '<td align="center">'."\n";
+    $Str .= &Apache::lonstatistics::StudentDataSelect('StudentData','multiple', 5,undef);
+    $Str .= '</td>';
+    #
     $Str .= '<td align="center">';
     $Str .= &Apache::lonhtmlcommon::StatusOptions(undef,undef,5);
     $Str .= '</td>';
@@ -1245,18 +1342,21 @@ sub CreateInterface {
     }
     $prob_status_checkbox .= 'value="true" />';
     #
-    $Str .= '<td align="right" valign="top">'.
-        '<label><b>'.
-        &mt('Show problem').' '.$prob_checkbox.'</b></label><br />'.
-        '<label><b>'.
-        &mt('Show correct answers').' '.$ans_checkbox.'</b></label><br />'.
-        '<label><b>'.
-        &mt('Show all submissions').' '.$all_sub_checkbox.
-        '</b></label><br />'.
-        '<label><b>'.
-        &mt('Show problem grading').' '.$prob_status_checkbox.
-        '</b></label><br />'.
-        '</td>';
+    $Str .=
+        '<td valign="top">'
+       .'<label>'
+       .$prob_checkbox.&mt('Show problem')
+       .'</label><br />'
+       .'<label>'
+       .' '.$ans_checkbox.&mt('Show correct answers')
+       .'</label><br />'
+       .'<label>'
+       .$all_sub_checkbox.&mt('Show all submissions')
+       .'</label><br />'
+       .'<label>'
+       .$prob_status_checkbox.&mt('Show problem grading')
+       .'</label>'
+       .'</td>';
     #
     $Str .= '<td align="center" valign="top">'.$output_selector.'</td>';
     #