--- loncom/interface/statistics/lonstudentsubmissions.pm 2011/11/18 22:35:33 1.54.10.4 +++ loncom/interface/statistics/lonstudentsubmissions.pm 2009/12/16 13:01:01 1.55 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonstudentsubmissions.pm,v 1.54.10.4 2011/11/18 22:35:33 raeburn Exp $ +# $Id: lonstudentsubmissions.pm,v 1.55 2009/12/16 13:01:01 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -37,7 +37,6 @@ use Apache::lonstathelpers; use HTML::Entities(); use Time::Local(); use Spreadsheet::WriteExcel(); -use Crypt::PasswdMD5; use lib '/home/httpd/lib/perl/'; use LONCAPA; @@ -77,7 +76,7 @@ sub BuildStudentSubmissionsPage { '
'.&mt('Loading student data...').'
'); $r->rflush(); # - if ((exists($env{'form.problemchoice'}) || (exists($env{'form.allproblems'}))) && + if (exists($env{'form.problemchoice'}) && ! exists($env{'form.SelectAnother'})) { foreach my $button (@SubmitButtons) { if ($button->{'name'} eq 'break') { @@ -95,76 +94,32 @@ sub BuildStudentSubmissionsPage { $r->print('
'.$/); $r->rflush(); # - - # - # Get resource objects - my $navmap = Apache::lonnavmaps::navmap->new(); - # Determine which problems we are to analyze my @Symbs = &Apache::lonstathelpers::get_selected_symbs('problemchoice'); - if (defined($navmap)) { - if ($env{'form.allproblems'}) { - my $iterator = $navmap->getIterator(undef, undef, undef, 1); - while (my $curRes = $iterator->next()) { - next if (! ref($curRes)); - if ($curRes->is_problem) { - my $symb = $curRes->symb; - unless(grep(/^\Q$symb\E$/,@Symbs)) { - push(@Symbs,$symb); - } - } - } - } - } foreach my $selected (@Symbs) { $r->print(''.$/); } + # + # Get resource objects + my $navmap = Apache::lonnavmaps::navmap->new(); if (!defined($navmap)) { $r->print('
'.&mt("Internal error").'
'); return; } my %already_seen; - my (@Problems,$show_named); - unless (&Apache::loncommon::needs_gci_custom()) { - unless ($env{'form.anonymized'} eq 'true') { - $show_named = 1; - } - } + my @Problems; foreach my $symb (@Symbs) { my $resource = $navmap->getBySymb($symb); push(@Problems,$resource); } - # If these are to be anonymized, do a random shuffle of @Students. - unless ($show_named) { - &array_shuffle(\@Students); - } - my $threshold = $env{'course.'.$env{'request.course.id'}.'.internal.anonsurvey_threshold'}; - if ($threshold eq '') { - my %domconfig = - &Apache::lonnet::get_dom('configuration',['coursedefaults'], - $env{'course.'.$env{'request.course.id'}.'.domain'}); - if (ref($domconfig{'coursedefaults'}) eq 'HASH') { - $threshold = $domconfig{'coursedefaults'}{'anonsurvey_threshold'}; - if ($threshold eq '') { - $threshold = 10; - } - } else { - $threshold = 10; - } - } - unless (&Apache::loncommon::needs_gci_custom()) { - $threshold = 0; - } # $r->print('

'. &Apache::lonstatistics::section_and_enrollment_description(). '

'); if (! scalar(@Problems) || ! defined($Problems[0])) { $r->print('resource is undefined'); - } elsif (!$show_named && @Students < $threshold) { - $r->print(&mt('The number of students matching the selection criteria is too few for display of submission data for anonymous surveys.').'
'.&mt('There must be at least [quant,_1,student].',$threshold).' '.&mt('Contact the LON-CAPA [_1]Helpdesk[_2] if you need the threshold to be changed for this course.','$title}; } elsif ($single_response) { @@ -400,25 +325,9 @@ sub prepare_html_output { $count = 0; } last if ($c->aborted()); - if ($show_named) { - foreach my $field (@student_columns) { - $student_row_data .= ''; - # handle comments like in lonstudentassessment.pm - if($field eq 'comments') { - $student_row_data .= - ''.&mt('Comments').''; - } else { - $student_row_data .= $student->{$field}; - } - $student_row_data .= ''; - } - } else { - my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'}, - $salt); - $anonid = substr($anonid,length($salt)+1); - $student_row_data = ''. - $anonid.''; + foreach my $field (@student_columns) { + $student_row_data .= + ''.$student->{$field}.''; } # # Figure out what it is we need to output for this student @@ -535,7 +444,6 @@ sub prepare_html_output { undef(@essays); } } # end of student loop - $r->print(''.$/); return; } @@ -717,9 +625,8 @@ sub html_non_essay_results { ######################################################### ######################################################### sub prepare_excel_output { - my ($r,$Problems,$Students,$show_named) = @_; + my ($r,$Problems,$Students) = @_; my $c = $r->connection(); - my $salt = '$1$'.$Apache::lonnet::perlvar{'AnonymousSalt'}; # # # Determine the number of columns in the spreadsheet @@ -788,12 +695,7 @@ sub prepare_excel_output { $worksheet->write($partid_row,0,'Part ID',$format->{'bold'}); $worksheet->write($respid_row,0,'Response ID',$format->{'bold'}); # Student headers - my @StudentColumns; - if ($show_named) { - @StudentColumns = qw(username domain id section); - } else { - @StudentColumns = qw(username); - } + my @StudentColumns = ('username','domain','id','section'); foreach (@StudentColumns) { $worksheet->write($header_row,$cols_output++,ucfirst($_), $format->{'bold'}); @@ -802,9 +704,6 @@ sub prepare_excel_output { my %start_col; foreach my $prob (@$Problems) { my $title = $prob->compTitle; - unless (&Apache::loncommon::needs_gci_custom()) { - ($title) = ($prob->src =~ m{/([^/]+)$}); - } $worksheet->write($title_row,$cols_output, $title,$format->{'h3'}); foreach my $partid (@{$prob->parts}) { @@ -843,9 +742,11 @@ sub prepare_excel_output { last if ($c->aborted()); $cols_output = 0; my $student_row = $max_row; - my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'}, - $salt); - $anonid = substr($anonid,length($salt)+1); + foreach my $field (@StudentColumns) { + $worksheet->write($student_row,$cols_output++, + $student->{$field}); + } + my $last_student_col = $cols_output-1; foreach my $prob (@$Problems) { foreach my $partid (@{$prob->parts}) { my @Response = $prob->responseIds($partid); @@ -895,16 +796,11 @@ sub prepare_excel_output { } } # Fill in the remaining rows with the students data - for (my $row = $student_row;$row<$max_row;$row++) { + for (my $row = $student_row+1;$row<$max_row;$row++) { my $cols = 0; foreach my $field (@StudentColumns) { - if ($show_named) { - $worksheet->write($row,$cols++, - $student->{$field}); - } else { - $worksheet->write($row,$cols++, - $anonid); - } + $worksheet->write($row,$cols++, + $student->{$field}); } } &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state, @@ -1014,9 +910,8 @@ sub excel_format_item { ######################################################### ######################################################### sub prepare_csv_output { - my ($r,$problems,$students,$show_named) = @_; + my ($r,$problems,$students) = @_; my $c = $r->connection(); - my $salt = '$1$'.$Apache::lonnet::perlvar{'AnonymousSalt'}; # $r->print('

'. &mt('Generating CSV report of student responses').'

'); @@ -1036,24 +931,21 @@ sub prepare_csv_output { time.'_'.rand(1000000000).'.csv'; unless ($outputfile = Apache::File->new('>/home/httpd'.$filename)) { $r->log_error("Couldn't open $filename for output $!"); - $r->print('
' - .&mt('Problems occurred in writing the CSV file. ' - .'This error has been logged. ' - .'Please alert your LON-CAPA administrator.') - .'
'); + $r->print( + '

' + .&mt('Problems occurred in writing the CSV file.') + .' '.&mt('This error has been logged.') + .' '.&mt('Please alert your LON-CAPA administrator.') + .'

' + ); $outputfile = undef; } # # Compute the number of columns per response - my @extra_resp_headers = &get_extra_response_headers($show_named); + my @extra_resp_headers = &get_extra_response_headers(); # # Create the table header - my @student_columns; - if ($show_named) { - @student_columns = qw(username domain id section); - } else { - @student_columns = qw(username); - } + my @student_columns = ('username','domain','id','section'); # my %headers; push(@{$headers{'student'}},@student_columns); @@ -1069,11 +961,7 @@ sub prepare_csv_output { foreach my $prob (@$problems) { my %analysis = &Apache::lonstathelpers::get_problem_data($prob->src); $problem_analysis{$prob->src}=\%analysis; - my $title = $prob->compTitle; - unless (&Apache::loncommon::needs_gci_custom()) { - ($title) = ($prob->src =~ m{/([^/]+)$}); - } - $headers{'problem'}->[$max_column] = $title; + $headers{'problem'}->[$max_column] = $prob->compTitle; foreach my $partid (@{$prob->parts}) { $headers{'part'}->[$max_column] = $prob->part_display($partid); my $responses = [$prob->responseIds($partid)]; @@ -1106,9 +994,6 @@ sub prepare_csv_output { # Main loop foreach my $student (@$students) { last if ($c->aborted()); - my $anonid = &Crypt::PasswdMD5::unix_md5_crypt($student->{'username'}, - $salt); - $anonid = substr($anonid,length($salt)+1); my @rows; foreach my $prob (@$problems) { foreach my $partid (@{$prob->parts}) { @@ -1149,15 +1034,9 @@ sub prepare_csv_output { } } foreach my $row (@rows) { - my $student_row_data = ''; - if ($show_named) { - $student_row_data = '"'.join('","', - map { $student->{$_}; } - @student_columns).'"'; - } else { - $student_row_data = '"'.$anonid.'"'; - } - print $outputfile $student_row_data; + print $outputfile '"'.join('","', + map { $student->{$_}; } + @student_columns).'"'; for (my $i=scalar(@student_columns);$i<$max_column;$i++) { my $value = &Apache::loncommon::csv_translate($row->[$i]); $value ||=''; @@ -1204,7 +1083,7 @@ sub CreateInterface { foreach ('HTML','Excel','CSV') { $output_selector .= '