--- loncom/interface/statistics/lonsubmissiontimeanalysis.pm 2005/03/14 20:28:22 1.22 +++ loncom/interface/statistics/lonsubmissiontimeanalysis.pm 2008/10/23 09:07:51 1.29 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonsubmissiontimeanalysis.pm,v 1.22 2005/03/14 20:28:22 matthew Exp $ +# $Id: lonsubmissiontimeanalysis.pm,v 1.29 2008/10/23 09:07:51 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -28,7 +28,7 @@ package Apache::lonsubmissiontimeanalysis; use strict; -use Apache::lonnet(); +use Apache::lonnet; use Apache::loncommon(); use Apache::lonhtmlcommon(); use Apache::loncoursedata(); @@ -78,13 +78,14 @@ sub BuildSubmissionTimePage { &Apache::lonstathelpers::manage_caches($r,'Statistics','stats_status'); $r->rflush(); # - if (! exists($ENV{'form.problemchoice'}) || - exists($ENV{'form.SelectAnother'})) { - $r->print(''); - $r->print(' 'x5); + if (! exists($env{'form.problemchoice'}) || + exists($env{'form.SelectAnother'})) { + my $submit_button = ''; + $r->print($submit_button.' 'x5); $r->print('

'.&mt('Please select a problem to analyze').'

'); - $r->print(&Apache::lonstathelpers::problem_selector('.')); + $r->print(&Apache::lonstathelpers::problem_selector('.', + $submit_button)); } else { foreach my $button (@SubmitButtons) { $r->print('print(''); + $env{'form.problemchoice'}.'" />'); # $r->print('
'); $r->rflush(); @@ -134,8 +135,10 @@ sub BuildSubmissionTimePage { $r->print(&Apache::lonstathelpers::render_resource($resource)); $r->print('
'); $r->rflush(); - $r->print(&analyze_times($r,$resource->symb,\@Students, - $current_problem->{'part'})); + if (@Students) { + $r->print(&analyze_times($r,$resource->symb,\@Students, + $current_problem->{'part'})); + } } $r->print('
'); } @@ -173,6 +176,7 @@ sub analyze_times { # Get the data my $SubData = &Apache::loncoursedata::get_response_time_data ([&Apache::lonstatistics::get_selected_sections()], + [&Apache::lonstatistics::get_selected_groups()], $Apache::lonstatistics::enrollment_status, $symb,$part); if (! defined($SubData) || ! ref($SubData)) { @@ -388,18 +392,19 @@ sub Process_Row { sub CreateInterface { ## ## Environment variable initialization - if (! exists$ENV{'form.AnalyzeOver'}) { - $ENV{'form.AnalyzeOver'} = 'Tries'; + if (! exists$env{'form.AnalyzeOver'}) { + $env{'form.AnalyzeOver'} = 'Tries'; } ## ## Build the menu my $Str = ''; - $Str .= &Apache::lonhtmlcommon::breadcrumbs(undef,'Submission Time Plots'); + $Str .= &Apache::lonhtmlcommon::breadcrumbs('Submission Time Plots'); $Str .= '

'; $Str .= ''."\n"; $Str .= ''; $Str .= ''; - $Str .= ''; + $Str .= ''; + $Str .= ''; $Str .= ''."\n"; ## ## @@ -407,6 +412,10 @@ sub CreateInterface { $Str .= &Apache::lonstatistics::SectionSelect('Section','multiple',4); $Str .= ''; # + $Str .= ''; + # $Str .= ''; @@ -414,10 +423,12 @@ sub CreateInterface { $Str .= ''."\n"; $Str .= '
'.&mt('Sections').''.&mt('Enrollment Status').''.&mt('Groups').''.&mt('Access Status').'
'."\n"; + $Str .= &Apache::lonstatistics::GroupSelect('Group','multiple',4); + $Str .= ''; $Str .= &Apache::lonhtmlcommon::StatusOptions(undef,undef,4); $Str .= '
'."\n"; # - $Str .= ''.&mt('Status: [_1]', - ''). - ''.'

'; + $Str .= '

' + .&mt('Status: [_1]', + '') + .'

'; + $Str .= '

'; ## return $Str; }