--- loncom/lond	2004/10/21 16:05:50	1.263
+++ loncom/lond	2005/01/01 02:31:05	1.272
@@ -2,7 +2,7 @@
 # The LearningOnline Network
 # lond "LON Daemon" Server (port "LOND" 5663)
 #
-# $Id: lond,v 1.263 2004/10/21 16:05:50 albertel Exp $
+# $Id: lond,v 1.272 2005/01/01 02:31:05 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -46,6 +46,7 @@ use Authen::Krb5;
 use lib '/home/httpd/lib/perl/';
 use localauth;
 use localenroll;
+use localstudentphoto;
 use File::Copy;
 use LONCAPA::ConfigFileEdit;
 use LONCAPA::lonlocal;
@@ -57,7 +58,7 @@ my $DEBUG = 0;		       # Non zero to ena
 my $status='';
 my $lastlog='';
 
-my $VERSION='$Revision: 1.263 $'; #' stupid emacs
+my $VERSION='$Revision: 1.272 $'; #' stupid emacs
 my $remoteVERSION;
 my $currenthostid="default";
 my $currentdomainid;
@@ -1311,8 +1312,10 @@ sub user_authorization_type {
 	my ($type,$otherinfo) = split(/:/,$result);
 	if($type =~ /^krb/) {
 	    $type = $result;
-	}
-	&Reply( $replyfd, "$type:\n", $userinput);
+	} else {
+            $type .= ':';
+        }
+	&Reply( $replyfd, "$type\n", $userinput);
     }
   
     return 1;
@@ -1725,18 +1728,10 @@ sub add_user_handler {
 	if (-e $passfilename) {
 	    &Failure( $client, "already_exists\n", $userinput);
 	} else {
-	    my @fpparts=split(/\//,$passfilename);
-	    my $fpnow=$fpparts[0].'/'.$fpparts[1].'/'.$fpparts[2];
 	    my $fperror='';
-	    for (my $i=3;$i<= ($#fpparts-1);$i++) {
-		$fpnow.='/'.$fpparts[$i]; 
-		unless (-e $fpnow) {
-		    &logthis("mkdir $fpnow");
-		    unless (mkdir($fpnow,0777)) {
-			$fperror="error: ".($!+0)." mkdir failed while attempting "
-			    ."makeuser";
-		    }
-		}
+	    if (!&mkpath($passfilename)) {
+		$fperror="error: ".($!+0)." mkdir failed while attempting "
+		    ."makeuser";
 	    }
 	    unless ($fperror) {
 		my $result=&make_passwd_file($uname, $umode,$npass, $passfilename);
@@ -1967,21 +1962,10 @@ sub fetch_user_file_handler {
 	# Note that any regular files in the way of this path are
 	# wiped out to deal with some earlier folly of mine.
 
-	my $path = $udir;
-	if ($ufile =~m|(.+)/([^/]+)$|) {
-	    my @parts=split('/',$1);
-	    foreach my $part (@parts) {
-		$path .= '/'.$part;
-		if( -f $path) {
-		    unlink($path);
-		}
-		if ((-e $path)!=1) {
-		    mkdir($path,0770);
-		}
-	    }
+	if (!&mkpath($udir.'/'.$ufile)) {
+	    &Failure($client, "unable_to_create\n", $userinput);	    
 	}
 
-
 	my $destname=$udir.'/'.$ufile;
 	my $transname=$udir.'/'.$ufile.'.in.transit';
 	my $remoteurl='http://'.$clientip.'/userfiles/'.$fname;
@@ -2090,24 +2074,11 @@ sub mkdir_user_file_handler {
     } else {
 	my $udir = &propath($udom,$uname);
 	if (-e $udir) {
-	    my $newdir=$udir.'/userfiles/'.$ufile;
-	    if (!-e $newdir) {
-		my @parts=split('/',$newdir);
-		my $path;
-		foreach my $part (@parts) {
-		    $path .= '/'.$part;
-		    if (!-e $path) {
-			mkdir($path,0770);
-		    }
-		}
-		if (!-e $newdir) {
-		    &Failure($client, "failed\n", "$cmd:$tail");
-		} else {
-		    &Reply($client, "ok\n", "$cmd:$tail");
-		}
-	    } else {
-		&Failure($client, "not_found\n", "$cmd:$tail");
+	    my $newdir=$udir.'/userfiles/'.$ufile.'/';
+	    if (!&mkpath($newdir)) {
+		&Failure($client, "failed\n", "$cmd:$tail");
 	    }
+	    &Reply($client, "ok\n", "$cmd:$tail");
 	} else {
 	    &Failure($client, "not_home\n", "$cmd:$tail");
 	}
@@ -2866,7 +2837,7 @@ sub store_handler {
 	chomp($what);
 	my @pairs=split(/\&/,$what);
 	my $hashref  = &tie_user_hash($udom, $uname, $namespace,
-				       &GDBM_WRCREAT(), "P",
+				       &GDBM_WRCREAT(), "S",
 				       "$rid:$what");
 	if ($hashref) {
 	    my $now = time;
@@ -3137,6 +3108,14 @@ sub reply_query_handler {
 #   $tail     - Tail of the command.  In this case consists of a colon
 #               separated list contaning the domain to apply this to and
 #               an ampersand separated list of keyword=value pairs.
+#               Each value is a colon separated list that includes:  
+#               description, institutional code and course owner.
+#               For backward compatibility with versions included
+#               in LON-CAPA 1.1.X (and earlier) and 1.2.X, institutional
+#               code and/or course owner are preserved from the existing 
+#               record when writing a new record in response to 1.1 or 
+#               1.2 implementations of lonnet::flushcourselogs().   
+#                      
 #   $client   - Socket open on the client.
 # Returns:
 #   1    - indicating that processing should continue
@@ -3150,7 +3129,7 @@ sub put_course_id_handler {
 
     my $userinput = "$cmd:$tail";
 
-    my ($udom, $what) = split(/:/, $tail);
+    my ($udom, $what) = split(/:/, $tail,2);
     chomp($what);
     my $now=time;
     my @pairs=split(/\&/,$what);
@@ -3158,8 +3137,24 @@ sub put_course_id_handler {
     my $hashref = &tie_domain_hash($udom, "nohist_courseids", &GDBM_WRCREAT());
     if ($hashref) {
 	foreach my $pair (@pairs) {
-	    my ($key,$descr,$inst_code)=split(/=/,$pair);
-	    $hashref->{$key}=$descr.':'.$inst_code.':'.$now;
+            my ($key,$courseinfo) = split(/=/,$pair,2);
+            $courseinfo =~ s/=/:/g;
+
+            my @current_items = split/:/,$hashref->{$key};
+            shift @current_items; # remove description
+            pop @current_items;   # remove last access
+            my $numcurrent = scalar(@current_items);
+
+            my @new_items = split/:/,$courseinfo;
+            my $numnew = scalar(@new_items);
+            if ($numcurrent > 0) {
+                if ($numnew == 1) { # flushcourselogs() from 1.1 or earlier
+                    $courseinfo .= ':'.join(':',@current_items);
+                } elsif ($numnew == 2) { # flushcourselogs() from 1.2.X
+                    $courseinfo .= ':'.$current_items[$numcurrent-1];
+                }
+            }
+	    $hashref->{$key}=$courseinfo.':'.$now;
 	}
 	if (untie(%$hashref)) {
 	    &Reply( $client, "ok\n", $userinput);
@@ -3197,6 +3192,14 @@ sub put_course_id_handler {
 #                 description - regular expression that is used to filter
 #                            the dump.  Only keywords matching this regexp
 #                            will be used.
+#                 institutional code - optional supplied code to filter 
+#                            the dump. Only courses with an institutional code 
+#                            that match the supplied code will be returned.
+#                 owner    - optional supplied username of owner to filter
+#                            the dump.  Only courses for which the course 
+#                            owner matches the supplied username will be
+#                            returned. Implicit assumption that owner is a user
+#                            in the domain in which the course database is defined.        
 #     $client  - The socket open on the client.
 # Returns:
 #    1     - Continue processing.
@@ -3207,32 +3210,61 @@ sub dump_course_id_handler {
 
     my $userinput = "$cmd:$tail";
 
-    my ($udom,$since,$description) =split(/:/,$tail);
+    my ($udom,$since,$description,$instcodefilter,$ownerfilter) =split(/:/,$tail);
     if (defined($description)) {
 	$description=&unescape($description);
     } else {
 	$description='.';
     }
+    if (defined($instcodefilter)) {
+        $instcodefilter=&unescape($instcodefilter);
+    } else {
+        $instcodefilter='.';
+    }
+    if (defined($ownerfilter)) {
+        $ownerfilter=&unescape($ownerfilter);
+    } else {
+        $ownerfilter='.';
+    }
+
     unless (defined($since)) { $since=0; }
     my $qresult='';
     my $hashref = &tie_domain_hash($udom, "nohist_courseids", &GDBM_WRCREAT());
     if ($hashref) {
 	while (my ($key,$value) = each(%$hashref)) {
-	    my ($descr,$lasttime,$inst_code);
-	    if ($value =~ m/^([^\:]*):([^\:]*):(\d+)$/) {
-		($descr,$inst_code,$lasttime)=($1,$2,$3);
-	    } else {
-		($descr,$lasttime) = split(/\:/,$value);
-	    }
+	    my ($descr,$lasttime,$inst_code,$owner);
+            my @courseitems = split/:/,$value;
+            $descr = shift @courseitems;
+            $lasttime = pop @courseitems;
+            if (@courseitems > 0) {
+                $inst_code = shift @courseitems;
+            }
+            if (@courseitems > 0) {
+                $owner = shift @courseitems;
+            }
 	    if ($lasttime<$since) { next; }
-	    if ($description eq '.') {
-		$qresult.=$key.'='.$descr.':'.$inst_code.'&';
-	    } else {
-		my $unescapeVal = &unescape($descr);
-		if (eval('$unescapeVal=~/\Q$description\E/i')) {
-		    $qresult.=$key.'='.$descr.':'.$inst_code.'&';
+            my $match = 1;
+	    unless ($description eq '.') {
+		my $unescapeDescr = &unescape($descr);
+		unless (eval('$unescapeDescr=~/\Q$description\E/i')) {
+                    $match = 0;
 		}
+            }
+            unless ($instcodefilter eq '.' || !defined($instcodefilter)) {
+                my $unescapeInstcode = &unescape($inst_code);
+                unless (eval('$unescapeInstcode=~/\Q$instcodefilter\E/i')) {
+                    $match = 0;
+                }
 	    }
+            unless ($ownerfilter eq '.' || !defined($ownerfilter)) {
+                my $unescapeOwner = &unescape($owner);
+                unless (eval('$unescapeOwner=~/\Q$ownerfilter\E/i')) {
+                    $match = 0;
+                }
+            }
+            if ($match == 1) {
+                $qresult.=$key.'='.$descr.':'.$inst_code.':'.$owner.'&';
+            }
 	}
 	if (untie(%$hashref)) {
 	    chop($qresult);
@@ -3824,15 +3856,63 @@ sub get_institutional_code_format_handle
     
     return 1;
 }
+&register_handler("autoinstcodeformat",
+		  \&get_institutional_code_format_handler,0,1,0);
 
-&register_handler("autoinstcodeformat", \&get_institutional_code_format_handler,
-		  0,1,0);
-
-#
-#
-#
-#
 #
+# Gets a student's photo to exist (in the correct image type) in the user's 
+# directory.
+# Formal Parameters:
+#    $cmd     - The command request that got us dispatched.
+#    $tail    - A colon separated set of words that will be split into:
+#               $domain - student's domain
+#               $uname  - student username
+#               $type   - image type desired
+#    $client  - The socket open on the client.
+# Returns:
+#    1 - continue processing.
+sub student_photo_handler {
+    my ($cmd, $tail, $client) = @_;
+    my ($domain,$uname,$type) = split(/:/, $tail);
+
+    my $path=&propath($domain,$uname).
+	'/userfiles/internal/studentphoto.'.$type;
+    if (-e $path) {
+	&Reply($client,"ok\n","$cmd:$tail");
+	return 1;
+    }
+    &mkpath($path);
+    my $file=&localstudentphoto::fetch($domain,$uname);
+    if (!$file) {
+	&Failure($client,"unavailable\n","$cmd:$tail");
+	return 1;
+    }
+    if (!-e $path) { &convert_photo($file,$path); }
+    if (-e $path) {
+	&Reply($client,"ok\n","$cmd:$tail");
+	return 1;
+    }
+    &Failure($client,"unable_to_convert\n","$cmd:$tail");
+    return 1;
+}
+&register_handler("studentphoto", \&student_photo_handler, 0, 1, 0);
+
+# mkpath makes all directories for a file, expects an absolute path with a
+# file or a trailing / if just a dir is passed
+# returns 1 on success 0 on failure
+sub mkpath {
+    my ($file)=@_;
+    my @parts=split(/\//,$file,-1);
+    my $now=$parts[0].'/'.$parts[1].'/'.$parts[2];
+    for (my $i=3;$i<= ($#parts-1);$i++) {
+	$now.='/'.$parts[$i]; 
+	if (!-e $now) {
+	    if  (!mkdir($now,0770)) { return 0; }
+	}
+    }
+    return 1;
+}
+
 #---------------------------------------------------------------
 #
 #   Getting, decoding and dispatching requests:
@@ -4887,12 +4967,7 @@ sub manage_permissions
 #
 sub password_path {
     my ($domain, $user) = @_;
-
-
-    my $path   = &propath($domain, $user);
-    $path  .= "/passwd";
-
-    return $path;
+    return &propath($domain, $user).'/passwd';
 }
 
 #   Password Filename
@@ -5065,7 +5140,7 @@ sub validate_user {
 		my $krbserver  = &Authen::Krb5::parse_name($krbservice);
 		my $credentials= &Authen::Krb5::cc_default();
 		$credentials->initialize($krbclient);
-		my $krbreturn  = &Authen::KRb5::get_in_tkt_with_password($krbclient,
+		my $krbreturn  = &Authen::Krb5::get_in_tkt_with_password($krbclient,
 									 $krbserver,
 									 $password,
 									 $credentials);
@@ -5403,6 +5478,11 @@ sub make_passwd_file {
     return $result;
 }
 
+sub convert_photo {
+    my ($start,$dest)=@_;
+    system("convert $start $dest");
+}
+
 sub sethost {
     my ($remotereq) = @_;
     my (undef,$hostid)=split(/:/,$remotereq);