--- loncom/lond 2018/04/29 00:40:49 1.489.2.29 +++ loncom/lond 2015/06/14 00:43:51 1.516 @@ -2,7 +2,7 @@ # The LearningOnline Network # lond "LON Daemon" Server (port "LOND" 5663) # -# $Id: lond,v 1.489.2.29 2018/04/29 00:40:49 raeburn Exp $ +# $Id: lond,v 1.516 2015/06/14 00:43:51 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -55,16 +55,13 @@ use LONCAPA::lonssl; use Fcntl qw(:flock); use Apache::lonnet; use Mail::Send; -use Crypt::Eksblowfish::Bcrypt; -use Digest::SHA; -use Encode; my $DEBUG = 0; # Non zero to enable debug log entries. my $status=''; my $lastlog=''; -my $VERSION='$Revision: 1.489.2.29 $'; #' stupid emacs +my $VERSION='$Revision: 1.516 $'; #' stupid emacs my $remoteVERSION; my $currenthostid="default"; my $currentdomainid; @@ -1425,22 +1422,6 @@ sub du2_handler { # selected directory the filename followed by the full output of # the stat function is returned. The returned info for each # file are separated by ':'. The stat fields are separated by &'s. -# -# If the requested path contains /../ or is: -# -# 1. for a directory, and the path does not begin with one of: -# (a) /home/httpd/html/res/<domain> -# (b) /home/httpd/html/userfiles/ -# (c) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/userfiles -# or is: -# -# 2. for a file, and the path (after prepending) does not begin with one of: -# (a) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/ -# (b) /home/httpd/html/res/<domain>/<username>/ -# (c) /home/httpd/html/userfiles/<domain>/<username>/ -# -# the response will be "refused". -# # Parameters: # $cmd - The command that dispatched us (ls). # $ulsdir - The directory path to list... I'm not sure what this @@ -1462,17 +1443,8 @@ sub ls_handler { my $rights; my $ulsout=''; my $ulsfn; - if ($ulsdir =~m{/\.\./}) { - &Failure($client,"refused\n",$userinput); - return 1; - } if (-e $ulsdir) { if(-d $ulsdir) { - unless (($ulsdir =~ m{^/home/httpd/html/(res/$LONCAPA::match_domain|userfiles/)}) || - ($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/userfiles})) { - &Failure($client,"refused\n",$userinput); - return 1; - } if (opendir(LSDIR,$ulsdir)) { while ($ulsfn=readdir(LSDIR)) { undef($obs); @@ -1496,11 +1468,6 @@ sub ls_handler { closedir(LSDIR); } } else { - unless (($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/}) || - ($ulsdir =~ m{^/home/httpd/html/(?:res|userfiles)/$LONCAPA::match_domain/$LONCAPA::match_name/})) { - &Failure($client,"refused\n",$userinput); - return 1; - } my @ulsstats=stat($ulsdir); $ulsout.=$ulsfn.'&'.join('&',@ulsstats).':'; } @@ -1525,22 +1492,6 @@ sub ls_handler { # selected directory the filename followed by the full output of # the stat function is returned. The returned info for each # file are separated by ':'. The stat fields are separated by &'s. -# -# If the requested path contains /../ or is: -# -# 1. for a directory, and the path does not begin with one of: -# (a) /home/httpd/html/res/<domain> -# (b) /home/httpd/html/userfiles/ -# (c) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/userfiles -# or is: -# -# 2. for a file, and the path (after prepending) does not begin with one of: -# (a) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/ -# (b) /home/httpd/html/res/<domain>/<username>/ -# (c) /home/httpd/html/userfiles/<domain>/<username>/ -# -# the response will be "refused". -# # Parameters: # $cmd - The command that dispatched us (ls). # $ulsdir - The directory path to list... I'm not sure what this @@ -1561,17 +1512,8 @@ sub ls2_handler { my $rights; my $ulsout=''; my $ulsfn; - if ($ulsdir =~m{/\.\./}) { - &Failure($client,"refused\n",$userinput); - return 1; - } if (-e $ulsdir) { if(-d $ulsdir) { - unless (($ulsdir =~ m{^/home/httpd/html/(res/$LONCAPA::match_domain|userfiles/)}) || - ($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/userfiles})) { - &Failure($client,"refused\n","$userinput"); - return 1; - } if (opendir(LSDIR,$ulsdir)) { while ($ulsfn=readdir(LSDIR)) { undef($obs); @@ -1596,11 +1538,6 @@ sub ls2_handler { closedir(LSDIR); } } else { - unless (($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/}) || - ($ulsdir =~ m{^/home/httpd/html/(?:res|userfiles)/$LONCAPA::match_domain/$LONCAPA::match_name/})) { - &Failure($client,"refused\n",$userinput); - return 1; - } my @ulsstats=stat($ulsdir); $ulsout.=$ulsfn.'&'.join('&',@ulsstats).':'; } @@ -1617,25 +1554,6 @@ sub ls2_handler { # selected directory the filename followed by the full output of # the stat function is returned. The returned info for each # file are separated by ':'. The stat fields are separated by &'s. -# -# If the requested path (after prepending) contains /../ or is: -# -# 1. for a directory, and the path does not begin with one of: -# (a) /home/httpd/html/res/<domain> -# (b) /home/httpd/html/userfiles/ -# (c) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/userfiles -# (d) /home/httpd/html/priv/<domain> and client is the homeserver -# -# or is: -# -# 2. for a file, and the path (after prepending) does not begin with one of: -# (a) /home/httpd/lonUsers/<domain>/<1>/<2>/<3>/<username>/ -# (b) /home/httpd/html/res/<domain>/<username>/ -# (c) /home/httpd/html/userfiles/<domain>/<username>/ -# (d) /home/httpd/html/priv/<domain>/<username>/ and client is the homeserver -# -# the response will be "refused". -# # Parameters: # $cmd - The command that dispatched us (ls). # $tail - The tail of the request that invoked us. @@ -1675,12 +1593,22 @@ sub ls3_handler { } my $dir_root = $perlvar{'lonDocRoot'}; - if (($getpropath) || ($getuserdir)) { + if ($getpropath) { if (($uname =~ /^$LONCAPA::match_name$/) && ($udom =~ /^$LONCAPA::match_domain$/)) { $dir_root = &propath($udom,$uname); $dir_root =~ s/\/$//; } else { - &Failure($client,"refused\n",$userinput); + &Failure($client,"refused\n","$cmd:$tail"); + return 1; + } + } elsif ($getuserdir) { + if (($uname =~ /^$LONCAPA::match_name$/) && ($udom =~ /^$LONCAPA::match_domain$/)) { + my $subdir=$uname.'__'; + $subdir =~ s/(.)(.)(.).*/$1\/$2\/$3/; + $dir_root = $Apache::lonnet::perlvar{'lonUsersDir'} + ."/$udom/$subdir/$uname"; + } else { + &Failure($client,"refused\n","$cmd:$tail"); return 1; } } elsif ($alternate_root ne '') { @@ -1693,28 +1621,12 @@ sub ls3_handler { $ulsdir = $dir_root.'/'.$ulsdir; } } - if ($ulsdir =~m{/\.\./}) { - &Failure($client,"refused\n",$userinput); - return 1; - } - my $islocal; - my @machine_ids = &Apache::lonnet::current_machine_ids(); - if (grep(/^\Q$clientname\E$/,@machine_ids)) { - $islocal = 1; - } my $obs; my $rights; my $ulsout=''; my $ulsfn; if (-e $ulsdir) { if(-d $ulsdir) { - unless (($getpropath) || ($getuserdir) || - ($ulsdir =~ m{^/home/httpd/html/(res/$LONCAPA::match_domain|userfiles/)}) || - ($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/userfiles}) || - (($ulsdir =~ m{^/home/httpd/html/priv/$LONCAPA::match_domain}) && ($islocal))) { - &Failure($client,"refused\n",$userinput); - return 1; - } if (opendir(LSDIR,$ulsdir)) { while ($ulsfn=readdir(LSDIR)) { undef($obs); @@ -1739,13 +1651,6 @@ sub ls3_handler { closedir(LSDIR); } } else { - unless (($getpropath) || ($getuserdir) || - ($ulsdir =~ m{^/home/httpd/lonUsers/$LONCAPA::match_domain(?:/[\w\-.@]){3}/$LONCAPA::match_name/}) || - ($ulsdir =~ m{^/home/httpd/html/(?:res|userfiles)/$LONCAPA::match_domain/$LONCAPA::match_name/}) || - (($ulsdir =~ m{^/home/httpd/html/priv/$LONCAPA::match_domain/$LONCAPA::match_name/}) && ($islocal))) { - &Failure($client,"refused\n",$userinput); - return 1; - } my @ulsstats=stat($ulsdir); $ulsout.=$ulsfn.'&'.join('&',@ulsstats).':'; } @@ -2027,12 +1932,8 @@ sub authenticate_handler { if (ref($hostedsession) eq 'HASH') { $hosted = $hostedsession->{'hosted'}; } - my $loncaparev = $clientversion; - if ($loncaparev eq '') { - $loncaparev = $Apache::lonnet::loncaparevs{$clientname}; - } $canhost = &Apache::lonnet::can_host_session($udom,$clientname, - $loncaparev, + $clientversion, $remote,$hosted); } } @@ -2112,14 +2013,15 @@ sub change_password_handler { my ($howpwd,$contentpwd)=split(/:/,$realpasswd); if ($howpwd eq 'internal') { &Debug("internal auth"); - my $ncpass = &hash_passwd($udom,$npass); + my $salt=time; + $salt=substr($salt,6,2); + my $ncpass=crypt($npass,$salt); if(&rewrite_password_file($udom, $uname, "internal:$ncpass")) { my $msg="Result of password change for $uname: pwchange_success"; if ($lonhost) { $msg .= " - request originated from: $lonhost"; } &logthis($msg); - &update_passwd_history($uname,$udom,$howpwd,$context); &Reply($client, "ok\n", $userinput); } else { &logthis("Unable to open $uname passwd " @@ -2128,9 +2030,6 @@ sub change_password_handler { } } elsif ($howpwd eq 'unix' && $context ne 'reset_by_email') { my $result = &change_unix_password($uname, $npass); - if ($result eq 'ok') { - &update_passwd_history($uname,$udom,$howpwd,$context); - } &logthis("Result of password change for $uname: ". $result); &Reply($client, \$result, $userinput); @@ -2153,38 +2052,6 @@ sub change_password_handler { } ®ister_handler("passwd", \&change_password_handler, 1, 1, 0); -sub hash_passwd { - my ($domain,$plainpass,@rest) = @_; - my ($salt,$cost); - if (@rest) { - $cost = $rest[0]; - # salt is first 22 characters, base-64 encoded by bcrypt - my $plainsalt = substr($rest[1],0,22); - $salt = Crypt::Eksblowfish::Bcrypt::de_base64($plainsalt); - } else { - my %domdefaults = &Apache::lonnet::get_domain_defaults($domain); - my $defaultcost = $domdefaults{'intauth_cost'}; - if (($defaultcost eq '') || ($defaultcost =~ /D/)) { - $cost = 10; - } else { - $cost = $defaultcost; - } - # Generate random 16-octet base64 salt - $salt = ""; - $salt .= pack("C", int rand(256)) for 1..16; - } - my $hash = &Crypt::Eksblowfish::Bcrypt::bcrypt_hash({ - key_nul => 1, - cost => $cost, - salt => $salt, - }, Digest::SHA::sha512(Encode::encode('UTF-8',$plainpass))); - - my $result = join("!", "", "bcrypt", sprintf("%02d",$cost), - &Crypt::Eksblowfish::Bcrypt::en_base64($salt). - &Crypt::Eksblowfish::Bcrypt::en_base64($hash)); - return $result; -} - # # Create a new user. User in this case means a lon-capa user. # The user must either already exist in some authentication realm @@ -2228,8 +2095,7 @@ sub add_user_handler { ."makeuser"; } unless ($fperror) { - my $result=&make_passwd_file($uname,$udom,$umode,$npass, - $passfilename,'makeuser'); + my $result=&make_passwd_file($uname,$udom,$umode,$npass, $passfilename); &Reply($client,\$result, $userinput); #BUGBUG - could be fail } else { &Failure($client, \$fperror, $userinput); @@ -2298,14 +2164,12 @@ sub change_authentication_handler { my $result = &change_unix_password($uname, $npass); &logthis("Result of password change for $uname: ".$result); if ($result eq "ok") { - &update_passwd_history($uname,$udom,$umode,'changeuserauth'); &Reply($client, \$result); } else { &Failure($client, \$result); } } else { - my $result=&make_passwd_file($uname,$udom,$umode,$npass, - $passfilename,'changeuserauth'); + my $result=&make_passwd_file($uname,$udom,$umode,$npass,$passfilename); # # If the current auth mode is internal, and the old auth mode was # unix, or krb*, and the user is an author for this domain, @@ -2326,17 +2190,6 @@ sub change_authentication_handler { } ®ister_handler("changeuserauth", \&change_authentication_handler, 1,1, 0); -sub update_passwd_history { - my ($uname,$udom,$umode,$context) = @_; - my $proname=&propath($udom,$uname); - my $now = time; - if (open(my $fh,">>$proname/passwd.log")) { - print $fh "$now:$umode:$context\n"; - close($fh); - } - return; -} - # # Determines if this is the home server for a user. The home server # for a user will have his/her lon-capa passwd file. Therefore all we need @@ -2588,20 +2441,11 @@ sub remove_user_file_handler { if (-e $file) { # # If the file is a regular file unlink is fine... - # However it's possible the client wants a dir - # removed, in which case rmdir is more appropriate - # Note: rmdir will only remove an empty directory. + # However it's possible the client wants a dir. + # removed, in which case rmdir is more approprate: # if (-f $file){ unlink($file); - # for html files remove the associated .bak file - # which may have been created by the editor. - if ($ufile =~ m{^((docs|supplemental)/(?:\d+|default)/\d+(?:|/.+)/)[^/]+\.x?html?$}i) { - my $path = $1; - if (-e $file.'.bak') { - unlink($file.'.bak'); - } - } } elsif(-d $file) { rmdir($file); } @@ -2968,8 +2812,8 @@ sub newput_user_profile_entry { &logthis("error: ".($!+0)." untie (GDBM) failed ". "while attempting newput - early out as key exists"); } - &Failure($client, "key_exists: ".$key."\n",$userinput); - return 1; + &Failure($client, "key_exists: ".$key."\n",$userinput); + return 1; } } @@ -3371,6 +3215,17 @@ sub get_profile_keys { sub dump_profile_database { my ($cmd, $tail, $client) = @_; + my $res = LONCAPA::Lond::dump_profile_database($tail); + + if ($res =~ /^error:/) { + Failure($client, \$res, "$cmd:$tail"); + } else { + Reply($client, \$res, "$cmd:$tail"); + } + + return 1; + + #TODO remove my $userinput = "$cmd:$tail"; my ($udom,$uname,$namespace) = split(/:/,$tail); @@ -3450,11 +3305,11 @@ sub dump_with_regexp { my ($cmd, $tail, $client) = @_; my $res = LONCAPA::Lond::dump_with_regexp($tail, $clientversion); - + if ($res =~ /^error:/) { - &Failure($client, \$res, "$cmd:$tail"); + Failure($client, \$res, "$cmd:$tail"); } else { - &Reply($client, \$res, "$cmd:$tail"); + Reply($client, \$res, "$cmd:$tail"); } return 1; @@ -3492,7 +3347,6 @@ sub store_handler { my ($cmd, $tail, $client) = @_; my $userinput = "$cmd:$tail"; - chomp($tail); my ($udom,$uname,$namespace,$rid,$what,$laststore) =split(/:/,$tail); if ($namespace ne 'roles') { @@ -3522,7 +3376,6 @@ sub store_handler { $numtrans =~ s/D//g; } } - $hashref->{"version:$rid"}++; my $version=$hashref->{"version:$rid"}; my $allkeys=''; @@ -3539,7 +3392,7 @@ sub store_handler { if ($numtrans) { $msg = 'delay:'.$numtrans; } - &Reply($client, "$msg\n", $userinput); + &Reply($client, "$msg\n", $userinput); } else { &Failure($client, "error: ".($!+0)." untie(GDBM) Failed ". "while attempting store\n", $userinput); @@ -3801,37 +3654,6 @@ sub send_query_handler { my ($query,$arg1,$arg2,$arg3)=split(/\:/,$tail); $query=~s/\n*$//g; - if (($query eq 'usersearch') || ($query eq 'instdirsearch')) { - my $usersearchconf = &get_usersearch_config($currentdomainid,'directorysrch'); - my $earlyout; - if (ref($usersearchconf) eq 'HASH') { - if ($currentdomainid eq $clienthomedom) { - if ($query eq 'usersearch') { - if ($usersearchconf->{'lcavailable'} eq '0') { - $earlyout = 1; - } - } else { - if ($usersearchconf->{'available'} eq '0') { - $earlyout = 1; - } - } - } else { - if ($query eq 'usersearch') { - if ($usersearchconf->{'lclocalonly'}) { - $earlyout = 1; - } - } else { - if ($usersearchconf->{'localonly'}) { - $earlyout = 1; - } - } - } - } - if ($earlyout) { - &Reply($client, "query_not_authorized\n"); - return 1; - } - } &Reply($client, "". &sql_reply("$clientname\&$query". "\&$arg1"."\&$arg2"."\&$arg3")."\n", $userinput); @@ -4087,7 +3909,7 @@ sub put_course_id_hash_handler { # # domcloner - flag to indicate if user can create CCs in course's domain. # If so, ability to clone course is automatic. -# hasuniquecode - filter by courses for which a six character unique code has +# hasuniquecode - filter by courses for which a six character unique code has # been set. # # $client - The socket open on the client. @@ -4097,6 +3919,17 @@ sub put_course_id_hash_handler { # a reply is written to $client. sub dump_course_id_handler { my ($cmd, $tail, $client) = @_; + + my $res = LONCAPA::Lond::dump_course_id_handler($tail); + if ($res =~ /^error:/) { + Failure($client, \$res, "$cmd:$tail"); + } else { + Reply($client, \$res, "$cmd:$tail"); + } + + return 1; + + #TODO remove my $userinput = "$cmd:$tail"; my ($udom,$since,$description,$instcodefilter,$ownerfilter,$coursefilter, @@ -4703,7 +4536,7 @@ sub get_id_handler { # Returns: # 1 - Continue processing # 0 - Exit server. -# +# # sub del_id_handler { @@ -5388,10 +5221,9 @@ sub validate_course_section_handler { # Formal Parameters: # $cmd - The command request that got us dispatched. # $tail - The tail of the command. In this case this is a colon separated -# set of values that will be split into: +# set of words that will be split into: # $inst_class - Institutional code for the specific class section -# $ownerlist - An escaped comma-separated list of username:domain -# of the course owner, and co-owner(s). +# $courseowner - The escaped username:domain of the course owner # $cdom - The domain of the course from the institution's # point of view. # $client - The socket open on the client. @@ -5416,56 +5248,6 @@ sub validate_class_access_handler { ®ister_handler("autovalidateclass_sec", \&validate_class_access_handler, 0, 1, 0); # -# Validate course owner or co-owners(s) access to enrollment data for all sections -# and crosslistings for a particular course. -# -# -# Formal Parameters: -# $cmd - The command request that got us dispatched. -# $tail - The tail of the command. In this case this is a colon separated -# set of values that will be split into: -# $ownerlist - An escaped comma-separated list of username:domain -# of the course owner, and co-owner(s). -# $cdom - The domain of the course from the institution's -# point of view. -# $classes - Frozen hash of institutional course sections and -# crosslistings. -# $client - The socket open on the client. -# Returns: -# 1 - continue processing. -# - -sub validate_classes_handler { - my ($cmd, $tail, $client) = @_; - my $userinput = "$cmd:$tail"; - my ($ownerlist,$cdom,$classes) = split(/:/, $tail); - my $classesref = &Apache::lonnet::thaw_unescape($classes); - my $owners = &unescape($ownerlist); - my $result; - eval { - local($SIG{__DIE__})='DEFAULT'; - my %validations; - my $response = &localenroll::check_instclasses($owners,$cdom,$classesref, - \%validations); - if ($response eq 'ok') { - foreach my $key (keys(%validations)) { - $result .= &escape($key).'='.&Apache::lonnet::freeze_escape($validations{$key}).'&'; - } - $result =~ s/\&$//; - } else { - $result = 'error'; - } - }; - if (!$@) { - &Reply($client, \$result, $userinput); - } else { - &Failure($client,"unknown_cmd\n",$userinput); - } - return 1; -} -®ister_handler("autovalidateinstclasses", \&validate_classes_handler, 0, 1, 0); - -# # Create a password for a new LON-CAPA user added by auto-enrollment. # Only used for case where authentication method for new user is localauth # @@ -5500,59 +5282,13 @@ sub create_auto_enroll_password_handler ®ister_handler("autocreatepassword", \&create_auto_enroll_password_handler, 0, 1, 0); -sub auto_export_grades_handler { - my ($cmd, $tail, $client) = @_; - my $userinput = "$cmd:$tail"; - my ($cdom,$cnum,$info,$data) = split(/:/,$tail); - my $inforef = &Apache::lonnet::thaw_unescape($info); - my $dataref = &Apache::lonnet::thaw_unescape($data); - my ($outcome,$result);; - eval { - local($SIG{__DIE__})='DEFAULT'; - my %rtnhash; - $outcome=&localenroll::export_grades($cdom,$cnum,$inforef,$dataref,\%rtnhash); - if ($outcome eq 'ok') { - foreach my $key (keys(%rtnhash)) { - $result .= &escape($key).'='.&Apache::lonnet::freeze_escape($rtnhash{$key}).'&'; - } - $result =~ s/\&$//; - } - }; - if (!$@) { - if ($outcome eq 'ok') { - if ($cipher) { - my $cmdlength=length($result); - $result.=" "; - my $encresult=''; - for (my $encidx=0;$encidx<=$cmdlength;$encidx+=8) { - $encresult.= unpack("H16", - $cipher->encrypt(substr($result, - $encidx, - 8))); - } - &Reply( $client, "enc:$cmdlength:$encresult\n", $userinput); - } else { - &Failure( $client, "error:no_key\n", $userinput); - } - } else { - &Reply($client, "$outcome\n", $userinput); - } - } else { - &Failure($client,"export_error\n",$userinput); - } - return 1; -} -®ister_handler("autoexportgrades", \&auto_export_grades_handler, - 0, 1, 0); - - # Retrieve and remove temporary files created by/during autoenrollment. # # Formal Parameters: # $cmd - The command that got us dispatched. # $tail - The tail of the command. In our case this is a colon # separated list that will be split into: -# $filename - The name of the file to retrieve. +# $filename - The name of the file to remove. # The filename is given as a path relative to # the LonCAPA temp file directory. # $client - Socket open on the client. @@ -5566,11 +5302,7 @@ sub retrieve_auto_file_handler { my ($filename) = split(/:/, $tail); my $source = $perlvar{'lonDaemons'}.'/tmp/'.$filename; - if ($filename =~m{/\.\./}) { - &Failure($client, "refused\n", $userinput); - } elsif ($filename !~ /^$LONCAPA::match_domain\_$LONCAPA::match_courseid\_.+_classlist\.xml$/) { - &Failure($client, "refused\n", $userinput); - } elsif ( (-e $source) && ($filename ne '') ) { + if ( (-e $source) && ($filename ne '') ) { my $reply = ''; if (open(my $fh,$source)) { while (<$fh>) { @@ -6647,6 +6379,9 @@ sub Debug { # reply - Text to send to client. # request - Original request from client. # +#NOTE $reply must be terminated by exactly *one* \n. If $reply is a reference +#this is done automatically ($$reply must not contain any \n in this case). +#If $reply is a string the caller has to ensure this. sub Reply { my ($fd, $reply, $request) = @_; if (ref($reply)) { @@ -6900,7 +6635,7 @@ sub make_new_child { } } elsif ($dist =~ /^suse(\d+\.\d+)$/) { if (($1 eq '9.3') || ($1 >= 12.2)) { - $no_ets = 1; + $no_ets = 1; } } elsif ($dist =~ /^sles(\d+)$/) { if ($1 > 11) { @@ -6912,8 +6647,8 @@ sub make_new_child { } } unless ($no_ets) { - &Authen::Krb5::init_ets(); - } + &Authen::Krb5::init_ets(); + } &status('Accepted connection'); # ============================================================================= @@ -6957,12 +6692,12 @@ sub make_new_child { # If the remote is attempting a local init... give that a try: # (my $i, my $inittype, $clientversion) = split(/:/, $remotereq); - # For LON-CAPA 2.9, the client session will have sent its LON-CAPA - # version when initiating the connection. For LON-CAPA 2.8 and older, - # the version is retrieved from the global %loncaparevs in lonnet.pm. - # $clientversion contains path to keyfile if $inittype eq 'local' - # it's overridden below in this case - $clientversion ||= $Apache::lonnet::loncaparevs{$clientname}; + # For LON-CAPA 2.9, the client session will have sent its LON-CAPA + # version when initiating the connection. For LON-CAPA 2.8 and older, + # the version is retrieved from the global %loncaparevs in lonnet.pm. + # $clientversion contains path to keyfile if $inittype eq 'local' + # it's overridden below in this case + $clientversion ||= $Apache::lonnet::loncaparevs{$clientname}; # If the connection type is ssl, but I didn't get my # certificate files yet, then I'll drop back to @@ -7027,6 +6762,7 @@ sub make_new_child { ."Attempted insecure connection disallowed </font>"); close $client; $clientok = 0; + } } } else { @@ -7035,6 +6771,7 @@ sub make_new_child { ."$clientip failed to initialize: >$remotereq< </font>"); &status('No init '.$clientip); } + } else { &logthis( "<font color='blue'>WARNING: Unknown client $clientip</font>"); @@ -7192,25 +6929,15 @@ sub password_filename { # domain - domain of the user. # name - User's name. # contents - New contents of the file. -# saveold - (optional). If true save old file in a passwd.bak file. # Returns: # 0 - Failed. # 1 - Success. # sub rewrite_password_file { - my ($domain, $user, $contents, $saveold) = @_; + my ($domain, $user, $contents) = @_; my $file = &password_filename($domain, $user); if (defined $file) { - if ($saveold) { - my $bakfile = $file.'.bak'; - if (CopyFile($file,$bakfile)) { - chmod(0400,$bakfile); - &logthis("Old password saved in passwd.bak for internally authenticated user: $user:$domain"); - } else { - &logthis("Failed to save old password in passwd.bak for internally authenticated user: $user:$domain"); - } - } my $pf = IO::File->new(">$file"); if($pf) { print $pf "$contents\n"; @@ -7301,28 +7028,10 @@ sub validate_user { $contentpwd = $domdefaults{'auth_arg_def'}; } } - } + } if ($howpwd ne 'nouser') { if($howpwd eq "internal") { # Encrypted is in local password file. - if (length($contentpwd) == 13) { - $validated = (crypt($password,$contentpwd) eq $contentpwd); - if ($validated) { - my %domdefaults = &Apache::lonnet::get_domain_defaults($domain); - if ($domdefaults{'intauth_switch'}) { - my $ncpass = &hash_passwd($domain,$password); - my $saveold; - if ($domdefaults{'intauth_switch'} == 2) { - $saveold = 1; - } - if (&rewrite_password_file($domain,$user,"$howpwd:$ncpass",$saveold)) { - &update_passwd_history($user,$domain,$howpwd,'conversion'); - &logthis("Validated password hashed with bcrypt for $user:$domain"); - } - } - } - } else { - $validated = &check_internal_passwd($password,$contentpwd,$domain,$user); - } + $validated = (crypt($password, $contentpwd) eq $contentpwd); } elsif ($howpwd eq "unix") { # User is a normal unix user. $contentpwd = (getpwnam($user))[1]; @@ -7390,50 +7099,6 @@ sub validate_user { return $validated; } -sub check_internal_passwd { - my ($plainpass,$stored,$domain,$user) = @_; - my (undef,$method,@rest) = split(/!/,$stored); - if ($method eq 'bcrypt') { - my $result = &hash_passwd($domain,$plainpass,@rest); - if ($result ne $stored) { - return 0; - } - my %domdefaults = &Apache::lonnet::get_domain_defaults($domain); - if ($domdefaults{'intauth_check'}) { - # Upgrade to a larger number of rounds if necessary - my $defaultcost = $domdefaults{'intauth_cost'}; - if (($defaultcost eq '') || ($defaultcost =~ /D/)) { - $defaultcost = 10; - } - if (int($rest[0])<int($defaultcost)) { - if ($domdefaults{'intauth_check'} == 1) { - my $ncpass = &hash_passwd($domain,$plainpass); - if (&rewrite_password_file($domain,$user,"internal:$ncpass")) { - &update_passwd_history($user,$domain,'internal','update cost'); - &logthis("Validated password hashed with bcrypt for $user:$domain"); - } - return 1; - } elsif ($domdefaults{'intauth_check'} == 2) { - return 0; - } - } - } else { - return 1; - } - } - return 0; -} - -sub get_last_authchg { - my ($domain,$user) = @_; - my $lastmod; - my $logname = &propath($domain,$user).'/passwd.log'; - if (-e "$logname") { - $lastmod = (stat("$logname"))[9]; - } - return $lastmod; -} - sub krb4_authen { my ($password,$null,$user,$contentpwd) = @_; my $validated = 0; @@ -7749,26 +7414,26 @@ sub change_unix_password { sub make_passwd_file { - my ($uname,$udom,$umode,$npass,$passfilename,$action)=@_; + my ($uname,$udom,$umode,$npass,$passfilename)=@_; my $result="ok"; if ($umode eq 'krb4' or $umode eq 'krb5') { { my $pf = IO::File->new(">$passfilename"); if ($pf) { print $pf "$umode:$npass\n"; - &update_passwd_history($uname,$udom,$umode,$action); } else { $result = "pass_file_failed_error"; } } } elsif ($umode eq 'internal') { - my $ncpass = &hash_passwd($udom,$npass); + my $salt=time; + $salt=substr($salt,6,2); + my $ncpass=crypt($npass,$salt); { &Debug("Creating internal auth"); my $pf = IO::File->new(">$passfilename"); if($pf) { print $pf "internal:$ncpass\n"; - &update_passwd_history($uname,$udom,$umode,$action); } else { $result = "pass_file_failed_error"; } @@ -7778,7 +7443,6 @@ sub make_passwd_file { my $pf = IO::File->new(">$passfilename"); if($pf) { print $pf "localauth:$npass\n"; - &update_passwd_history($uname,$udom,$umode,$action); } else { $result = "pass_file_failed_error"; } @@ -7849,18 +7513,8 @@ sub get_usersession_config { return; } -sub get_usersearch_config { - my ($dom,$name) = @_; - my ($usersearchconf,$cached)=&Apache::lonnet::is_cached_new($name,$dom); - if (defined($cached)) { - return $usersearchconf; - } else { - my %domconfig = &Apache::lonnet::get_dom('configuration',['directorysrch'],$dom); - &Apache::lonnet::do_cache_new($name,$dom,$domconfig{'directorysrch'},3600); - return $domconfig{'directorysrch'}; - } - return; -} + + sub distro_and_arch { return $dist.':'.$arch; @@ -8190,6 +7844,8 @@ Authen::Krb5 =head1 COREQUISITES +none + =head1 OSNAMES linux @@ -8277,9 +7933,9 @@ or the CA's certificate in the call to l <error> is the textual reason this failed. Usual reasons: =over 2 - + =item Apache config file for loncapa incorrect: - + one of the variables lonCertificateDirectory, lonnetCertificateAuthority, or lonnetCertificate undefined or incorrect @@ -8398,7 +8054,7 @@ Could not rewrite the internal password file for a user =item Result of password change for <user> : <result> - + A unix password change for <user> was attempted and the pipe returned <result> @@ -8427,7 +8083,7 @@ lond has been asked to exit by its clien client systemand <input> is the full exit command sent to the server. =item Red CRITICAL: ABNORMAL EXIT. child <pid> for server <hostname> died through a crass with this error->[<message>]. - + A lond child terminated. NOte that this termination can also occur when the child receives the QUIT or DIE signals. <pid> is the process id of the child, <hostname> the host lond is working for, and <message> the reason the child died @@ -8511,7 +8167,7 @@ file when sent it's USR1 signal. That p assumed to be hung in some un-fixable way. =item Finished checking children - + Master processs's USR1 processing is cojmplete. =item (Red) CRITICAL: ------- Starting ------ @@ -8525,7 +8181,7 @@ Started a new child process for <client> connected to the child. This was as a result of a TCP/IP connection from a client. =item Unable to determine who caller was, getpeername returned nothing - + In child process initialization. either getpeername returned undef or a zero sized object was returned. Processing continues, but in my opinion, this should be cause for the child to exit. @@ -8536,7 +8192,7 @@ In child process initialization. The pe The client address is stored as "Unavailable" and processing continues. =item (Yellow) INFO: Connection <ip> <name> connection type = <type> - + In child initialization. A good connectionw as received from <ip>. =over 2 @@ -8586,7 +8242,7 @@ The client (<client> is the peer's name negotiated an SSL connection with this child process. =item (Green) Successful insecure authentication with <client> - + The client has successfully negotiated an insecure connection withthe child process.