--- loncom/lonnet/perl/lonnet.pm	2012/12/21 17:01:04	1.1172.2.14
+++ loncom/lonnet/perl/lonnet.pm	2012/10/29 17:39:02	1.1192
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # TCP networking package
 #
-# $Id: lonnet.pm,v 1.1172.2.14 2012/12/21 17:01:04 raeburn Exp $
+# $Id: lonnet.pm,v 1.1192 2012/10/29 17:39:02 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -75,6 +75,9 @@ use LWP::UserAgent();
 use HTTP::Date;
 use Image::Magick;
 
+
+use Encode;
+
 use vars qw(%perlvar %spareid %pr %prp $memcache %packagetab $tmpdir
             $_64bit %env %protocol %loncaparevs %serverhomeIDs %needsrelease
             %managerstab);
@@ -97,6 +100,7 @@ use File::MMagic;
 use LONCAPA qw(:DEFAULT :match);
 use LONCAPA::Configuration;
 use LONCAPA::lonmetadata;
+use LONCAPA::Lond;
 
 use File::Copy;
 
@@ -108,6 +112,7 @@ require Exporter;
 our @ISA = qw (Exporter);
 our @EXPORT = qw(%env);
 
+
 # ------------------------------------ Logging (parameters, docs, slots, roles)
 {
     my $logid;
@@ -122,19 +127,19 @@ our @EXPORT = qw(%env);
 	$logid ++;
         my $now = time();
 	my $id=$now.'00000'.$$.'00000'.$logid;
-        my $logentry = {
-                         $id => {
-                                  'exe_uname' => $env{'user.name'},
-                                  'exe_udom'  => $env{'user.domain'},
-                                  'exe_time'  => $now,
-                                  'exe_ip'    => $ENV{'REMOTE_ADDR'},
-                                  'delflag'   => $delflag,
-                                  'logentry'  => $storehash,
-                                  'uname'     => $uname,
-                                  'udom'      => $udom,
-                                }
+        my $logentry = { 
+                          $id => {
+                                   'exe_uname' => $env{'user.name'},
+                                   'exe_udom'  => $env{'user.domain'},
+                                   'exe_time'  => $now,
+                                   'exe_ip'    => $ENV{'REMOTE_ADDR'},
+                                   'delflag'   => $delflag,
+                                   'logentry'  => $storehash,
+                                   'uname'     => $uname,
+                                   'udom'      => $udom,
+                                  }
                        };
-        return &put('nohist_'.$hash_name,$logentry,$cdom,$cnum);
+	return &put('nohist_'.$hash_name,$logentry,$cdom,$cnum);
     }
 }
 
@@ -1261,7 +1266,7 @@ sub check_loadbalancing {
         }
     }
     if (ref($result) eq 'HASH') {
-        ($is_balancer,$currtargets,$currrules) =
+        ($is_balancer,$currtargets,$currrules) = 
             &check_balancer_result($result,@hosts);
         if ($is_balancer) {
             if (ref($currrules) eq 'HASH') {
@@ -1320,7 +1325,7 @@ sub check_loadbalancing {
             }
         }
         if (ref($result) eq 'HASH') {
-            ($is_balancer,$currtargets,$currrules) =
+            ($is_balancer,$currtargets,$currrules) = 
                 &check_balancer_result($result,@hosts);
             if ($is_balancer) {
                 if (ref($currrules) eq 'HASH') {
@@ -1376,8 +1381,8 @@ sub check_loadbalancing {
             $is_balancer = 0;
             if ($uname ne '' && $udom ne '') {
                 if (($env{'user.name'} eq $uname) && ($env{'user.domain'} eq $udom)) {
-
-                    &appenv({'user.loadbalexempt'     => $lonhost,
+                    
+                    &appenv({'user.loadbalexempt'     => $lonhost,  
                              'user.loadbalcheck.time' => time});
                 }
             }
@@ -2605,10 +2610,13 @@ sub ssi {
 
     $request->header(Cookie => $ENV{'HTTP_COOKIE'});
     my $response= $ua->request($request);
+    my $content = $response->content;
+
+
     if (wantarray) {
-	return ($response->content, $response);
+	return ($content, $response);
     } else {
-	return $response->content;
+	return $content;
     }
 }
 
@@ -2637,241 +2645,6 @@ sub allowuploaded {
     &Apache::lonnet::appenv(\%httpref);
 }
 
-#
-# Determine if the current user should be able to edit a particular resource,
-# when viewing in course context.
-# (a) When viewing resource used to determine if "Edit" item is included in
-#     Functions.
-# (b) When displaying folder contents in course editor, used to determine if
-#     "Edit" link will be displayed alongside resource.
-#
-#  input: six args -- filename (decluttered), course number, course domain,
-#                   url, symb (if registered) and group (if this is a group
-#                   item -- e.g., bulletin board, group page etc.).
-#  output: array of five scalars --
-#          $cfile -- url for file editing if editable on current server
-#          $home -- homeserver of resource (i.e., for author if published,
-#                                           or course if uploaded.).
-#          $switchserver --  1 if server switch will be needed.
-#          $forceedit -- 1 if icon/link should be to go to edit mode
-#          $forceview -- 1 if icon/link should be to go to view mode
-#
-
-sub can_edit_resource {
-    my ($file,$cnum,$cdom,$resurl,$symb,$group) = @_;
-    my ($cfile,$home,$switchserver,$forceedit,$forceview,$uploaded,$incourse);
-#
-# For aboutme pages user can only edit his/her own.
-#
-    if ($resurl =~ m{^/?adm/($match_domain)/($match_username)/aboutme$}) {
-        my ($sdom,$sname) = ($1,$2);
-        if (($sdom eq $env{'user.domain'}) && ($sname eq $env{'user.name'})) {
-            $home = $env{'user.home'};
-            $cfile = $resurl;
-            if ($env{'form.forceedit'}) {
-                $forceview = 1;
-            } else {
-                $forceedit = 1;
-            }
-            return ($cfile,$home,$switchserver,$forceedit,$forceview);
-        } else {
-            return;
-        }
-    }
-
-    if ($env{'request.course.id'}) {
-        my $crsedit = &Apache::lonnet::allowed('mdc',$env{'request.course.id'});
-        if ($group ne '') {
-# if this is a group homepage or group bulletin board, check group privs
-            my $allowed = 0;
-            if ($resurl =~ m{^/?adm/$cdom/$cnum/$group/smppg$}) {
-                if ((&allowed('mdg',$env{'request.course.id'}.
-                              ($env{'request.course.sec'}?'/'.$env{'request.course.sec'}:''))) ||
-                        (&allowed('mgh',$env{'request.course.id'}.'/'.$group)) || $crsedit) {
-                    $allowed = 1;
-                }
-            } elsif ($resurl =~ m{^/?adm/$cdom/$cnum/\d+/bulletinboard$}) {
-                if ((&allowed('mdg',$env{'request.course.id'}.($env{'request.course.sec'}?'/'.$env{'request.course.sec'}:''))) ||
-                        (&allowed('cgb',$env{'request.course.id'}.'/'.$group)) || $crsedit) {
-                    $allowed = 1;
-                }
-            }
-            if ($allowed) {
-                $home=&homeserver($cnum,$cdom);
-                if ($env{'form.forceedit'}) {
-                    $forceview = 1;
-                } else {
-                    $forceedit = 1;
-                }
-                $cfile = $resurl;
-            } else {
-                return;
-            }
-        } else {
-#
-# No edit allowed where CC has switched to student role.
-#
-            unless ($crsedit) {
-                return;
-            }
-        }
-    }
-
-    if ($file ne '') {
-        if (($cnum =~ /$match_courseid/) && ($cdom =~ /$match_domain/)) {
-            if (&is_course_upload($file,$cnum,$cdom)) {
-                $uploaded = 1;
-                $incourse = 1;
-                if ($file =~/\.(htm|html|css|js|txt)$/) {
-                    $cfile = &hreflocation('',$file);
-                    if ($env{'form.forceedit'}) {
-                        $forceview = 1;
-                    } else {
-                        $forceedit = 1;
-                    }
-                }
-            } elsif ($resurl =~ m{^/public/$cdom/$cnum/syllabus}) {
-                $incourse = 1;
-                if ($env{'form.forceedit'}) {
-                    $forceview = 1;
-                } else {
-                    $forceedit = 1;
-                }
-                $cfile = $resurl;
-            } elsif (($resurl ne '') && (&is_on_map($resurl))) {
-                if ($resurl =~ m{^/adm/$match_domain/$match_username/\d+/smppg|bulletinboard$}) {
-                    $incourse = 1;
-                    if ($env{'form.forceedit'}) {
-                        $forceview = 1;
-                    } else {
-                        $forceedit = 1;
-                    }
-                    $cfile = $resurl;
-                } elsif ($resurl eq '/res/lib/templates/simpleproblem.problem') {
-                    $incourse = 1;
-                    $cfile = $resurl.'/smpedit';
-                } elsif ($resurl =~ m{^/adm/wrapper/ext/}) {
-                    $incourse = 1;
-                    if ($env{'form.forceedit'}) {
-                        $forceview = 1;
-                    } else {
-                        $forceedit = 1;
-                    }
-                    $cfile = $resurl;
-                }
-            } elsif ($resurl eq '/res/lib/templates/simpleproblem.problem/smpedit') {
-                my $template = '/res/lib/templates/simpleproblem.problem';
-                if (&is_on_map($template)) {
-                    $incourse = 1;
-                    $forceview = 1;
-                    $cfile = $template;
-                }
-            } elsif (($resurl =~ m{^/adm/wrapper/ext/}) && ($env{'form.folderpath'} =~ /^supplemental/)) {
-                    $incourse = 1;
-                    if ($env{'form.forceedit'}) {
-                        $forceview = 1;
-                    } else {
-                        $forceedit = 1;
-                    }
-                    $cfile = $resurl;
-            } elsif (($resurl eq '/adm/extresedit') && ($symb || $env{'form.folderpath'})) {
-                $incourse = 1;
-                $forceview = 1;
-                if ($symb) {
-                    my ($map,$id,$res)=&decode_symb($symb);
-                    $env{'request.symb'} = $symb;
-                    $cfile = &clutter($res);
-                } else {
-                    $cfile = $env{'form.suppurl'};
-                    $cfile =~ s{^http://}{};
-                    $cfile = '/adm/wrapper/ext/'.$cfile;
-                }
-            }
-        }
-        if ($uploaded || $incourse) {
-            $home=&homeserver($cnum,$cdom);
-        } elsif ($file !~ m{/$}) {
-            $file=~s{^(priv/$match_domain/$match_username)}{/$1};
-            $file=~s{^($match_domain/$match_username)}{/priv/$1};
-            # Check that the user has permission to edit this resource
-            my $setpriv = 1;
-            my ($cfuname,$cfudom)=&constructaccess($file,$setpriv);
-            if (defined($cfudom)) {
-                $home=&homeserver($cfuname,$cfudom);
-                $cfile=$file;
-            }
-        }
-        if (($cfile ne '') && (!$incourse || $uploaded) &&
-            (($home ne '') && ($home ne 'no_host'))) {
-            my @ids=&current_machine_ids();
-            unless (grep(/^\Q$home\E$/,@ids)) {
-                $switchserver=1;
-            }
-        }
-    }
-    return ($cfile,$home,$switchserver,$forceedit,$forceview);
-}
-
-sub is_course_upload {
-    my ($file,$cnum,$cdom) = @_;
-    my $uploadpath = &LONCAPA::propath($cdom,$cnum);
-    $uploadpath =~ s{^\/}{};
-    if (($file =~ m{^\Q$uploadpath\E/userfiles/(docs|supplemental)/}) ||
-        ($file =~ m{^userfiles/\Q$cdom\E/\Q$cnum\E/(docs|supplemental)/})) {
-        return 1;
-    }
-    return;
-}
-
-sub in_course {
-    my ($udom,$uname,$cdom,$cnum,$type,$hideprivileged) = @_;
-    if ($hideprivileged) {
-        my $skipuser;
-        if (&privileged($uname,$udom)) {
-            $skipuser = 1;
-            my %coursehash = &coursedescription($cdom.'_'.$cnum);
-            if ($coursehash{'nothideprivileged'}) {
-                foreach my $item (split(/\s*\,\s*/,$coursehash{'nothideprivileged'})) {
-                    my $user;
-                    if ($item =~ /:/) {
-                        $user = $item;
-                    } else {
-                        $user = join(':',split(/[\@]/,$item));
-                    }
-                    if ($user eq $uname.':'.$udom) {
-                        undef($skipuser);
-                        last;
-                    }
-                }
-            }
-            if ($skipuser) {
-                return 0;
-            }
-        }
-    }
-    $type ||= 'any';
-    if (!defined($cdom) || !defined($cnum)) {
-        my $cid  = $env{'request.course.id'};
-        $cdom = $env{'course.'.$cid.'.domain'};
-        $cnum = $env{'course.'.$cid.'.num'};
-    }
-    my $typesref;
-    if (($type eq 'any') || ($type eq 'all')) {
-        $typesref = ['active','previous','future'];
-    } elsif ($type eq 'previous' || $type eq 'future') {
-        $typesref = [$type];
-    }
-    my %roles = &get_my_roles($uname,$udom,'userroles',
-                              $typesref,undef,[$cdom]);
-    my ($tmp) = keys(%roles);
-    return 0 if ($tmp =~ /^(con_lost|error|no_such_host)/i);
-    my @course_roles = grep(/^\Q$cnum\E:\Q$cdom\E:/, keys(%roles));
-    if (@course_roles > 0) {
-        return 1;
-    }
-    return 0;
-}
-
 # --------- File operations in /home/httpd/html/userfiles/$domain/1/2/3/$course
 # input: action, courseID, current domain, intended
 #        path to file, source of file, instruction to parse file for objects,
@@ -4108,18 +3881,32 @@ sub courseiddump {
 
 	    if (($domfilter eq '') ||
 		(&host_domain($tryserver) eq $domfilter)) {
-                my $rep = 
-                  &reply('courseiddump:'.&host_domain($tryserver).':'.
-                         $sincefilter.':'.&escape($descfilter).':'.
-                         &escape($instcodefilter).':'.&escape($ownerfilter).
-                         ':'.&escape($coursefilter).':'.&escape($typefilter).
-                         ':'.&escape($regexp_ok).':'.$as_hash.':'.
-                         &escape($selfenrollonly).':'.&escape($catfilter).':'.
-                         $showhidden.':'.$caller.':'.&escape($cloner).':'.
-                         &escape($cc_clone).':'.$cloneonly.':'.
-                         &escape($createdbefore).':'.&escape($createdafter).':'.
-                         &escape($creationcontext).':'.$domcloner,
-                         $tryserver);
+                my $rep;
+                if (grep { $_ eq $tryserver } current_machine_ids()) {
+                    $rep = LONCAPA::Lond::dump_course_id_handler(
+                        join(":", (&host_domain($tryserver), $sincefilter, 
+                                &escape($descfilter), &escape($instcodefilter), 
+                                &escape($ownerfilter), &escape($coursefilter),
+                                &escape($typefilter), &escape($regexp_ok), 
+                                $as_hash, &escape($selfenrollonly), 
+                                &escape($catfilter), $showhidden, $caller, 
+                                &escape($cloner), &escape($cc_clone), $cloneonly, 
+                                &escape($createdbefore), &escape($createdafter), 
+                                &escape($creationcontext), $domcloner)));
+                } else {
+                    $rep = &reply('courseiddump:'.&host_domain($tryserver).':'.
+                             $sincefilter.':'.&escape($descfilter).':'.
+                             &escape($instcodefilter).':'.&escape($ownerfilter).
+                             ':'.&escape($coursefilter).':'.&escape($typefilter).
+                             ':'.&escape($regexp_ok).':'.$as_hash.':'.
+                             &escape($selfenrollonly).':'.&escape($catfilter).':'.
+                             $showhidden.':'.$caller.':'.&escape($cloner).':'.
+                             &escape($cc_clone).':'.$cloneonly.':'.
+                             &escape($createdbefore).':'.&escape($createdafter).':'.
+                             &escape($creationcontext).':'.$domcloner,
+                             $tryserver);
+                }
+                     
                 my @pairs=split(/\&/,$rep);
                 foreach my $item (@pairs) {
                     my ($key,$value)=split(/\=/,$item,2);
@@ -5363,12 +5150,37 @@ sub del {
 
 # -------------------------------------------------------------- dump interface
 
+sub unserialize {
+    my ($rep, $escapedkeys) = @_;
+
+    return {} if $rep =~ /^error/;
+
+    my %returnhash=();
+	foreach my $item (split /\&/, $rep) {
+	    my ($key, $value) = split(/=/, $item, 2);
+	    $key = unescape($key) unless $escapedkeys;
+	    next if $key =~ /^error: 2 /;
+	    $returnhash{$key} = Apache::lonnet::thaw_unescape($value);
+	}
+    #return %returnhash;
+    return \%returnhash;
+}        
+
+# see Lond::dump_with_regexp
+# if $escapedkeys hash keys won't get unescaped.
 sub dump {
-    my ($namespace,$udomain,$uname,$regexp,$range)=@_;
+    my ($namespace,$udomain,$uname,$regexp,$range,$escapedkeys)=@_;
     if (!$udomain) { $udomain=$env{'user.domain'}; }
     if (!$uname) { $uname=$env{'user.name'}; }
     my $uhome=&homeserver($uname,$udomain);
 
+    my $reply;
+    if (grep { $_ eq $uhome } current_machine_ids()) {
+        # user is hosted on this machine
+        $reply = LONCAPA::Lond::dump_with_regexp(join(":", ($udomain,
+                    $uname, $namespace, $regexp, $range)), $loncaparevs{$uhome});
+        return %{unserialize($reply, $escapedkeys)};
+    }
     if ($regexp) {
 	$regexp=&escape($regexp);
     } else {
@@ -5380,7 +5192,8 @@ sub dump {
     if (!($rep =~ /^error/ )) {
 	foreach my $item (@pairs) {
 	    my ($key,$value)=split(/=/,$item,2);
-	    $key = &unescape($key);
+        $key = unescape($key) unless $escapedkeys;
+        #$key = &unescape($key);
 	    next if ($key =~ /^error: 2 /);
 	    $returnhash{$key}=&thaw_unescape($value);
 	}
@@ -5393,23 +5206,9 @@ sub dump {
 
 sub dumpstore {
    my ($namespace,$udomain,$uname,$regexp,$range)=@_;
-   if (!$udomain) { $udomain=$env{'user.domain'}; }
-   if (!$uname) { $uname=$env{'user.name'}; }
-   my $uhome=&homeserver($uname,$udomain);
-   if ($regexp) {
-       $regexp=&escape($regexp);
-   } else {
-       $regexp='.';
-   }
-   my $rep=&reply("dump:$udomain:$uname:$namespace:$regexp:$range",$uhome);
-   my @pairs=split(/\&/,$rep);
-   my %returnhash=();
-   foreach my $item (@pairs) {
-       my ($key,$value)=split(/=/,$item,2);
-       next if ($key =~ /^error: 2 /);
-       $returnhash{$key}=&thaw_unescape($value);
-   }
-   return %returnhash;
+   # same as dump but keys must be escaped. They may contain colon separated
+   # lists of values that may themself contain colons (e.g. symbs).
+   return &dump($namespace, $udomain, $uname, $regexp, $range, 1);
 }
 
 # -------------------------------------------------------------- keys interface
@@ -5435,7 +5234,15 @@ sub currentdump {
    $sdom     = $env{'user.domain'}       if (! defined($sdom));
    $sname    = $env{'user.name'}         if (! defined($sname));
    my $uhome = &homeserver($sname,$sdom);
-   my $rep=reply('currentdump:'.$sdom.':'.$sname.':'.$courseid,$uhome);
+   my $rep;
+
+   if (grep { $_ eq $uhome } current_machine_ids()) {
+       $rep = LONCAPA::Lond::dump_profile_database(join(":", ($sdom, $sname, 
+                   $courseid)));
+   } else {
+       $rep = reply('currentdump:'.$sdom.':'.$sname.':'.$courseid,$uhome);
+   }
+
    return if ($rep =~ /^(error:|no_such_host)/);
    #
    my %returnhash=();
@@ -5678,88 +5485,6 @@ sub tmpdel {
     return &reply("tmpdel:$token",$server);
 }
 
-# ------------------------------------------------------------ get_timebased_id
-
-sub get_timebased_id {
-    my ($prefix,$keyid,$namespace,$cdom,$cnum,$idtype,$who,$locktries,
-        $maxtries) = @_;
-    my ($newid,$error,$dellock);
-    unless (($prefix =~ /^\w+$/) && ($keyid =~ /^\w+$/) && ($namespace ne '')) {
-        return ('','ok','invalid call to get suffix');
-    }
-
-# set defaults for any optional args for which values were not supplied
-    if ($who eq '') {
-        $who = $env{'user.name'}.':'.$env{'user.domain'};
-    }
-    if (!$locktries) {
-        $locktries = 3;
-    }
-    if (!$maxtries) {
-        $maxtries = 10;
-    }
-
-    if (($cdom eq '') || ($cnum eq '')) {
-        if ($env{'request.course.id'}) {
-            $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
-            $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
-        }
-        if (($cdom eq '') || ($cnum eq '')) {
-            return ('','ok','call to get suffix not in course context');
-        }
-    }
-
-# construct locking item
-    my $lockhash = {
-                      $prefix."\0".'locked_'.$keyid => $who,
-                   };
-    my $tries = 0;
-
-# attempt to get lock on nohist_$namespace file
-    my $gotlock = &Apache::lonnet::newput('nohist_'.$namespace,$lockhash,$cdom,$cnum);
-    while (($gotlock ne 'ok') && $tries <$locktries) {
-        $tries ++;
-        sleep 1;
-        $gotlock = &Apache::lonnet::newput('nohist_'.$namespace,$lockhash,$cdom,$cnum);
-    }
-
-# attempt to get unique identifier, based on current timestamp
-    if ($gotlock eq 'ok') {
-        my %inuse = &Apache::lonnet::dump('nohist_'.$namespace,$cdom,$cnum,$prefix);
-        my $id = time;
-        $newid = $id;
-        my $idtries = 0;
-        while (exists($inuse{$prefix."\0".$newid}) && $idtries < $maxtries) {
-            if ($idtype eq 'concat') {
-                $newid = $id.$idtries;
-            } else {
-                $newid ++;
-            }
-            $idtries ++;
-        }
-        if (!exists($inuse{$prefix."\0".$newid})) {
-            my %new_item =  (
-                              $prefix."\0".$newid => $who,
-                            );
-            my $putresult = &Apache::lonnet::put('nohist_'.$namespace,\%new_item,
-                                                 $cdom,$cnum);
-            if ($putresult ne 'ok') {
-                undef($newid);
-                $error = 'error saving new item: '.$putresult;
-            }
-        } else {
-             $error = ('error: no unique suffix available for the new item ');
-        }
-#  remove lock
-        my @del_lock = ($prefix."\0".'locked_'.$keyid);
-        $dellock = &Apache::lonnet::del('nohist_'.$namespace,\@del_lock,$cdom,$cnum);
-    } else {
-        $error = "error: could not obtain lockfile\n";
-        $dellock = 'ok';
-    }
-    return ($newid,$dellock,$error);
-}
-
 # -------------------------------------------------- portfolio access checking
 
 sub portfolio_access {
@@ -6048,7 +5773,7 @@ sub usertools_access {
 
     my ($toolstatus,$inststatus,$envkey);
     if ($context eq 'requestauthor') {
-        $envkey = $context;
+        $envkey = $context; 
     } else {
         $envkey = $context.'.'.$tool;
     }
@@ -7918,7 +7643,7 @@ sub assignrole {
                         }
                     }
                 } elsif ($context eq 'requestauthor') {
-                    if (($udom eq $env{'user.domain'}) && ($uname eq $env{'user.name'}) &&
+                    if (($udom eq $env{'user.domain'}) && ($uname eq $env{'user.name'}) && 
                         ($url eq '/'.$udom.'/') && ($role eq 'au')) {
                         if ($env{'environment.requestauthor'} eq 'automatic') {
                             $refused = '';
@@ -7926,13 +7651,13 @@ sub assignrole {
                             my %domdefaults = &get_domain_defaults($udom);
                             if (ref($domdefaults{'requestauthor'}) eq 'HASH') {
                                 my $checkbystatus;
-                                if ($env{'user.adv'}) {
+                                if ($env{'user.adv'}) { 
                                     my $disposition = $domdefaults{'requestauthor'}{'_LC_adv'};
                                     if ($disposition eq 'automatic') {
                                         $refused = '';
                                     } elsif ($disposition eq '') {
                                         $checkbystatus = 1;
-                                    }
+                                    } 
                                 } else {
                                     $checkbystatus = 1;
                                 }
@@ -8001,16 +7726,16 @@ sub assignrole {
 # log new user role if status is ok
     if ($answer eq 'ok') {
 	&userrolelog($role,$uname,$udom,$url,$start,$end);
+# for course roles, perform group memberships changes triggered by role change.
+        unless ($role =~ /^gr/) {
+            &Apache::longroup::group_changes($udom,$uname,$url,$role,$origend,
+                                             $origstart,$selfenroll,$context);
+        }
         if (($role eq 'cc') || ($role eq 'in') ||
             ($role eq 'ep') || ($role eq 'ad') ||
             ($role eq 'ta') || ($role eq 'st') ||
             ($role=~/^cr/) || ($role eq 'gr') ||
             ($role eq 'co')) {
-# for course roles, perform group memberships changes triggered by role change.
-            unless ($role =~ /^gr/) {
-                &Apache::longroup::group_changes($udom,$uname,$url,$role,$origend,
-                                                 $origstart,$selfenroll,$context);
-            }
             &courserolelog($role,$uname,$udom,$url,$origstart,$origend,$delflag,
                            $selfenroll,$context);
         } elsif (($role eq 'li') || ($role eq 'dg') || ($role eq 'sc') ||
@@ -8019,7 +7744,7 @@ sub assignrole {
                            $context);
         } elsif (($role eq 'ca') || ($role eq 'aa')) {
             &coauthorrolelog($role,$uname,$udom,$url,$origstart,$origend,$delflag,
-                             $context);
+                             $context); 
         }
         if ($role eq 'cc') {
             &autoupdate_coowners($url,$end,$start,$uname,$udom);
@@ -10249,78 +9974,6 @@ sub gettitle {
     return $title;
 }
 
-sub getdocspath {
-    my ($symb) = @_;
-    my $path;
-    if ($symb) {
-        my ($mapurl,$id,$resurl) = &decode_symb($symb);
-        if ($resurl=~/\.(sequence|page)$/) {
-            $mapurl=$resurl;
-        } elsif ($resurl eq 'adm/navmaps') {
-            $mapurl=$env{'course.'.$env{'request.course.id'}.'.url'};
-        }
-        my $mapresobj;
-        my $navmap = Apache::lonnavmaps::navmap->new();
-        if (ref($navmap)) {
-            $mapresobj = $navmap->getResourceByUrl($mapurl);
-        }
-        $mapurl=~s{^.*/([^/]+)\.(\w+)$}{$1};
-        my $type=$2;
-        if (ref($mapresobj)) {
-            my $pcslist = $mapresobj->map_hierarchy();
-            if ($pcslist ne '') {
-                foreach my $pc (split(/,/,$pcslist)) {
-                    next if ($pc <= 1);
-                    my $res = $navmap->getByMapPc($pc);
-                    if (ref($res)) {
-                        my $thisurl = $res->src();
-                        $thisurl=~s{^.*/([^/]+)\.\w+$}{$1};
-                        my $thistitle = $res->title();
-                        $path .= '&'.
-                                 &Apache::lonhtmlcommon::entity_encode($thisurl).'&'.
-                                 &Apache::lonhtmlcommon::entity_encode($thistitle).
-                                 ':'.$res->randompick().
-                                 ':'.$res->randomout().
-                                 ':'.$res->encrypted().
-                                 ':'.$res->randomorder().
-                                 ':'.$res->is_page();
-                    }
-                }
-            }
-            $path =~ s/^\&//;
-            my $maptitle = $mapresobj->title();
-            if ($mapurl eq 'default') {
-                $maptitle = 'Main Course Documents';
-            }
-            $path .= ($path ne '')? '&' : ''.
-                    &Apache::lonhtmlcommon::entity_encode($mapurl).'&'.
-                    &Apache::lonhtmlcommon::entity_encode($maptitle).
-                    ':'.$mapresobj->randompick().
-                    ':'.$mapresobj->randomout().
-                    ':'.$mapresobj->encrypted().
-                    ':'.$mapresobj->randomorder().
-                    ':'.$mapresobj->is_page();
-        } else {
-            my $maptitle = &gettitle($mapurl);
-            my $ispage;
-            if ($mapurl =~ /\.page$/) {
-                $ispage = 1;
-            }
-            if ($mapurl eq 'default') {
-                $maptitle = 'Main Course Documents';
-            }
-            $path = &Apache::lonhtmlcommon::entity_encode($mapurl).'&'.
-                    &Apache::lonhtmlcommon::entity_encode($maptitle).':::::'.$ispage;
-        }
-        unless ($mapurl eq 'default') {
-            $path = 'default&'.
-                    &Apache::lonhtmlcommon::entity_encode('Main Course Documents').
-                    ':::::&'.$path;
-        }
-    }
-    return $path;
-}
-
 sub get_slot {
     my ($which,$cnum,$cdom)=@_;
     if (!$cnum || !$cdom) {
@@ -10468,46 +10121,34 @@ sub symbverify {
 
     if (tie(%bighash,'GDBM_File',$env{'request.course.fn'}.'.db',
                             &GDBM_READER(),0640)) {
-        my $noclutter;
         if (($thisurl =~ m{^/adm/wrapper/ext/}) || ($thisurl =~ m{^ext/})) {
             $thisurl =~ s/\?.+$//;
-            if ($map =~ m{^uploaded/.+\.page$}) {
-                $thisurl =~ s{^(/adm/wrapper|)/ext/}{http://};
-                $thisurl =~ s{^\Qhttp://https://\E}{https://};
-                $noclutter = 1;
-            }
-        }
-        my $ids;
-        if ($noclutter) {
-            $ids=$bighash{'ids_'.$thisurl};
-        } else {
-            $ids=$bighash{'ids_'.&clutter($thisurl)};
         }
+        my $ids=$bighash{'ids_'.&clutter($thisurl)};
         unless ($ids) {
-            my $idkey = 'ids_'.($thisurl =~ m{^/}? '' : '/').$thisurl;
+            my $idkey = 'ids_'.($thisurl =~ m{^/}? '' : '/').$thisurl;  
             $ids=$bighash{$idkey};
         }
         if ($ids) {
 # ------------------------------------------------------------------- Has ID(s)
-            if ($thisfn =~ m{^/adm/wrapper/ext/}) {
-                $symb =~ s/\?.+$//;
-            }
 	    foreach my $id (split(/\,/,$ids)) {
 	       my ($mapid,$resid)=split(/\./,$id);
+               if ($thisfn =~ m{^/adm/wrapper/ext/}) {
+                   $symb =~ s/\?.+$//;
+               }
                if (
   &symbclean(&declutter($bighash{'map_id_'.$mapid}).'___'.$resid.'___'.$thisfn)
    eq $symb) {
                    if (ref($encstate)) {
                        $$encstate = $bighash{'encrypted_'.$id};
                    }
-                   if (($env{'request.role.adv'}) ||
-                       ($bighash{'encrypted_'.$id} eq $env{'request.enc'}) ||
+		   if (($env{'request.role.adv'}) ||
+		       ($bighash{'encrypted_'.$id} eq $env{'request.enc'}) ||
                        ($thisurl eq '/adm/navmaps')) {
-                       $okay=1;
-                       last;
-                   }
-               }
-           }
+		       $okay=1;
+		   }
+	       }
+	   }
         }
 	untie(%bighash);
     }
@@ -10580,18 +10221,18 @@ sub deversion {
 
 sub symbread {
     my ($thisfn,$donotrecurse)=@_;
-    my $cache_str;
-    if ($thisfn ne '') {
-        $cache_str='request.symbread.cached.'.$thisfn;
-        if ($env{$cache_str} ne '') {
+    my $cache_str='request.symbread.cached.'.$thisfn;
+    if (defined($env{$cache_str})) {
+        if (($thisfn) || ($env{$cache_str} ne '')) {
             return $env{$cache_str};
         }
-   } else {
+    }
 # no filename provided? try from environment
+    unless ($thisfn) {
         if ($env{'request.symb'}) {
-            return $env{$cache_str}=&symbclean($env{'request.symb'});
-        }
-        $thisfn=$env{'request.filename'};
+	    return $env{$cache_str}=&symbclean($env{'request.symb'});
+	}
+	$thisfn=$env{'request.filename'};
     }
     if ($thisfn=~m|^/enc/|) { $thisfn=&Apache::lonenc::unencrypted($thisfn); }
 # is that filename actually a symb? Verify, clean, and return
@@ -10819,6 +10460,7 @@ sub rndseed {
 	$which =&get_rand_alg($courseid);
     }
     if (defined(&getCODE())) {
+
 	if ($which eq '64bit5') {
 	    return &rndseed_CODE_64bit5($symb,$courseid,$domain,$username);
 	} elsif ($which eq '64bit4') {
@@ -12412,17 +12054,6 @@ of role statuses (active, future or prev
 to restrict the list of roles reported. If no array ref is 
 provided for types, will default to return only active roles.
 
-=item *
-
-in_course($udom,$uname,$cdom,$cnum,$type,$hideprivileged) : determine if
-user: $uname:$udom has a role in the course: $cdom_$cnum.
-
-Additional optional arguments are: $type (if role checking is to be restricted
-to certain user status types -- previous (expired roles), active (currently
-available roles) or future (roles available in the future), and
-$hideprivileged -- if true will not report course roles for users who
-have active Domain Coordinator or Super User roles.
-
 =back
 
 =head2 User Modification
@@ -12625,6 +12256,7 @@ data base, returning a hash that is keye
 values that are the resource value.  I believe that the timestamps and
 versions are also returned.
 
+
 =back
 
 =head2 Course Modification
@@ -12725,14 +12357,14 @@ returns the data handle
 
 =item *
 
-symbverify($symb,$thisfn,$ecstate) : verifies that $symb actually exists
+symbverify($symb,$thisfn,$encstate) : verifies that $symb actually exists
 and is a possible symb for the URL in $thisfn, and if is an encrypted
 resource that the user accessed using /enc/ returns a 1 on success, 0
 on failure, user must be in a course, as it assumes the existence of
 the course initial hash, and uses $env('request.course.id'}.  The third
-arg is an optional reference to a scalar.  If this arg is passed in the
+arg is an optional reference to a scalar.  If this arg is passed in the 
 call to symbverify, it will be set to 1 if the symb has been set to be 
-encrypted; otherwise it will be null.
+encrypted; otherwise it will be null.  
 
 =item *
 
@@ -12785,34 +12417,6 @@ expirespread($uname,$udom,$stype,$usymb)
 devalidate($symb) : devalidate temporary spreadsheet calculations,
 forcing spreadsheet to reevaluate the resource scores next time.
 
-=item *
-
-can_edit_resource($file,$cnum,$cdom,$resurl,$symb,$group) : determine if current user can edit a particular resource,
-when viewing in course context.
-
- input: six args -- filename (decluttered), course number, course domain,
-                    url, symb (if registered) and group (if this is a
-                    group item -- e.g., bulletin board, group page etc.).
-
- output: array of five scalars --
-         $cfile -- url for file editing if editable on current server
-         $home -- homeserver of resource (i.e., for author if published,
-                                          or course if uploaded.).
-         $switchserver --  1 if server switch will be needed.
-         $forceedit -- 1 if icon/link should be to go to edit mode
-         $forceview -- 1 if icon/link should be to go to view mode
-
-=item *
-
-is_course_upload($file,$cnum,$cdom)
-
-Used in course context to determine if current file was uploaded to
-the course (i.e., would be found in /userfiles/docs on the course's
-homeserver.
-
-  input: 3 args -- filename (decluttered), course number and course domain.
-  output: boolean -- 1 if file was uploaded.
-
 =back
 
 =head2 Storing/Retreiving Data
@@ -13368,8 +12972,6 @@ Internal notes:
  
  Locks on files (resulting from submission of portfolio file to a homework problem stored in array of arrays.
 
-=item *
-
 modify_access_controls():
 
 Modifies access controls for a portfolio file
@@ -13387,51 +12989,7 @@ Returns:
 3. reference to hash of any new or updated access controls.
 4. reference to hash used to map incoming IDs to uniqueIDs assigned to control.
    key = integer (inbound ID)
-   value = uniqueID
-
-=item *
-
-get_timebased_id():
-
-Attempts to get a unique timestamp-based suffix for use with items added to a
-course via the Course Editor (e.g., folders, composite pages,
-group bulletin boards).
-
-Args: (first three required; six others optional)
-
-1. prefix (alphanumeric): of keys in hash, e.g., suppsequence, docspage,
-   docssequence, or name of group
-
-2. keyid (alphanumeric): name of temporary locking key in hash,
-   e.g., num, boardids
-
-3. namespace: name of gdbm file used to store suffixes already assigned;
-   file will be named nohist_namespace.db
-
-4. cdom: domain of course; default is current course domain from %env
-
-5. cnum: course number; default is current course number from %env
-
-6. idtype: set to concat if an additional digit is to be appended to the
-   unix timestamp to form the suffix, if the plain timestamp is already
-   in use.  Default is to not do this, but simply increment the unix
-   timestamp by 1 until a unique key is obtained.
-
-7. who: holder of locking key; defaults to user:domain for user.
-
-8. locktries: number of attempts to obtain a lock (sleep of 1s before
-   retrying); default is 3.
-
-9. maxtries: number of attempts to obtain a unique suffix; default is 20.
-
-Returns:
-
-1. suffix obtained (numeric)
-
-2. result of deleting locking key (ok if deleted, or lock never obtained)
-
-3. error: contains (localized) error message if an error occurred.
-
+   value = uniqueID  
 
 =back