--- loncom/lonnet/perl/lonnet.pm 2024/12/27 02:32:55 1.1532 +++ loncom/lonnet/perl/lonnet.pm 2025/01/05 21:53:43 1.1533 @@ -1,7 +1,7 @@ # The LearningOnline Network # TCP networking package # -# $Id: lonnet.pm,v 1.1532 2024/12/27 02:32:55 raeburn Exp $ +# $Id: lonnet.pm,v 1.1533 2025/01/05 21:53:43 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -6749,7 +6749,7 @@ sub store { # -------------------------------------------------------------- Critical Store sub cstore { - my ($storehash,$symb,$namespace,$domain,$stuname,$laststore,$ip,$nolog) = @_; + my ($storehash,$symb,$namespace,$domain,$stuname,$laststore) = @_; my $home=''; if ($stuname) { $home=&homeserver($stuname,$domain); } @@ -6774,11 +6774,7 @@ sub cstore { } if (!$home) { $home=$env{'user.home'}; } - if ($ip ne '') { - $$storehash{'ip'} = $ip; - } else { - $$storehash{'ip'} = &get_requestor_ip(); - } + $$storehash{'ip'} = &get_requestor_ip(); $$storehash{'host'}=$perlvar{'lonHostID'}; my $namevalue=''; @@ -6786,9 +6782,7 @@ sub cstore { $namevalue.=&escape($key).'='.&freeze_escape($$storehash{$key}).'&'; } $namevalue=~s/\&$//; - unless ($nolog) { - &courselog($symb.':'.$stuname.':'.$domain.':CSTORE:'.$namevalue); - } + &courselog($symb.':'.$stuname.':'.$domain.':CSTORE:'.$namevalue); return critical ("store:$domain:$stuname:$namespace:$symb:$namevalue:$laststore","$home"); } @@ -11690,7 +11684,7 @@ sub is_course { } sub store_userdata { - my ($storehash,$datakey,$namespace,$udom,$uname) = @_; + my ($storehash,$datakey,$namespace,$udom,$uname,$ip) = @_; my $result; if ($datakey ne '') { if (ref($storehash) eq 'HASH') { @@ -11702,7 +11696,11 @@ sub store_userdata { if (($uhome eq '') || ($uhome eq 'no_host')) { $result = 'error: no_host'; } else { - $storehash->{'ip'} = &get_requestor_ip(); + if ($ip ne '') { + $storehash->{'ip'} = $ip; + } else { + $storehash->{'ip'} = &get_requestor_ip(); + } $storehash->{'host'} = $perlvar{'lonHostID'}; my $namevalue='';