--- loncom/lonnet/perl/lonnet.pm	2000/10/07 10:09:53	1.39
+++ loncom/lonnet/perl/lonnet.pm	2000/10/12 02:11:16	1.45
@@ -36,11 +36,13 @@
 # coursedescription(id) : returns and caches course description for id
 # repcopy(filename)  : replicate file
 # dirlist(url)       : gets a directory listing
+# directcondval(index) : reading condition value of single condition from 
+#                        state string
 # condval(index)     : value of condition index based on state
 # varval(name)       : value of a variable
 # refreshstate()     : refresh the state information string
 # symblist(map,hash) : Updates symbolic storage links
-# symbread(filename) : returns the data handle
+# symbread([filename]) : returns the data handle (filename optional)
 # rndseed()          : returns a random seed  
 # getfile(filename)  : returns the contents of filename, or a -1 if it can't
 #                      be found, replicates and subscribes to the file
@@ -60,7 +62,7 @@
 # 08/22,08/28,08/31,09/01,09/02,09/04,09/05,09/25,09/28,09/30 Gerd Kortemeyer
 # 10/04 Gerd Kortemeyer
 # 10/04 Guy Albertelli
-# 10/06 Gerd Kortemeyer
+# 10/06,10/09,10/10,10/11 Gerd Kortemeyer
 
 package Apache::lonnet;
 
@@ -429,7 +431,7 @@ sub log {
 sub store {
     my %storehash=@_;
     my $symb;
-    unless ($symb=escape(&symbread($ENV{'request.filename'}))) { return ''; }
+    unless ($symb=escape(&symbread())) { return ''; }
     my $namespace;
     unless ($namespace=$ENV{'request.course.id'}) { return ''; }
     my $namevalue='';
@@ -446,7 +448,7 @@ sub store {
 
 sub restore {
     my $symb;
-    unless ($symb=escape(&symbread($ENV{'request.filename'}))) { return ''; }
+    unless ($symb=escape(&symbread())) { return ''; }
     my $namespace;
     unless ($namespace=$ENV{'request.course.id'}) { return ''; }
     my $answer=reply(
@@ -594,10 +596,11 @@ sub get {
                  $ENV{'user.home'});
    my @pairs=split(/\&/,$rep);
    my %returnhash=();
+   my $i=0;
    map {
-      my ($key,$value)=split(/=/,$_);
-      $returnhash{unescape($key)}=unescape($value);
-   } @pairs;
+      $returnhash{$_}=unescape($pairs[$i]);
+      $i++;
+   } @storearr;
    return %returnhash;
 }
 
@@ -655,10 +658,11 @@ sub eget {
                  $ENV{'user.home'});
    my @pairs=split(/\&/,$rep);
    my %returnhash=();
+   my $i=0;
    map {
-      my ($key,$value)=split(/=/,$_);
-      $returnhash{unescape($key)}=unescape($value);
-   } @pairs;
+      $returnhash{$_}=unescape($pairs[$i]);
+      $i++;
+   } @storearr;
    return %returnhash;
 }
 
@@ -757,7 +761,7 @@ sub allowed {
 # Restricted by state?
 
            if ($thisallowed=~/X/) {
-	      if (&condval($uricond)>1) {
+	      if (&condval($uricond)) {
 	         return '2';
               } else {
                  return '';
@@ -940,6 +944,15 @@ sub dirlist {
 
 # -------------------------------------------------------- Value of a Condition
 
+sub directcondval {
+    my $number=shift;
+    if ($ENV{'user.state.'.$ENV{'request.course.id'}}) {
+       return substr($ENV{'user.state.'.$ENV{'request.course.id'}},$number,1);
+    } else {
+       return 2;
+    }
+}
+
 sub condval {
     my $condidx=shift;
     my $result=0;
@@ -960,8 +973,7 @@ sub condval {
               } elsif (($_ eq '&') || ($_ eq '|')) {
                   $operand=$_;
               } else {
-                  my $new=
-                    substr($ENV{'user.state.'.$ENV{'request.course.id'}},$_,1);
+                  my $new=directcondval($_);
                   if ($operand eq '&') {
                      $result=$result>$new?$new:$result;
                   } else {
@@ -1017,11 +1029,15 @@ sub symblist {
 # ------------------------------------------------------ Return symb list entry
 
 sub symbread {
-    my $thisfn=declutter(shift);
+    my $thisfn=shift;
+    unless ($thisfn) {
+	$thisfn=$ENV{'request.filename'};
+    }
+    $thisfn=declutter($thisfn);
     my %hash;
     my %bighash;
     my $syval='';
-    if (($ENV{'request.course.fn'}) && ($ENV{'request.filename'})) {
+    if (($ENV{'request.course.fn'}) && ($thisfn)) {
         if (tie(%hash,'GDBM_File',$ENV{'request.course.fn'}.'_symb.db',
                       &GDBM_READER,0640)) {
 	    $syval=$hash{$thisfn};
@@ -1031,6 +1047,7 @@ sub symbread {
         if ($syval) {
            unless ($syval=~/\_\d+$/) {
 	       unless ($ENV{'form.request.prefix'}=~/\.(\d+)\_$/) {
+                  &appenv('request.ambiguous' => $thisfn);
                   return '';
                }    
                $syval.=$1;
@@ -1070,6 +1087,7 @@ sub symbread {
         }
         if ($syval) { return $syval.'___'.$thisfn; }
     }
+    &appenv('request.ambiguous' => $thisfn);
     return '';
 }
 
@@ -1089,7 +1107,7 @@ sub numval {
 
 sub rndseed {
     my $symb;
-    unless ($symb=&symbread($ENV{'request.filename'})) { return ''; }
+    unless ($symb=&symbread()) { return time; }
     my $symbchck=unpack("%32C*",$symb);
     my $symbseed=numval($symb)%$symbchck;
     my $namechck=unpack("%32C*",$ENV{'user.name'});