--- loncom/lti/ltiauth.pm 2018/05/14 20:10:15 1.12
+++ loncom/lti/ltiauth.pm 2019/06/13 17:45:26 1.18
@@ -1,7 +1,7 @@
# The LearningOnline Network
# Basic LTI Authentication Module
#
-# $Id: ltiauth.pm,v 1.12 2018/05/14 20:10:15 raeburn Exp $
+# $Id: ltiauth.pm,v 1.18 2019/06/13 17:45:26 raeburn Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -57,7 +57,7 @@ sub handler {
}
}
#
-# Retrieve data POSTed by LTI Consumer on launch
+# Retrieve data POSTed by LTI Consumer on launch
#
&Apache::lonacc::get_posted_cgi($r);
my $params = {};
@@ -205,14 +205,14 @@ sub handler {
$mapurl = $tail;
} else {
$symb = $tail;
- $symb =~ s{^/+}{};
+ $symb =~ s{^/}{};
}
} elsif ($tail =~ m{^/res/(?:$match_domain)/(?:$match_username)/.+\.(?:sequence|page)(|___\d+___.+)$}) {
if ($1 eq '') {
$mapurl = $tail;
} else {
$symb = $tail;
- $symb =~ s{^/+}{};
+ $symb =~ s{^/res/}{};
}
} elsif ($tail =~ m{^/($match_domain)/($match_courseid)$}) {
($urlcdom,$urlcnum) = ($1,$2);
@@ -339,6 +339,30 @@ sub handler {
}
#
+# Determine if a username is required from the domain
+# configuration for the specific LTI Consumer
+#
+
+ if (!$lti{$itemid}{'requser'}) {
+ if ($tail =~ m{^/tiny/($match_domain)/(\w+)$}) {
+ foreach my $key (%{$params}) {
+ delete($env{'form.'.$key});
+ }
+ my $ltoken = &Apache::lonnet::tmpput({'linkprot' => $itemid.':'.$tail},
+ $lonhost);
+ if ($ltoken) {
+ $r->internal_redirect($tail.'?ltoken='.$ltoken);
+ $r->set_handlers('PerlHandler'=> undef);
+ } else {
+ &invalid_request($r,9);
+ }
+ } else {
+ &invalid_request($r,10);
+ }
+ return OK;
+ }
+
+#
# Determine if source of username matches requirement from the
# domain configuration for the specific LTI Consumer.
#
@@ -394,7 +418,7 @@ sub handler {
if ($consumers{$sourcecrs} =~ /^$match_courseid$/) {
my $crshome = &Apache::lonnet::homeserver($consumers{$sourcecrs},$cdom);
if ($crshome =~ /(con_lost|no_host|no_such_host)/) {
- &invalid_request($r,9);
+ &invalid_request($r,11);
return OK;
} else {
$posscnum = $consumers{$sourcecrs};
@@ -406,7 +430,7 @@ sub handler {
if ($urlcnum ne '') {
if ($posscnum ne '') {
if ($posscnum ne $urlcnum) {
- &invalid_request($r,10);
+ &invalid_request($r,12);
return OK;
} else {
$cnum = $posscnum;
@@ -414,7 +438,7 @@ sub handler {
} else {
my $crshome = &Apache::lonnet::homeserver($urlcnum,$cdom);
if ($crshome =~ /(con_lost|no_host|no_such_host)/) {
- &invalid_request($r,11);
+ &invalid_request($r,13);
return OK;
} else {
$cnum = $urlcnum;
@@ -434,35 +458,16 @@ sub handler {
#
my (@ltiroles,@lcroles);
-
my @lcroleorder = ('cc','in','ta','ep','st');
- my @ltiroleorder = ('Instructor','TeachingAssistant','Mentor','Learner');
- if ($params->{'roles'} =~ /,/) {
- my @possltiroles = split(/\s*,\s*/,$params->{'roles'});
- foreach my $ltirole (@ltiroleorder) {
- if (grep(/^\Q$ltirole\E$/,@possltiroles)) {
- push(@ltiroles,$ltirole);
- }
- }
- } else {
- my $singlerole = $params->{'roles'};
- $singlerole =~ s/^\s|\s+$//g;
- if (grep(/^\Q$singlerole\E$/,@ltiroleorder)) {
- @ltiroles = ($singlerole);
- }
+ my ($lcrolesref,$ltirolesref) =
+ &LONCAPA::ltiutils::get_lc_roles($params->{'roles'},
+ \@lcroleorder,
+ $lti{$itemid}{maproles});
+ if (ref($lcrolesref) eq 'ARRAY') {
+ @lcroles = @{$lcrolesref};
}
- if (@ltiroles) {
- if (ref($lti{$itemid}{maproles}) eq 'HASH') {
- my %possroles;
- map { $possroles{$lti{$itemid}{maproles}{$_}} = 1; } @ltiroles;
- if (keys(%possroles) > 0) {
- foreach my $item (@lcroleorder) {
- if ($possroles{$item}) {
- push(@lcroles,$item);
- }
- }
- }
- }
+ if (ref($ltirolesref) eq 'ARRAY') {
+ @ltiroles = @{$ltirolesref};
}
#
@@ -485,102 +490,21 @@ sub handler {
}
}
if ($selfcreate) {
- my (%rulematch,%inst_results,%curr_rules,%got_rules,%alerts,%info);
- my $checkhash = { "$uname:$udom" => { 'newuser' => 1, }, };
- my $checks = { 'username' => 1, };
- &Apache::loncommon::user_rule_check($checkhash,$checks,\%alerts,\%rulematch,
- \%inst_results,\%curr_rules,\%got_rules);
- my ($userchkmsg,$lcauth,$lcauthparm);
- my $allowed = 1;
- if (ref($alerts{'username'}) eq 'HASH') {
- if (ref($alerts{'username'}{$udom}) eq 'HASH') {
- my $domdesc =
- &Apache::lonnet::domain($udom,'description');
- if ($alerts{'username'}{$udom}{$uname}) {
- if (ref($curr_rules{$udom}) eq 'HASH') {
- $userchkmsg =
- &Apache::loncommon::instrule_disallow_msg('username',$domdesc,1).
- &Apache::loncommon::user_rule_formats($udom,$domdesc,
- $curr_rules{$udom}{'username'},
- 'username');
- }
- $allowed = 0;
- }
- }
- }
- if ($allowed) {
- if (ref($rulematch{$uname.':'.$udom}) eq 'HASH') {
- my $matchedrule = $rulematch{$uname.':'.$udom}{'username'};
- my ($rules,$ruleorder) =
- &Apache::lonnet::inst_userrules($udom,'username');
- if (ref($rules) eq 'HASH') {
- if (ref($rules->{$matchedrule}) eq 'HASH') {
- $lcauth = $rules->{$matchedrule}{'authtype'};
- $lcauthparm = $rules->{$matchedrule}{'authparm'};
- }
- }
- }
- if ($lcauth eq '') {
- $lcauth = $lti{$itemid}{'lcauth'};
- if ($lcauth eq 'internal') {
- $lcauthparm = &create_passwd();
- } else {
- $lcauthparm = $lti{$itemid}{'lcauthparm'};
- }
- }
- } else {
- &invalid_request($r,12);
- }
- my @userinfo = ('firstname','middlename','lastname','generation',
- 'permanentemail','id');
- my %useinstdata;
- if (ref($lti{$itemid}{'instdata'}) eq 'ARRAY') {
- map { $useinstdata{$_} = 1; } @{$lti{$itemid}{'instdata'}};
- }
- foreach my $item (@userinfo) {
- if (($useinstdata{$item}) && (ref($inst_results{$uname.':'.$udom}) eq 'HASH') &&
- ($inst_results{$uname.':'.$udom}{$item} ne '')) {
- $info{$item} = $inst_results{$uname.':'.$udom}{$item};
- } else {
- if ($item eq 'permanentemail') {
- if ($env{'form.lis_person_contact_email_primary'} =~/^[^\@]+\@[^@]+$/) {
- $info{$item} = $env{'form.lis_person_contact_email_primary'};
- }
- } elsif ($item eq 'firstname') {
- $info{$item} = $env{'form.lis_person_name_given'};
- } elsif ($item eq 'lastname') {
- $info{$item} = $env{'form.lis_person_name_family'};
- }
- }
- }
- if (($info{'middlename'} eq '') && ($env{'form.lis_person_name_full'} ne '')) {
- unless ($useinstdata{'middlename'}) {
- my $fullname = $env{'form.lis_person_name_full'};
- if ($info{'firstname'}) {
- $fullname =~ s/^\s*\Q$info{'firstname'}\E\s*//i;
- }
- if ($info{'lastname'}) {
- $fullname =~ s/\s*\Q$info{'lastname'}\E\s*$//i;
- }
- if ($fullname ne '') {
- $fullname =~ s/^\s+|\s+$//g;
- if ($fullname ne '') {
- $info{'middlename'} = $fullname;
- }
- }
- }
- }
- if (ref($inst_results{$uname.':'.$udom}{'inststatus'}) eq 'ARRAY') {
- my @inststatuses = @{$inst_results{$uname.':'.$udom}{'inststatus'}};
- $info{'inststatus'} = join(':',map { &escape($_); } @inststatuses);
- }
+ my (%rulematch,%inst_results,%curr_rules,%got_rules,%alerts);
+ my $domdesc = &Apache::lonnet::domain($udom,'description');
+ my %data = (
+ 'permanentemail' => $env{'form.lis_person_contact_email_primary'},
+ 'firstname' => $env{'form.lis_person_name_given'},
+ 'lastname' => $env{'form.lis_person_name_family'},
+ 'fullname' => $env{'form.lis_person_name_full'},
+ );
my $result =
- &Apache::lonnet::modifyuser($udom,$uname,$info{'id'},
- $lcauth,$lcauthparm,$info{'firstname'},
- $info{'middlename'},$info{'lastname'},
- $info{'generation'},undef,undef,
- $info{'permanentemail'},$info{'inststatus'});
- if ($result eq 'ok') {
+ &LONCAPA::ltiutils::create_user($lti{$itemid},$uname,$udom,
+ $domdesc,\%data,\%alerts,\%rulematch,
+ \%inst_results,\%curr_rules,%got_rules);
+ if ($result eq 'notallowed') {
+ &invalid_request($r,14);
+ } elsif ($result eq 'ok') {
if (($ltiroles[0] eq 'Instructor') && ($lcroles[0] eq 'cc') && ($lti{$itemid}{'mapcrs'}) &&
($lti{$itemid}{'makecrs'})) {
unless (&Apache::lonnet::usertools_access($uname,$udom,'lti','reload','requestcourses')) {
@@ -588,16 +512,16 @@ sub handler {
}
}
} else {
- &invalid_request($r,13);
+ &invalid_request($r,15);
return OK;
}
} else {
- &invalid_request($r,14);
+ &invalid_request($r,16);
return OK;
}
}
} else {
- &invalid_request($r,15);
+ &invalid_request($r,17);
return OK;
}
@@ -619,10 +543,10 @@ sub handler {
$symb,$cdom,$cnum,$params,\@ltiroles,$lti{$itemid},\@lcroles,
$reqcrs,$sourcecrs);
} else {
- &invalid_request($r,16);
+ &invalid_request($r,18);
}
} else {
- &invalid_request($r,17);
+ &invalid_request($r,19);
}
return OK;
}
@@ -708,7 +632,7 @@ sub handler {
}
}
if ($reqrole eq '') {
- &invalid_request($r,18);
+ &invalid_request($r,20);
return OK;
} else {
unless (%crsenv) {
@@ -718,10 +642,10 @@ sub handler {
my $default_enrollment_end_date = $crsenv{'default_enrollment_end_date'};
my $now = time;
if ($default_enrollment_end_date && $default_enrollment_end_date <= $now) {
- &invalid_request($r,19);
+ &invalid_request($r,21);
return OK;
} elsif ($default_enrollment_start_date && $default_enrollment_start_date >$now) {
- &invalid_request($r,20);
+ &invalid_request($r,22);
return OK;
} else {
$selfenrollrole = $reqrole.'./'.$cdom.'/'.$cnum;
@@ -763,31 +687,8 @@ sub lti_enroll {
my %coursehash = &Apache::lonnet::coursedescription($cdom.'_'.$cnum);
my $start = $coursehash{'default_enrollment_start_date'};
my $end = $coursehash{'default_enrollment_end_date'};
- my $area = "/$cdom/$cnum";
- if (($role ne 'cc') && ($role ne 'co') && ($sec ne '')) {
- $area .= '/'.$sec;
- }
- my $spec = $role.'.'.$area;
- my $instcid;
- if ($role eq 'st') {
- $enrollresult =
- &Apache::lonnet::modify_student_enrollment($udom,$uname,undef,undef,undef,
- undef,undef,$sec,$end,$start,
- 'ltienroll',undef,$cdom.'_'.$cnum,1,
- 'ltienroll','',$instcid);
- } elsif ($role =~ /^(cc|in|ta|ep)$/) {
- $enrollresult =
- &Apache::lonnet::assignrole($udom,$uname,$area,$role,$end,$start,
- undef,1,'ltienroll');
- }
- if ($enrollresult eq 'ok') {
- my (%userroles,%newrole,%newgroups);
- &Apache::lonnet::standard_roleprivs(\%newrole,$role,$cdom,$spec,$cnum,
- $area);
- &Apache::lonnet::set_userprivs(\%userroles,\%newrole,\%newgroups);
- $userroles{'user.role.'.$spec} = $start.'.'.$end;
- &Apache::lonnet::appenv(\%userroles,[$role,'cm']);
- }
+ $enrollresult = &LONCAPA::ltiutils::enrolluser($udom,$uname,$role,$cdom,$cnum,$sec,
+ $start,$end,1);
}
}
return $enrollresult;
@@ -853,7 +754,7 @@ sub lti_session {
&Apache::lonauth::success($r,$uname,$udom,$uhome,'noredirect');
if ($symb) {
$env{'form.symb'} = $symb;
- $env{'request.lti.uri'} = $symb;
+ $env{'request.lti.uri'} = $tail;
} else {
if ($mapurl) {
$env{'form.origurl'} = $mapurl;
@@ -879,7 +780,7 @@ sub lti_session {
$env{'request.lti.sourcecrs'} = $sourcecrs;
}
if ($selfenrollrole) {
- $env{'request.lti.selfenroll'} = $selfenrollrole;
+ $env{'request.lti.selfenrollrole'} = $selfenrollrole;
$env{'request.lti.sourcecrs'} = $sourcecrs;
}
if ($ltihash->{'passback'}) {
@@ -996,24 +897,4 @@ sub invalid_request {
return;
}
-sub create_passwd {
- my $passwd = '';
- my @letts = ("a".."z");
- for (my $i=0; $i<8; $i++) {
- my $lettnum = int(rand(2));
- my $item = '';
- if ($lettnum) {
- $item = $letts[int(rand(26))];
- my $uppercase = int(rand(2));
- if ($uppercase) {
- $item =~ tr/a-z/A-Z/;
- }
- } else {
- $item = int(rand(10));
- }
- $passwd .= $item;
- }
- return ($passwd);
-}
-
1;