--- loncom/publisher/londiff.pm 2006/05/17 13:41:45 1.19 +++ loncom/publisher/londiff.pm 2008/11/20 14:37:30 1.25 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Handler to show differences between file versions # -# $Id: londiff.pm,v 1.19 2006/05/17 13:41:45 www Exp $ +# $Id: londiff.pm,v 1.25 2008/11/20 14:37:30 jms Exp $ # # Copyright Michigan State University Board of Trustees # @@ -27,6 +27,9 @@ # ### + + + package Apache::londiff; use strict; @@ -35,11 +38,12 @@ use File::Copy; use File::Compare; use Algorithm::Diff qw(diff); use Apache::Constants qw(:common :http :methods); -use Apache::loncacc; +use Apache::loncacc(); use Apache::lonnet; use Apache::loncommon(); +use Apache::lonretrieve(); use Apache::lonlocal; - +use LONCAPA(); sub get_split_file { my ($fn,$style)=@_; @@ -54,16 +58,9 @@ sub get_split_file { } } } elsif ($style eq 'remote') { - my $f1=&Apache::lonnet::getfile($fn); - } - if ($f1=~/\r/) { - @f1=split(/\r/,&Apache::lonnet::getfile($fn)); - foreach my $line (@f1) { - $line=~s/\n//g; - } - } else { - @f1=split(/\n/,&Apache::lonnet::getfile($fn)); + $f1=&Apache::lonnet::getfile($fn); } + @f1=split(/\r\n|\r|\n/,$f1); return @f1; } @@ -74,131 +71,139 @@ sub are_different_files { sub handler { - my $r=shift; - + my $r=shift; # Get query string for limited number of parameters - &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, - ['filename','versiontwo','versionone','filetwo']); + &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, + ['filename','versiontwo', + 'versionone','filetwo']); # Get the files - my $cuname=$env{'user.name'}; - my $cudom=$env{'user.domain'}; + my $cuname=$env{'user.name'}; + my $cudom=$env{'user.domain'}; - if ($env{'form.filename'}=~/^\/res\//) { - ($cudom,$cuname,$env{'form.filename'})= - ($env{'form.filename'}=~/^\/res\/(\w+)\/(\w+)\/(.*)$/); - } else { - unless (($cuname,$cudom)= - &Apache::loncacc::constructaccess($env{'form.filename'}, - $r->dir_config('lonDefDomain'))) { - $r->log_reason($cuname.' at '.$cudom. - ' trying to get diffs file '.$env{'form.filename'}. - ' - not authorized', - $r->filename); - return HTTP_NOT_ACCEPTABLE; - } - } + if ($env{'form.filename'}=~/^\/res\//) { + ($cudom,$cuname,$env{'form.filename'})= + ($env{'form.filename'}=~m{^/res/($LONCAPA::domain_re)/($LONCAPA::username_re)/(.*)$}); + } else { + unless (($cuname,$cudom)= + &Apache::loncacc::constructaccess($env{'form.filename'}, + $r->dir_config('lonDefDomain'))) { + $r->log_reason($cuname.':'.$cudom. + ' trying to get diffs file '.$env{'form.filename'}. + ' - not authorized', + $r->filename); + return HTTP_NOT_ACCEPTABLE; + } + } - my $efn=$env{'form.filename'}; + my $efn=$env{'form.filename'}; - $efn=~s/\/\~(\w+)//g; + $efn=~s{/\~($LONCAPA::username_re)}{}g; - my @f1=(); - my @f2=(); + my @f1=(); + my @f2=(); - &Apache::loncommon::content_type($r,'text/html'); - $r->send_http_header; + &Apache::loncommon::content_type($r,'text/html'); + $r->send_http_header; - $r->print(&Apache::loncommon::start_page('Resource Differences')); + $r->print(&Apache::loncommon::start_page('Resource Differences')); - $r->print('
');
- if ($env{'form.versionone'} eq 'priv') {
- my $fn='/home/'.$cuname.'/public_html/'.$efn;
- @f1=&get_split_file($fn,'local');
- $r->print(''.&mt('Construction Space Version').'');
- } else {
- my $fn=
- '/home/httpd/html/res/'.$cudom.'/'.$cuname.'/';
- if ($env{'form.versionone'}) {
- my ($main,$suffix)=($efn=~/^(.+)\.(\w+)$/);
- $fn.=$main.'.'.$env{'form.versionone'}.'.'.$suffix;
- $r->print(''.&mt('Version').' '.$env{'form.versionone'}.'');
- } else {
- $fn.=$efn;
- $r->print(''.&mt('Current Version').'');
- }
- @f1=&get_split_file($fn,'remote');
- }
-
- $r->print('
'.&mt('versus').'
');
-
- if ($env{'form.filetwo'}) {
- my $efn2=$env{'form.filetwo'};
- $efn2=~s/\/\~(\w+)//g;
- my $fn='/home/'.$cuname.'/public_html/'.$efn2;
- @f2=&get_split_file($fn,'local');
- $r->print(''.$efn2.'');
- } elsif ($env{'form.versiontwo'} eq 'priv') {
- my $fn='/home/'.$cuname.'/public_html/'.$efn;
- @f2=&get_split_file($fn,'local');
- $r->print(''.&mt('Construction Space Version').'');
- } else {
- my $fn=
- '/home/httpd/html/res/'.$cudom.'/'.$cuname.'/';
- if ($env{'form.versiontwo'}) {
- my ($main,$suffix)=($efn=~/^(.+)\.(\w+)$/);
- $fn.=$main.'.'.$env{'form.versiontwo'}.'.'.$suffix;
- $r->print(''.&mt('Version').' '.$env{'form.versiontwo'}.'');
- } else {
- $fn.=$efn;
- $r->print(''.&mt('Current Version').'');
- }
- @f2=&get_split_file($fn,'remote');
- }
- $r->print('
');
+ if ($env{'form.versionone'} eq 'priv') {
+ my $fn='/home/'.$cuname.'/public_html/'.$efn;
+ @f1=&get_split_file($fn,'local');
+ $r->print(''.&mt('Construction Space Version').'');
+ } else {
+ my $fn=
+ '/home/httpd/html/res/'.$cudom.'/'.$cuname.'/';
+ if ($env{'form.versionone'}) {
+ my ($main,$suffix,$is_meta)=
+ &Apache::lonretrieve::get_file_info($efn);
+
+ $fn.=($efn =~m|(.*/)[^/]+|)[0];
+ # add on to $fn the path information in $efn
+ $fn.=$main.'.'.$env{'form.versionone'}.'.'.$suffix;
+ $r->print(''.&mt('Version').' '.$env{'form.versionone'}.'');
+ } else {
+ $fn.=$efn;
+ $r->print(''.&mt('Current Version').'');
+ }
+ @f1=&get_split_file($fn,'remote');
+ }
+
+ $r->print('
'.&mt('versus').'
');
+
+ if ($env{'form.filetwo'}) {
+ my $efn2=$env{'form.filetwo'};
+ $efn2=~s{/\~($LONCAPA::username_re)}{}g;
+ my $fn='/home/'.$cuname.'/public_html/'.$efn2;
+ @f2=&get_split_file($fn,'local');
+ $r->print(''.$efn2.'');
+ } elsif ($env{'form.versiontwo'} eq 'priv') {
+ my $fn='/home/'.$cuname.'/public_html/'.$efn;
+ @f2=&get_split_file($fn,'local');
+ $r->print(''.&mt('Construction Space Version').'');
+ } else {
+ my $fn=
+ '/home/httpd/html/res/'.$cudom.'/'.$cuname.'/';
+ if ($env{'form.versiontwo'}) {
+ my ($main,$suffix,$is_meta)=
+ &Apache::lonretrieve::get_file_info($efn);
+ # add on to $fn the path information in $efn
+ $fn.=($efn =~m|(.*/)[^/]+|)[0];
+ $fn.=$main.'.'.$env{'form.versiontwo'}.'.'.$suffix;
+ $r->print(''.&mt('Version').' '.$env{'form.versiontwo'}.'');
+ } else {
+ $fn.=$efn;
+ $r->print(''.&mt('Current Version').'');
+ }
+ @f2=&get_split_file($fn,'remote');
+ }
+ $r->print('
'); + my $chunk; + my $line; - foreach $chunk (@$diffs) { + $r->print(''); + + foreach $chunk (@$diffs) { - foreach $line (@$chunk) { - my ($sign, $lineno, $text) = @$line; - $text=~s/\\<\;/g; - $text=~s/\>/\>\;/g; - $lineno=substr($lineno.' ',0,7); - $r->print(''. - $sign.' '.$lineno.' '.$text."\n"); - } - $r->print("'); - - } else { - $r->print('
\n"); - } - $r->print(''.&mt('Binary File').'
'); - } - $r->print(''.&mt('Close This Window').' '); - $r->print(&Apache::loncommon::end_page()); - return OK; + foreach $line (@$chunk) { + my ($sign, $lineno, $text) = @$line; + $text=&HTML::Entities::encode($text,'<>&"'); + $lineno=substr($lineno.' ',0,7); + $r->print(''. + $sign.' '.$lineno.' '.$text."\n"); + } + $r->print("
\n"); + } + $r->print(''); + + } else { + $r->print('