--- loncom/publisher/lonpubdir.pm	2004/12/22 21:04:52	1.75
+++ loncom/publisher/lonpubdir.pm	2006/04/18 22:38:08	1.90
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Construction Space Directory Lister
 #
-# $Id: lonpubdir.pm,v 1.75 2004/12/22 21:04:52 albertel Exp $
+# $Id: lonpubdir.pm,v 1.90 2006/04/18 22:38:08 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -61,7 +61,7 @@ sub handler {
              $fn,$r->dir_config('lonDefDomain')); 
   unless (($uname) && ($udom)) {
      $r->log_reason($uname.' at '.$udom.
-         ' trying to list directory '.$ENV{'form.filename'}.
+         ' trying to list directory '.$env{'form.filename'}.
          ' ('.$fn.') - not authorized', 
          $r->filename); 
      return HTTP_NOT_ACCEPTABLE;
@@ -72,7 +72,7 @@ sub handler {
   $fn=~s/\/$//;
 
   unless ($fn) { 
-     $r->log_reason($ENV{'user.name'}.' at '.$ENV{'user.domain'}.
+     $r->log_reason($env{'user.name'}.' at '.$env{'user.domain'}.
          ' trying to list empty directory', $r->filename); 
      return HTTP_NOT_FOUND;
   } 
@@ -91,7 +91,7 @@ sub handler {
   my %bombs=&Apache::lonmsg::all_url_author_res_msg($uname,$udom);
 
   &startpage($r, $uname, $udom, $thisdisfn);   # Put out the start of page.
-  if ($ENV{'environment.remote'} eq 'off') {
+  if ($env{'environment.remote'} eq 'off') {
       &dircontrols($r,$uname,$udom,$thisdisfn);    # Put out actions for directory, 
                                                # browse/upload + new file page.
   } else {
@@ -111,7 +111,7 @@ sub handler {
             '<th bgcolor="#DDDDDD">'.&mt('Title').'</th>'.
 	    '<th bgcolor="#DDDDDD">'.&mt('Status').'</th>'.
             '<th bgcolor="#DDDDDD">'.&mt('Last Modified').
-	    '</th></tr>');
+	    '</th></tr>'."\n");
 
   my $filename;
   my $dirptr=16384;		# Mask indicating a directory in stat.cmode.
@@ -137,7 +137,7 @@ sub handler {
   }
   closedir(DIR);
 
-  $r->print('</table></body></html>');
+  $r->print('</table>'.&Apache::loncommon::end_page());
   return OK;  
 }
 #
@@ -148,8 +148,8 @@ sub getEffectiveUrl {
     my $r = shift;
     my $fn;
     
-    if ($ENV{'form.filename'}) {	# If a form filename is defined.
-	$fn=$ENV{'form.filename'};
+    if ($env{'form.filename'}) {	# If a form filename is defined.
+	$fn=$env{'form.filename'};
 	#
 	#   Replace the ~username of the URL with /home/username/public_html
 	#   so that we don't have to worry about ~ expansion internally.
@@ -192,12 +192,9 @@ sub startpage {
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
 
-    $r->print('<html><head><title>LON-CAPA Construction Space</title></head>');
-
-    my $pagetitle;
     my $formaction='/priv/'.$uname.$thisdisfn.'/';
-    $formaction=~s/\/+/\//g;
-    $pagetitle .= &Apache::loncommon::help_open_menu('','','','',3,'Authoring').
+    $formaction=~s|/+|/|g;
+    my $pagetitle .= &Apache::loncommon::help_open_menu('','','','',3,'Authoring').
         '<font face="Arial, Helvetica, sans-serif" size="+1"><b>Construction Space</b>:</font>&nbsp;'.
         '<form name="dirs" method="post" action="'.$formaction.
         '" target="_parent"><tt><b>'.
@@ -206,14 +203,18 @@ sub startpage {
                  'this.form.action=this.form.recent.value;this.form.submit()').
               '</form>';
     &Apache::lonhtmlcommon::store_recent('construct',$formaction,$formaction);
-    if ($ENV{'environment.remote'} eq 'off') {
-	$ENV{'request.noversionuri'}=$currdir.'/';
-	$r->print(&Apache::loncommon::bodytag('Construction Space',undef,undef,undef,undef,undef,$pagetitle));
+    if ($env{'environment.remote'} eq 'off') {
+	$env{'request.noversionuri'}=$currdir.'/';
+	$r->print(&Apache::loncommon::start_page('Construction Space',undef,
+						 {'body_title' =>
+						      $pagetitle,}));
     } else {
+	$r->print(&Apache::loncommon::start_page('Construction Space',undef));
 	$r->print($pagetitle);
     }
+
     my $pubdirscript=(<<ENDPUBDIRSCRIPT);
-<script>
+<script type="text/javascript">
 top.document.title = '$thisdisfn/ - LON-CAPA Construction Space';
 // Store directory location for menu bar to find
 
@@ -223,12 +224,8 @@ parent.lastknownpriv='/~$uname$thisdisfn
 
     function currdiract(theform) {
         if (theform.dirtask.options[theform.dirtask.selectedIndex].value == 'publish') {
-            document.publishdir.filename.value = theform.filename.value
-            pubdir(document.publishdir)
-        }
-        if (theform.dirtask.options[theform.dirtask.selectedIndex].value == 'publishsub') {
-            document.publishdir.filename.value = theform.filename.value
-            pubrecdir(document.publishdir)
+            document.publishdir.filename.value = theform.filename.value;
+	    document.publishdir.submit();
         }
         if (theform.dirtask.options[theform.dirtask.selectedIndex].value == 'editcat') {
             top.location=theform.filename.value+'default.meta'
@@ -237,28 +234,13 @@ parent.lastknownpriv='/~$uname$thisdisfn
             document.printdir.postdata.value=theform.filename.value
             document.printdir.submit();
         }
-    }
-  
-    function pubdir(theform) {
-	if (confirm('Publish complete directory?')) {
-            forcepub(theform)
-	    theform.submit();
+        if (theform.dirtask.options[theform.dirtask.selectedIndex].value == "delete") {
+              var delform = document.delresource
+              delform.filename.value = theform.filename.value
+              delform.submit()
         }
     }
-    function pubrecdir(theform) {
-	if (confirm('Publish directory and all subdirectories?')) {
-            forcepub(theform);
-            theform.pubrec.value='1';
-	    theform.submit();
-        }
-    }
-
-    function forcepub(theform) {
-        if (confirm('Force publication of unmodified files? - OK=yes; Cancel=No.')) {
-            theform.forcerepub.value="ON";
-        } 
-    }
-
+  
     function checkUpload(theform) {
         if (theform.file == '') {
             alert("Please use 'Browse..' to choose a file first, before uploading")
@@ -273,10 +255,7 @@ parent.lastknownpriv='/~$uname$thisdisfn
             return
         }
         if (theform.diraction.options[theform.diraction.selectedIndex].value == "publish") {
-            pubdir(theform)
-        }
-        if (theform.diraction.options[theform.diraction.selectedIndex].value == "publishsub") {
-            pubrecdir(theform)
+            theform.submit();
         }
         if (theform.diraction.options[theform.diraction.selectedIndex].value == "editcat") {
             top.location=theform.filename.value+'default.meta'
@@ -286,6 +265,11 @@ parent.lastknownpriv='/~$uname$thisdisfn
             theform.postdata.value = theform.filename.value
             theform.submit()
         }
+        if (theform.diraction.options[theform.diraction.selectedIndex].value == "delete") {
+              var delform = document.delresource
+              delform.filename.value = theform.filename.value
+              delform.submit()
+        }
         return
     }
     function SetResChoice(theform) {
@@ -306,7 +290,7 @@ parent.lastknownpriv='/~$uname$thisdisfn
       if (activity == 'obsolete') {
           var pubform = document.pubresource
           pubform.filename.value = theform.filename.value
-          alert("You will be taken to the publication page.\\nCheck the 'Obsolete' checkbox at the bottom of the page, and click 'Finalize Publication'.")
+          pubform.makeobsolete.value=1;
           pubform.submit()
       }
       if (activity == 'print') {
@@ -317,6 +301,10 @@ parent.lastknownpriv='/~$uname$thisdisfn
           document.retrieveres.filename.value = theform.filename.value
           document.retrieveres.submit()
       }
+      if (activity == 'cleanup') {
+          document.cleanup.filename.value = theform.filename.value
+          document.cleanup.submit()
+      }
       return
     }
     function changename(theform,activity) {
@@ -333,8 +321,8 @@ parent.lastknownpriv='/~$uname$thisdisfn
 ENDPUBDIRSCRIPT
     $r->print($pubdirscript);
 
-    if ((($uname ne $ENV{'user.name'}) || ($udom ne $ENV{'user.domain'})) &&
-	$ENV{'environment.remote'} ne 'off') {
+    if ((($uname ne $env{'user.name'}) || ($udom ne $env{'user.domain'})) &&
+	$env{'environment.remote'} ne 'off') {
 	$r->print('<h3>'.&mt('Co-Author').': '.$uname.' at '.$udom.
 		  '</h3>');
     }
@@ -342,29 +330,60 @@ ENDPUBDIRSCRIPT
 
 sub dircontrols {
     my ($r,$uname,$udom,$thisdisfn) = @_;
+    my %lt=&Apache::lonlocal::texthash(
+                                       cnpd => 'Cannot publish directory',
+                                       cnrd => 'Cannot retrieve directory',
+                                       mcdi => 'Must create new subdirectory inside a directory',
+                                       pubr => 'Publish this Resource',
+                                       pubd => 'Publish this Directory',
+                                       dedr => 'Delete Directory',
+                                       rtrv => 'Retrieve Old Version',
+                                       list => 'List Directory',
+                                       uplo => 'Upload file',  
+                                       dele => 'Delete',
+                                       edit => 'Edit Catalog Information', 
+                                       sela => 'Select Action',
+                                       nfil => 'New file',
+                                       nhtm => 'New HTML file',
+                                       nprb => 'New problem',
+                                       npag => 'New assembled page',
+                                       nseq => 'New assembled sequence',
+                                       ncrf => 'New custom rights file',
+                                       nsty => 'New style file',
+                                       nlib => 'New library file',
+                                       nsub => 'New subdirectory',
+                                       renm => 'Rename current file to',
+                                       move => 'Move current file to',
+                                       copy => 'Copy current file to',
+                                       type => 'Type Name Here',
+                                       go => 'Go',
+                                       prnt => 'Print contents of directory',
+                                       crea => 'Create a new directory or LON-CAPA document',
+				       acti => 'Actions for current directory',
+				       updc => 'Upload a new document'
+                                      );
     $r->print(<<END);
         <table cellspacing="4" cellpadding="4" width="100%">
          <tr>
-          <td bgcolor="#DDDDDD" align="middle"><font face="Arial, Helvetica, sans-serif" size="-1"><b>Actions for current directory</b></font></td>
-          <td bgcolor="#DDDDDD" align="middle"><font face="Arial, Helvetica, sans-serif" size="-1"><b>Upload a new document</b></font></td>
-          <td bgcolor="#DDDDDD" align="middle"><font face="Arial, Helvetica, sans-serif" size="-1"><b>Create a new directory or LON-CAPA document</b></font></td>
+          <td bgcolor="#DDDDDD" align="center"><font face="Arial, Helvetica, sans-serif" size="-1"><b>$lt{'acti'}</b></font></td>
+          <td bgcolor="#DDDDDD" align="center"><font face="Arial, Helvetica, sans-serif" size="-1"><b>$lt{'updc'}</b></font></td>
+          <td bgcolor="#DDDDDD" align="center"><font face="Arial, Helvetica, sans-serif" size="-1"><b>$lt{'crea'}</b></font></td>
         </tr>
         <tr>
          <td bgcolor="#ccddaa" valign="top" align="center">
           <form name="curractions" method="post" action="">
-           <select name="dirtask" onChange="currdiract(this.form)">
-            <option>Select action</option>
-            <option value="publish">Publish directory</option>
-            <option value="publishsub">Publish with subdirectories</option>
-            <option value="editcat">Edit catalog information</option>
-            <option value="printdir">Print contents of directory</option>
+           <select name="dirtask" onchange="currdiract(this.form)">
+            <option>$lt{'sela'}</option>
+            <option value="publish">$lt{'pubd'}</option>
+            <option value="editcat">$lt{'edit'}</option>
+            <option value="printdir">$lt{'prnt'}</option>
+            <option value="delete">$lt{'dedr'}</option>
            </select>
            <input type="hidden" name="filename" value="/~$uname$thisdisfn/" />
           </form>
           <form name="publishdir" method="post" action="/adm/publish" target="_parent">
            <input type="hidden" name="pubrec" value="" />
            <input type="hidden" name="filename" value="" />
-           <input type="hidden" name="forcerepub" value="NO" />
           </form>
           <form name="printdir" method="post" action="/adm/printout" target="_parent">
            <input type="hidden" name="postdata" value="" />
@@ -374,23 +393,24 @@ sub dircontrols {
 	    <form name="upublisher" enctype="multipart/form-data" method="post" action="/adm/upload" target="_parent">
 	      <input type="hidden" name="filename" value="/~$uname$thisdisfn/" />
 	      <input type="file" name="upfile" size="20" />
-	      <input type="button" value="Upload file"  onclick="checkUpload(this.form)" />
+	      <input type="button" value="$lt{'uplo'}"  onclick="checkUpload(this.form)" />
 	    </form>
 	 </td>
 	 <td bgcolor="#ccddaa" align="center">
 	    <form name="fileaction" method="post" action="/adm/cfile" target="_parent">
 	      <nobr>
 		<input type="hidden" name="filename" value="/~$uname$thisdisfn/" />
-		  <select name="action">
-		    <option>Select Action</option>
-		    <option value="newfile">New file:</option>
-		    <option value="newhtmlfile">New HTML file:</option>
-		    <option value="newproblemfile">New problem:</option>
-                    <option value="newpagefile">New assembled page:</option>
-                    <option value="newsequencefile">New assembled sequence:</option>
-                    <option value="newrightsfile">New custom rights file:</option>
-                    <option value="newstyfile">New style file:</option>
-		    <option value="newdir">New subdirectory:</option>
+			  <select name="action">
+			    <option value="Select Action">$lt{'sela'}</option>
+			    <option value="newfile">$lt{'nfil'}:</option>
+			    <option value="newhtmlfile">$lt{'nhtm'}:</option>
+			    <option value="newproblemfile">$lt{'nprb'}:</option>
+                            <option value="newpagefile">$lt{'npag'}:</option>
+                            <option value="newsequencefile">$lt{'nseq'}:</option>
+                            <option value="newrightsfile">$lt{'ncrf'}:</option>
+                            <option value="newstyfile">$lt{'nsty'}:</option>
+                            <option value="newlibraryfile">$lt{'nlib'}:</option>
+			    <option value="newdir">$lt{'nsub'}:</option>
 		  </select>&nbsp;<input type="text" name="newfilename" value="Type Name Here" onfocus="if (this.value == 'Type Name Here') this.value=''" />&nbsp;<input type="button" value="Go" onclick="document.fileaction.submit()" />
 		 </nobr>
 		</form>
@@ -405,13 +425,8 @@ sub pubbuttons {
     $r->print('<form method="post" action="/adm/publish" target="_parent">'.
               '<table><tr><td><input type="hidden" name="filename" value="/~'.
                $uname.$thisdisfn.'/" />'.
-              '<input type="button" onClick="pubdir(this.form);" value="'.
-&mt('Publish Directory').'" />'.
-              '<input type="hidden" name="pubrec" value="" />'.
-              '<input type="hidden" name="forcerepub" value="NO" />'.
-              '<input type="button" onClick="pubrecdir(this.form);" value="'.
-&mt('Publish Directory and Sub Directories').'" /></td><td>'.
-'<input type="button" onClick="window.location='."'/~".
+              '<input type="submit" value="'.&mt('Publish Directory').'" /></td><td>'.
+'<input type="button" onclick="window.location='."'/~".
                $uname.$thisdisfn."/default.meta'".'" value="'.
 &mt('Edit Directory Catalog Information').'" /></td></tr></table></form>');
 }
@@ -429,9 +444,8 @@ sub resourceactions {
          <input type="hidden" name="action" value="delete" />
        </form>
        <form name="pubresource" action="/adm/publish" target="_parent" method="post">
-         <input type="hidden" name="pubrec" value="" />
          <input type="hidden" name="filename" value="" />
-         <input type="hidden" name="forcerepub" value="NO" />
+         <input type="hidden" name="makeobsolete" value="0" />
        </form>
        <form name="printresource" action="/adm/printout" target="_parent" method="post">
            <input type="hidden" name="postdata" value="" />
@@ -439,6 +453,9 @@ sub resourceactions {
        <form name="retrieveres" action="/adm/retrieve" target="_parent" method="post">
            <input type="hidden" name="filename" value="" />
        </form>
+       <form name="cleanup" action="/adm/cleanup" target="_parent" method="post">
+           <input type="hidden" name="filename" value="" />
+       </form>
 END
 }
 
@@ -508,27 +525,25 @@ sub putdirectory {
             $actionitem = 
                     '<form name="dirselect_'.$$numdir.
                     '" action="/adm/publish" target="_parent">'.
-                    '<select name="diraction" onChange="SetPubDir(this.form,document)">'.
+                    '<select name="diraction" onchange="SetPubDir(this.form,document)">'.
                       '<option selected="selected">'.&mt('Select action').'</option>'.
                       '<option value="open">'.&mt('Open').'</option>'.
                       '<option value="publish">'.&mt('Publish').'</option>'.
-                      '<option value="publishsub">'.&mt('Publish with subdirectories').'</option>'.
                       '<option value="editcat">'.&mt('Edit catalog information').'</option>'.
-                      '<option value="printdir">'.&mt('Print directory').
+                      '<option value="printdir">'.&mt('Print directory').'</option>'.
+                      '<option value="delete">'.&mt('Delete directory').'</option>'.
                     '</select>'.
-                     '<input type="hidden" name="filename" value="'.$dirpath.'/'.$dirname.'/" />'.
+                     '<input type="hidden" name="filename" value="'.&HTML::Entities::encode($dirpath.'/'.$dirname,'<>&"').'/" />'.
                      '<input type="hidden" name="openname" value="'.$here.'/'.$dirname.'/" />'.
-                     '<input type="hidden" name="pubrec" value="" />'.
-                     '<input type="hidden" name="forcerepub" value="" />'.
                      '<input type="hidden" name="postdata" value="" />'.
                    '</form>';
             $$numdir ++;
         }
 	$r->print('<tr bgcolor="#CCCCFF">'.
 		  '<td><img src="'.
-		  $Apache::lonnet::perlvar{'lonIconsURL'}.'/folder_closed.gif" /></td>'.
+		  $Apache::lonnet::perlvar{'lonIconsURL'}.'/folder_closed.gif" alt="folder" /></td>'.
 		  '<td>'.$actionitem.'</td>'.
-		  '<td><font face="arial"><a href="'.$here.'/'.$dirname.'/" target="_parent">'.
+		  '<td><font face="arial"><a href="'.&HTML::Entities::encode($here.'/'.$dirname,'<>&"').'/" target="_parent">'.
 		  $disfilename.'</a></font></td>'.
 		        '<td colspan="2">'.($kaputt?&Apache::lonhtmlcommon::authorbombs($resdir.'/'.$disfilename.'/'):'').$Apache::lonpublisher::metadatafields{'title'}.' <i>'.
 		  $Apache::lonpublisher::metadatafields{'subject'}.'</i> '.
@@ -545,6 +560,7 @@ sub putresource {
     my ($r, $udom, $uname, $filename, $thisdisfn, 
 	$resdir, $targetdir, $linkdir,
 	$cmtime,$bombs,$numres) = @_;
+    &Apache::lonnet::devalidate_cache_new('meta',$targetdir.'/'.$filename);
     my $pubstatus = 'unpublished';
     my $status=&mt('Unpublished');
     my $bgcolor='#FFAA99';
@@ -575,7 +591,7 @@ sub putresource {
 #		$action_buttons='';
 #	    }
 	    $title='<a href="/res/'.$targetdir.'/'.$filename.
-		'.meta" target=cat>'.
+		'.meta" target="cat">'.
 		&getTitleString($targetdir.'/'.$filename).'</a>';
 	} else {
             $pubstatus = 'modified';
@@ -584,17 +600,17 @@ sub putresource {
 		&mt(&getSourceRightString($targetdir.'/'.$filename));
             $bgcolor='#FFFF77';
 #	    $action_buttons='';
-	    $title='<a href="/res/'.$targetdir.'/'.$filename.'.meta" target=cat>'.
+	    $title='<a href="/res/'.$targetdir.'/'.$filename.'.meta" target="cat">'.
 		&getTitleString($targetdir.'/'.$filename).'</a>';
 	    if (&Apache::loncommon::fileembstyle(($filename=~/\.(\w+)$/)) eq 'ssi') {
 		$status.='<br /><a href="/adm/diff?filename=/~'.$uname.
 		    $thisdisfn.'/'.$filename.
-		    '&versiontwo=priv" target=cat>'.&mt('Diffs').'</a>';
+		    '&amp;versiontwo=priv" target="cat">'.&mt('Diffs').'</a>';
 	    }
 	}
-	$title.='<br /><a href="/~'.$uname.$thisdisfn.'/'.$filename.'.meta">'. 
-	    ($$bombs{$targetdir.'/'.$filename}?'<img src="/adm/lonMisc/bomb.gif" border="0" />':'Edit Metadata').'</a>';
-	$status.='<br><a href="/adm/retrieve?filename=/~'.$uname.
+	$title.="\n".'<br /><a href="/~'.$uname.$thisdisfn.'/'.$filename.'.meta">'. 
+	    ($$bombs{$targetdir.'/'.$filename}?'<img src="/adm/lonMisc/bomb.gif" border="0" alt="bomb" />':'Edit Metadata').'</a>';
+	$status.="\n".'<br /><a href="/adm/retrieve?filename=/~'.$uname.
 	    $thisdisfn.'/'.$filename.'" target="_parent">'.&mt('Retrieve').'</a>';
     }
     my $editlink='';
@@ -606,6 +622,10 @@ sub putresource {
 	$editlink=' (<a href="'.$linkdir.'/'.$filename.'?forceedit=1" target="_parent">'.&mt('EditXML').'</a>)';
 	$editlink2=' <br />(<a href="'.$linkdir.'/'.$filename.'?forceColoredit=1" target="_parent">'.&mt('Edit').'</a>)';
     }
+    if ($filename=~/\.(problem|exam|quiz|assess|survey|form|library|xml|html|htm|xhtml|xhtm|sty)$/) {
+	$editlink.=' (<a href="/adm/cleanup?filename=/~'.$uname.
+	    $thisdisfn.'/'.$filename.'" target="_parent">'.&mt('Clean Up').')</a>';
+    }
     if ($filename=~/\.(zip|tar|bz2|gz|tar.gz|tar.bz2|tgz)$/) {
 	$editlink=' (<a target="_parent" href="/adm/cfile?decompress=/~'.
 	      $uname.$thisdisfn.'/'.$filename.'">'.&mt('Decompress').'</a>)';
@@ -614,7 +634,7 @@ sub putresource {
     &create_pubselect($r,\$pub_select,$udom,$uname,$thisdisfn,$filename,$resdir,$pubstatus,$publish_button,$numres);
     $r->print('<tr bgcolor="'.$bgcolor.'">'.
 	      '<td>'.($filename=~/[\#\~]$/?'&nbsp;':
-		      '<img src="'.&Apache::loncommon::icon($filename).'" /></td>').
+		      '<img src="'.&Apache::loncommon::icon($filename).'" alt="" />').'</td>'.
               '<td>'.$pub_select.'</td>'.
 	      '<td><font face="arial">'.
 	      '<a href="'.$linkdir.'/'.$filename.'" target="_parent">'.
@@ -631,30 +651,31 @@ sub create_pubselect {
     my ($r,$pub_select,$udom,$uname,$thisdisfn,$filename,$resdir,$pubstatus,$publish_button,$numres) = @_;
     $$pub_select = '
 <form name="resselect_'.$$numres.'" action="">
-<select name="reschoice"  onChange="SetResChoice(this.form)">
-<option>'.&mt('Select action').
-'<option value="copy"/>'.&mt('Copy');
+<select name="reschoice"  onchange="SetResChoice(this.form)">
+<option>'.&mt('Select action').'</option>'.
+'<option value="copy">'.&mt('Copy').'</option>';
     if ($pubstatus eq 'obsolete' || $pubstatus eq 'unpublished') {
         $$pub_select .= 
-'<option value="rename"/>'.&mt('Rename').
-'<option value="move"/>'.&mt('Move').
-'<option value="delete"/>'.&mt('Delete');
+'<option value="rename">'.&mt('Rename').'</option>'.
+'<option value="move">'.&mt('Move').'</option>'.
+'<option value="delete">'.&mt('Delete').'</option>';
     } else {
         $$pub_select .= '
-<option value="obsolete"/>'.&mt('Mark obsolete');
+<option value="obsolete">'.&mt('Mark obsolete').'</option>';
     }
 # check for versions
     my $versions = &check_for_versions($r,'/'.$filename,$udom,$uname);
     if ($versions > 0) {
         $$pub_select .='
-<option value="retrieve"/>'.&mt('Retrieve old version');
+<option value="retrieve">'.&mt('Retrieve old version').'</option>';
     }
     $$pub_select .= '
-<option value="publish"/>'.$publish_button.
-'<option value="print"/>'.&mt('Print').
+<option value="publish">'.$publish_button.'</option>'.
+'<option value="cleanup">'.&mt('Clean up').'</option>'.
+'<option value="print">'.&mt('Print').'</option>'.
 '</select>
 <input type="hidden" name="filename" value="/~'.
- $uname.$thisdisfn.'/'.$filename.'"></form>';
+ &HTML::Entities::encode($uname.$thisdisfn.'/'.$filename,'<>&"').'" /></form>';
     $$numres ++;
 }
 
