CVS log for loncom/publisher/lonpubdir.pm

Up to [LON-CAPA] / loncom / publisher

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11.4 (modified)
  Include changes in 1.176, 1.177, 1.178, 1.179 (part)

- For 2.11.4 (modified)
  Include changes in 1.175

- For 2.11
  Backport 1.174, 1.175, 1.182

- For 2.11.4 (modified)
  Include changes in 1.165, 1.166, 1.181

- Code used to create default.rights file for course authoring space
  moved from londocs.pm to loncommon.pm to facilitate reuse.
- Course Editor > Content Utilities > Enter Course Authoring Space
  will create required directories and default.rights file if absent.

- For 2.11.4 (modified)
  Include changes in 1.182

- Include (Edit) link below filename for .txt, .css and .js files in directory
  listing in Authoring Space.

- Available editors in Authoring Space: value set for specific author can
  override domain default.

- Remove trailing whitespace.  No code changes.

- Actions available in "Create a new subdirectory or document" box for
  Course Authoring Space are: New file, New HTML file, New problem,
  New subdirectory
- Editing of default.rights file at top level of Course Authoring Space
  disabled.

- Remove "Actions for current directory" drop-down list from box created by
  &CSTR_pageheader() when listing contents of a directory in Authoring Space
  and replace with icons/links in Functions menu below standard inline menus.
- Reverse part of changes in lonpubdir.pm 1.176 and loncommon.pm 1.1406

- xhtml validation.

- Move "Quick search" box to be left-most of three boxes above directory
  listing
- Move "Actions for current directory" into row above, between select box
  for recently accessed diretories, and disk spce utilization display.

- Shortcuts in "Create a new directory or LON-CAPA document" box.
  - Change Quickactions to Shortcuts
  = Add missing &mt()
  - Display prompts to enter new file name or subdirectory name when
    "Type name here" textbox is empty

- For 2.11.4 (modified)
  Include changes in rev. 1.174

- Use of a frameset for Authoring Space (from lonconstruct.pm) was eliminated
  in 2.11.0. As a result target="_parent" is no longer required in lonpubdir.pm

- For 2.11
  Changes in 1.160.2.4 backport had changes from 1.169 not needed in 2.11

- For 2.11
  Backport 1.164, 1.171, 1.172, 1.173

- file_upload.js not needed when error page displayed for 2.11.0 and later,
  because Authoring Space migration is incomplete.
- Remove unused class (testclass)
- Add double quotes for value attribute

- Prepend LC_ to id of hidden form element used in client-side checking for
  uploaded file size, for purposes of namespacing.

- Prepend LC_ to class name in client-side checking for uploaded file size,
  for purposes of namespacing.

- For 2.11
  - Backport 1.170

fixed bug 6835

- For 2.11
  - Backport 1.163

- For 2.11
  - Backport 1.168

- Course Editor has "Standard Problem" item (Grading tab) for creation
  of new problem in user's Authoring Space, or in a Course "Authoring" Space.
- Course Editor has "Import from Course Resources" item (Import tab) to
  import published content from Course "Authoring" Space.
- Course "Authoring" Space
  - default.rights -- course-only access
  - quota is shared with content uploaded directly to course
  - content only browsable in course context
  - metadata not included in searchable meatdata MySQL table
CVs: ----------------------------------------------------------------------

- Display course's quota usage in file upload section in Course Editor
- Consistent conversion for kB -> MB
- div style for disk usage: inline in Authoring Space; block in portfolio.

Added Daxe editing for HTML documents, fixed issues with case mixing in task documents

added a preview for Daxe, updated automatically when the document is saved

integrated Daxe, opening in a separate window for now

File size checking for uploaded files

A new javascript file, file_upload.js, handles client side file size checking.
The function, checkUploadSize(), accepts an html file input element and a maximum
file size (in bytes) as input.  If the size of the file to be uploaded exceeds the
size allowed, a message is displayed the the element is cleared.  Server side
checking is still used if it passes this test.

Loading file_upload.js adds event handlers to file input elements with
class="flUpload".
    <input type="file" class="flUpload" />

It also looks for a hidden element with id="free_space" that contains the maximum
upload size.
    <input type="hidden" id="free_space" value="$free_space" />

The free space is usually calculated by subtracting a user's disk usage from their
quota allowance.  In some cases it is a fixed value.

I have implemented this for every upload instance I could find.  These include:
* Message attachments
* Authoring space
* Portfolio
* Course editor
* Essay response problems
* Helpdesk request forms
* RSS feed uploads

authoring space overhaul
this update tries to improve the user experience of the authoring space.

added codemirror for xml editor and script tags in colorful editor
added possibility to deactivate codemirror in author settings
added dropdown menu to insert problem templates into xml editor (thanks to tobias reinhardt)
added feature of saving current scrollposition on save when editing problems
added possibility to fold blocks in colorful editor, this state will be saved and restored
added shortcuts to create empty problems, html files and directories

and other smaller features and bugfixes

the search function is still work in progress!
- fixed html errors

added search functionality to authoring space

- users can now search their author space for files. the search functions searches in the file name and title. use of regular expressions and case sensitivity can be enabled. the content table of the current directory will shrink so that only matching entries are shown. a second table appears underneath to show results in other directories.
- german translation has been added.

Columns are sortable in the course quota list as well as well as the resource list in authoring space.  An up or down arrow is displayed next to the sorted column header indicating whether it is in ascending or descending order.

This resolves Bug #6704

Excluding display of .DAV files

- Exclude . and .. from directory listing when determining if directory
  is empty. Correction to regexps added in rev. 1.157

- More specific feedback to user when attempting to list contents of a
  directory in authoring space when there is nothing to list.

- Don't display dot underscore files created when copying a file in
  Mac OS X to a mounted webDAV volume.

- Detect if Authoring Spaces have not been moved following upgrade from 2.10
  (and older) to 2.11, and display an appropriate message.

- Early out if top level directory in Authoring Space is empty.
- &handler() returns 'OK'; no need to return 'OK' from other subroutines.

- Coding style: sprintf() etc.

Resources in authoring space can now be sorted by Type, Title, Status, and Size.  Reverse sorting is also possible by re-selecting a column heading.

The size of files is displayed in kB.  Including the recursive size of directories proved to be too slow.  The following simple functions were added:
getTitle
getStatus
isMetaSame

- Re-instate &mt() for column headings.

Resources can now be sorted in authoring space by either "Name" or "Last Modified" by clicking on the column heading.

update documentation

- Don't list .DS_Store file saved when viewing directory via webDAV on MacOS.

- Disk quotas for authoring spaces.
  - Default is 500 MB, unless set at domain level, or individual user level.
  - Domain default set via "Blogs, personal web pages, webDAV/quotas, portfolio" in
    "Set domain configuration" by DC.
  - Quota for individual user's authoring space set via:
    "Create users or modify the roles and privileges of users" by DC
  - &display_usage() moved from portfolio.pm to lonhtmlcommon.pm to
    facilitate re-use. In portfolio.pm &display_portfolio_usage() now calls
    lonhtmlcommon::display_usage().

- xhtml.

- Replace term: "Construction Space" with "Authoring Space" for
  consistency with type of role used to access it, and action taken there.

- &constructaccess() moved from loncacc.pm to lonnet.pm
  - to facilitate re-use, and separate from handler,
  - for use in lonnet.pm (use Apache::Constants() not supported there.

- Bug 1320: Corrected links - show bombs again in CSTR
    Work in progress:
        - Resource row: access to bomb needed
        - Confirm backward compatibility
- Improve lonpubdir.pm 1.142: Only one programmened link "Edit Metadata"
- Remove inconsistent manual padding

Always offer link to "Edit Metadata" to allow editing metadata of unpublished resources. The current functionality directly offers the possibility to edit even so far non-existing meta files; just the link was missing.

Fix detection of modified source file and link to modified metadata diffs

Modal windows for retrieve and subsequent screens

Bug #2484: Close Window on "Diff"

- Bug 6530.
  - Additional clean up for bug 1320, following retirement of lonconstruct.pm
    (see: loncapa_apache.conf rev 1.205 vs. 1.204).

- &authorspace() routine now takes an argument: $uri
  so "Construction Space" breadcrumb points at appropriate author space
  for resource/directory being viewed or acted om.
  - current role could be different or ("no role" - i.e., cm), so is only
    used to determine authorspace when $uri is unavailable.

Trying to get rid of some of the copy/paste regular expressions.

- Fix Construction breadcrumb trails for /adm/cfile, /adm/publish,
  /adm/retrieve, /adm/upload.

- Fix Construction breadcrumb trails for /adm/publish /adm/retrieve
  - loncommon::CSTR_pageheader() takes optional argument
    - name of file or directory used to construct breadcrumb trail
      where $env{'request.filename'} is inappropriate.
- use lonDocRoot perlvar in place of static string: '/home/httpd/html'
- coding style
   - eliminate leaning toothpicks

- Bug 1320 clean-up - fix link to published resource in CSTR directory listing
- Update documentation.
- Rename sixth argument in &putdirectory() as $targetdir for consistency with
  was passed to it.
- Coding style
    - keys(), eliminate $_, regexp match use {} as delimiters
                            where / in undesirable.
    - sanity checking for ref to hash.

Bug #1320: declutter

Bug #1320

Bug #1320: the passed filename should always be of the type
/priv/domain/user/...
instead of being different for different handlers

Work on Bug #1320:
* lonconstruct.pm wrapper no longer needed
* no "Parent Directory" for construction space root

Bug #1320

Bug #1320: Oops, debug code

Toward Bug #1320

In process of removing remote control, remote navmap and different icon modes code
Also some minor refactoring.

- Remove surplus line following backports in 1.114.2.1.

- Backport 1.118, 1.119, 1.120, 1.124.

- fixed an issue that caused wrong breadcrumb (and tools) behavior in construction space
- course title is now centered at the top

Optimized display of XML source publication status (open/closed):
- Allow proper translation
- Allow authors to understand

Use new folder icon

Credits: Juliane Wenzel

Changes related to modification of LON-CAPA screen header.
Added dynamic link to Construction Space to breadcrumbs

To get rid of the title_bar, customized titles aren't allowed anymore.

Moved special title for Construction Space pages from &start_page() to new routine &CSTR_pageheader(). Since &start_page() isn't the only routine called to create the page header, the centralized creation of the CSTR page header code can't be currently called in &start_page(). This needs to be done at each place where &start_page() is called.

First changes to get rid of customized page titles:
- Moved CSTR page header code from start_page to new sub routine &CSTR_pageheader()
- Currently keep old header but use &CSTR_pageheader()
- Directly call &CSTR_pageheader() in CSTR related scripts (lonpubdir.pm, lonhomework.pm, structuretags.pm)
  (More scripts need to call this routine)
- Added new sub routine &head_subbox() to create head_subbox which contains page related links and functions, etc.
- Added styles for &head_subbox()
  (Currently implemented as LC_head_subbox2 to avoid conflicts with code created by lonhtmlcommon::breadcrumbs - will be changed)

Other but related changes:
- Added some breadcrumbs to CSTR
  (Only basic calls - links and structure has to be added/revisited)
- Adjusted styles used for breadcrumbs:
    - Replaced hardcoded border color by dynamical standard border color
    - Removed margin to allow direct concatination with head_subbox

- Added some FIXME comments to mark work in progress

Consistent Wording:
username:domain

consistent wording, email -> e-mail, catalog information -> metadata, e-mail vs. message

- Backport 1.118.

- Regular Expressions for both http and https.

change name of a new style to LC_**

Standard style for actions at top of construction space screen:
- Replaced specially styled action elements with new standard divs and fieldsets.
- Removed "Directory Contents" headline (not really needed - it's obvious)
- Removed now unused styles and translation

- Use LON-CAPA standard data tables in Construction Space and Portofolio Tables
- Moved color indicator from whole background to new and only small column.
  This should prevent a "color shock" but keeps the "show status by different colors" functionality.

loncommon.pm:
- Adjusted the related styles ("LC_browser...") correspondingly to the changes described above.

Additional changes/optimizations/corrections in portfolio.pm:
- Added missing &mt() calls to headline in selection mode
- Replaced hardcoded nobreak with CSS
- Fill empty table cells in directory rows with blanks to have a proper table structure
- Optimized and extended colspan precalculation
- XHTML conform "checked" usage in checkboxes

Moved POD comments to bottom of file

all "editcat" renamed to "editmeta"
all "Edit Catalog Information" renamed to "Edit Metadata"

Added/updated POD documentation

Added module description to header of file, plus subroutine descriptions (POD format)

Localization:
Added missing &mt() calls

Localization:
Added two missing &mt() calls

- loncommon::start_page() does its own &mt() on the title passed to it as the first argument.
- $doctitle - change &mt() to reuse existing translation.

Corrected wrong usage of "'" in version 1.106 which made the dropboxes left of each resource in Construction Space lose there function.

Localization: added missing $mt(...), $lt{...}

- BUG#5508 warn on no action selected

- BUG#5488,
   - strip leading trailing blanks from filenames,
   - switch to displaying file names with pre to preserve the multiple
     blank spaces in a row if they exists

- add task to creation menu

 bug#5240, wrong headers in remote mode when clicking list directory

- some ' breakage

- log spew

- invalid html (BUG#5128)

- more re fix ups

	Don't bother renaming to the same name. Jeesh.

	Bug 5078. Populate field with oldname when renaming resource
	in construction space.

- BUG#5014, when modifying .meta files need to advertise that fact in the
     directoy browser
    - additionaly when doing full dir repbulishes, republish if the .meta file has changed
- also add support for retrieving a previoulsy published .meta file
- add support for getting diffs between previous .meta file revisions

- help_open_men changes
- also adding the location bar into res space browsing of simple rat

- the controls box is cssed now

- cstr space and portfoli now use same css attr to enusre similarity of display

Bug #1431: if the file did not change, maintain the publication status

- only_body detection for cstr space now done in bodytag routine

- start_page
- adding support fo the last argument to bodytag

Include ability to delete directories in remoteless CSTR. part of bug 1860.

publishsub option no longer used (see rev 1.79).

- html cleanups

- it's onchange not onChange
- it's align="center"  not middle (valign is middle)

* Was missing Library file option from lonpubmenu
* Internationalized
* Really, this should share subroutines with lonpubmenu - no time right now.

Cleanup handler

Work on making cleanup more widely available

Bug #3956: force directory metadata to override existing
Bug #3352: make obsolete
Bug #3119: edit metadata now actually remembers things

Saving my work: force publication of directories

Work on force publication using different copyright, etc.

- ENV -> env

- yeah! well formed xml for directory listings

- BUG#3855, there was no way to avoid avoid forced republication of all files.

- BUG#3745

- fixes 3708, remoteless CSTR, the line "Co-Author: $authorname at $authordomain" takes up a lot of space and is redundant

Re-instate setting of window title for directory listing in CSTR.

Alternative fix to bug #3654. Re-instate use of publisher/publisher.html.  recommend substitution with lonpubmenu.pm for 1.4 to eliminate inconsistent behavior of "Publish Resource" button in top frame, and "Publish Directory" button in main frame.

Fix bug #3671.

More succinct fix to bug #3629.

Fix bug #3629.

Fixing a number of small errors. Some compaction to conserve screen area.  Removed some unneeded javascript functions - getcurrseed(), getproblemtype().

Fix bug #3639

Fix bugs #3640, 3631, 3630, 3628.  Menu buttons eliminated when viewing directories in iCSTR in remoteless mode. Directory position and selection now directly below top menu bar. Directory location larger font, headings for directory options (remoteless only) smaller font. Certain directory actions directed to top, (to escape frame), to avoid nesting frames.

- when in remote mode trying to reduce the amount of headers

Changes to allow construction space operations without need for Remote Control.  The top frame - publisher.html is not used in inline mode.  Work in progress.

Bug #2450: deleting un-openable files from Construction Space

BUG#3061, retreive doesn't need it's own indow.

* show sourcerights in dir listing
* dial in the previously set value of sourceavail on re-publish
* fix paths for sourcerights-file the same as for customrights

- BUG#2931

"Recent Folders" in construction space

Even better handling of bombs.

But it was so nice and big ...

- regexp would blow up on directories named 'break(things'

Bug #2449

Looks a little nicer.

Include file icons.

Show default.meta info in dir listing for directory entry.

Bug #2444: error messages can be displayed from Construction Space

Bug #2444: show bombs in construction space.

Correct language headers in loncfile
Improved filename crumbs
Better prettyprint

Crumbs on both /priv and /res

Added &mt() function call.

loncfile includes the new decompression system integrated, a lot better than the old way lonconstruct and lonpubdir just support

New backend to make decompress go, shouldn't break anything.......

- BUG#2362, sort files listing case insesitively

Just adding support for some decompression, nothing very exciting :)

Internationalization, and in particular, lonlocal:locallocaltime and
Japanese dates.

Various small internationalization bugfixes.

Bug #1715 "obsolete marking" and internationalization

Internationalizing.

Added the edit link, that was discussed in bug: 2047 to allow for easy editing

Bug #2018 - one starts to wonder how CSTR worked as well as it did.

Bug #1728: style files can be editied in CSTR space

Have very limited connectivity, need to do big commit while online.
Will call this JULYone in Bugzilla. Fixes several small bugs.

As discussed in developer meeting, now shows EditXML for problems.

Bug #430 - way to directly go into (XML) edit mode if problem/page is
broken.

Bug #1265: upper construction space menu bar would not work if lower frame
shows /adm/ or /res/ resources.

- should take care of #1448,
  - directories put their name in the title
  - any html puts a name in the title

(currently images don't and I don't see any good way of changing that.)

best wishes to all.

Bug #952 - shows "Confirm" dialog before publishing directories.

Bug #492

- reversed the diff sense, it always seemed backwards to me

Toward bug 482

Bug 498
Links to top frame so URL in browser corresponds to URL worked on.
Status colors back. Show "[untitled]" for unnamed modified files.

- fixes BUG #261, $r->filname() isn't correct for non users, need to use $r->uri and fix it up

Restructure the code to make it somewhat easier to read/maintain.

Break out putresource as a sub for file resources.

- Rearrange columns and remove color coding.
- Start code restructuring in to functionally distinct subs from soup of code.

- added a trailing slash to directory names

Title display

adding in POD documentation; changing void context map statements to
foreach statements; removing references to Apache::lonnet::fileembstyle
and using Apache::loncommon::fileembstyle -Scott Harrison

remove lonnet::fileembstyle reference (use loncommon instead) and add
POD documentation -Scott Harrison

 - GPL headers added

Omit only files whose extension is marked "hdn" in filetypes.tab.

- preserving a comment

Can do retrieve directly from lonpubdir in case original file damaged

Has publish button and diff bugfix

- typo

- now prints files in order
- handles files with no extension better it still hides them though

More actions in construction space

Bugfix, needs to load lonnet

Make londiff work for co-author

Respects co-author role, also for /home/author

Diff improvements

Did not return true value

Better handling of parent directory

Kind of works now.

New handlers to retrieve old versions of files and list construction space