--- loncom/publisher/lonrights.pm	2009/12/02 18:33:35	1.29
+++ loncom/publisher/lonrights.pm	2010/06/06 02:40:44	1.30
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to show and edit custom distribution rights
 #
-# $Id: lonrights.pm,v 1.29 2009/12/02 18:33:35 bisitz Exp $
+# $Id: lonrights.pm,v 1.30 2010/06/06 02:40:44 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -210,19 +210,19 @@ sub handler {
   $r->print(&Apache::loncommon::start_data_table_row().'<td align="right">');
   if ($constructmode) {
      $r->print(&Apache::loncommon::select_form('','action_0',
-                                  ('' => '',
-                                   'insertbelow' => &mt('Insert rule below'))));
+                                  {'' => '',
+                                   'insertbelow' => &mt('Insert rule below')}));
                                                 
   } else {
       $r->print('&nbsp;');
   }
   $r->print('</td><td>');
   if ($constructmode) {
-      $r->print(&Apache::loncommon::select_form
-                                 ($token->[2]->{'effect'},'effect_0',
-                                  &Apache::lonlocal::texthash
+      my %lt = &Apache::lonlocal::texthash
                                    ('allow' => 'allow',
-                                    'deny'  => 'deny')));
+                                    'deny'  => 'deny');
+      $r->print(&Apache::loncommon::select_form
+                                 ($token->[2]->{'effect'},'effect_0',\%lt));
   } else {
       $r->print($token->[2]->{'effect'});
   }
@@ -241,26 +241,28 @@ sub handler {
 # insert, delete, etc
 	  $r->print('<span class="LC_nobreak">'.$rulecounter.'. ');
           if ($constructmode) {
+             my %lt = &Apache::lonlocal::texthash
+                          ('' => '',
+                           'delete' => 'Delete this rule',
+                           'insertabove' => 'Insert rule above',
+                           'insertbelow' => 'Insert rule below',
+                           'moveup'      => 'Move rule up',
+                           'movedown'    => 'Move rule down'
+                           );
+
              $r->print(&Apache::loncommon::select_form(
-                    '','action_'.$rulecounter,
-                    &Apache::lonlocal::texthash
-                    ('' => '', 
-                     'delete' => 'Delete this rule',
-                     'insertabove' => 'Insert rule above',
-                     'insertbelow' => 'Insert rule below',
-                     'moveup'      => 'Move rule up',
-                     'movedown'    => 'Move rule down')));
+                    '','action_'.$rulecounter,\%lt));
 	  }
           $r->print('</span></td>'.
 		    '<td rowspan="2">');
 # effect
           if ($constructmode) {
+             my %lt = &Apache::lonlocal::texthash
+                             ('allow' => 'allow',
+                              'deny'  => 'deny');
              $r->print(&Apache::loncommon::select_form
                                  ($token->[2]->{'effect'},
-                                  'effect_'.$rulecounter,
-                                  &Apache::lonlocal::texthash
-                                   ('allow' => 'allow',
-                                    'deny'  => 'deny')));
+                                  'effect_'.$rulecounter,\%lt));
           } else {
              $r->print($token->[2]->{'effect'});
           }
@@ -269,11 +271,11 @@ sub handler {
 	  $r->print('</td><td rowspan="2">');
 	  my $type = ($token->[2]{'type'} || 'course');
           if ($constructmode) {
+              my %lt = &Apache::lonlocal::texthash
+                           ('course' => 'Course',
+                            'user'   => 'User');
               $r->print(&Apache::loncommon::select_form($type,
-							'type_'.$rulecounter,
-                            &Apache::lonlocal::texthash
-							('course' => 'Course',
-							 'user'   => 'User')));
+							'type_'.$rulecounter,\%lt));
           } else {
               $r->print($type);
           }
@@ -328,7 +330,7 @@ sub handler {
 		  my $role=$token->[2]->{'role'};
 		  unless ($role) { $role=''; }
 		  $r->print(&Apache::loncommon::select_form(
-							    $role,'role_'.$rulecounter,%hash));
+							    $role,'role_'.$rulecounter,\%hash));
 	      } else {
 		  $r->print(&Apache::lonnet::plaintext($token->[2]->{'role'}));
 	      }