--- loncom/publisher/lonupload.pm	2001/12/17 00:57:59	1.10
+++ loncom/publisher/lonupload.pm	2003/02/03 18:03:53	1.15
@@ -1,7 +1,8 @@
+
 # The LearningOnline Network with CAPA
 # Handler to upload files into construction space
 #
-# $Id: lonupload.pm,v 1.10 2001/12/17 00:57:59 harris41 Exp $
+# $Id: lonupload.pm,v 1.15 2003/02/03 18:03:53 harris41 Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -43,7 +44,6 @@
 #
 # 04/05,04/09,05/25,06/23,06/24,08/22 Gerd Kortemeyer
 # 11/29 Matthew Hall
-# 12/16 Scott Harrison
 #
 ###
 
@@ -52,9 +52,30 @@ package Apache::lonupload;
 use strict;
 use Apache::File;
 use File::Copy;
+use File::Basename;
 use Apache::Constants qw(:common :http :methods);
 use Apache::loncacc;
 use Apache::loncommon();
+use Apache::Log();
+use Apache::lonnet;
+use HTML::Entities();
+
+my $DEBUG=0;
+
+sub Debug {
+  
+  # Marshall the parameters.
+  
+  my $r       = shift;
+  my $log     = $r->log;
+  my $message = shift;
+  
+  # Put out the indicated message butonly if DEBUG is false.
+  
+  if ($DEBUG) {
+    $log->debug($message);
+  }
+}
 
 sub upfile_store {
     my $r=shift;
@@ -86,6 +107,10 @@ sub phaseone {
     $fn=~s/^\///;
     $fn=~s/(\/)+/\//g;
 
+#    Fn is the full path to the destination filename.
+#    
+
+    &Debug($r, "Filename for upload: $fn");
     if (($fn) && ($fn!~/\/$/)) {
       $r->print(
  '<form action=/adm/upload method=post>'.
@@ -123,10 +148,20 @@ sub phaseone {
 
 sub phasetwo {
    my ($r,$fn,$uname,$udom)=@_;
-   if ($fn=~/^\/priv\/$uname\//) { 
+   &Debug($r, "Filename is ".$fn);
+   if ($fn=~/^\/priv\/$uname\//) {
+    &Debug($r, "Filename after priv substitution: ".$fn);
     my $tfn=$fn;
     $tfn=~s/^\/(\~|priv)\/(\w+)//;
+    &Debug($r, "Filename for tfn = ".$tfn);
     my $target='/home/'.$uname.'/public_html'.$tfn;
+    &Debug($r, "target -> ".$target);
+#     target is the full filesystem path of the destination file.
+    my $base = &File::Basename::basename($fn);
+    my $path = &File::Basename::dirname($fn);
+    $base    = &HTML::Entities::encode($base);
+    my $url  = $path."/".$base; 
+    &Debug($r, "URL is now ".$url);
     my $datatoken=$ENV{'form.datatoken'};
     if (($fn) && ($datatoken)) {
 	if ((-e $target) && ($ENV{'form.override'} ne 'Yes')) {
@@ -134,7 +169,7 @@ sub phasetwo {
  '<form action=/adm/upload method=post>'.
  'File <tt>'.$fn.'</tt> exists. Overwrite? '.
  '<input type=hidden name=phase value=two>'.
- '<input type=hidden name=filename value="'.$fn.'">'.
+ '<input type=hidden name=filename value="'."$url".'">'.
  '<input type=hidden name=datatoken value="'.$datatoken.'">'.
  '<input type=submit name=override value="Yes"></form>');
        } else {
@@ -156,8 +191,9 @@ sub phasetwo {
  'The extension on this file is not recognized by LON-CAPA.'.
  '</font>');
 	   } elsif (copy($source,$target)) {
+	       chmod(0660, $target); # Set permissions to rw-rw---.
 	      $r->print('File copied.');
-              $r->print('<p><font size=+2><a href="'.$fn.
+              $r->print('<p><font size=+2><a href="'.$url.
                         '">View file</a></font>');
 	   } else {
               $r->print('Failed to copy: '.$!);