CVS log for loncom/publisher/lonupload.pm

Up to [LON-CAPA] / loncom / publisher

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Breadcrumbs text when displaying/editing resource in Course Authoring Space.

- Sanity checking.

- Uploading a file to Authoring Space.
  - Remove characters which are not allowed.
  - Replace pattern: .number.extension with _letter.extension
  - Include feedback to user about changes made.

- Sanity checking.

- Add trailing slash to URL linked to via 'Back to Directory' when upload of
  file was followed by upload of dependencies (e.g., image files in a web page)
  to avoid spurious warning message:
  "You do not have authoring privileges for this resource".

Fixed typo

- In loncommon.pm: &excess_filesize_authorspace() was renamed as
  excess_filesize_warning(), and third arg changed to context
  (author or course).

- Bug 6168 (a part).
  - Display warning if copying file would exceed quota in authoring space
  - Testing if quota would be exceeded by file upload moved from lonupload.pm
    to &excess_filesize_authorspace() routine in loncommon.pm to facilitate reuse.

- Disk quotas for authoring spaces.
  - Default is 500 MB, unless set at domain level, or individual user level.
  - Domain default set via "Blogs, personal web pages, webDAV/quotas, portfolio" in
    "Set domain configuration" by DC.
  - Quota for individual user's authoring space set via:
    "Create users or modify the roles and privileges of users" by DC
  - &display_usage() moved from portfolio.pm to lonhtmlcommon.pm to
    facilitate re-use. In portfolio.pm &display_portfolio_usage() now calls
    lonhtmlcommon::display_usage().

- Replace term: "Construction Space" with "Authoring Space" for
  consistency with type of role used to access it, and action taken there.

- &constructaccess() moved from loncacc.pm to lonnet.pm
  - to facilitate re-use, and separate from handler,
  - for use in lonnet.pm (use Apache::Constants() not supported there.

- loncommon::modify_html_refs() now explicitly called in scalar context.

- &authorspace() routine now takes an argument: $uri
  so "Construction Space" breadcrumb points at appropriate author space
  for resource/directory being viewed or acted om.
  - current role could be different or ("no role" - i.e., cm), so is only
    used to determine authorspace when $uri is unavailable.

- Fix Construction breadcrumb trails for /adm/cfile, /adm/publish,
  /adm/retrieve, /adm/upload.

- Clean-up for bug 1320.
  - Eliminate unused args:  $uname, $udom from &phaseone(), &phasetwo.
  - Fix "View Main file" link when processing dependencies in HTML file uploaded
    to CSTR.
- Fix Construction Space breadcrumb trail for /adm/upload

- Remove duplicate declaration for $url_root.

- Use lonDocRoot perlvar in place of static string: '/home/httpd/html'.

Bug #1320: cleanup

Bug #1320

- lonupload::phasethree() now returns an array.

That we are a co-author is additional information, not a warning

- Work on upload of HTML file with references to embedded objects etc.
   - Replace &process_secondary_uploads() in londocs with general purpose routines
     in loncommon.pm.
   - More comprehensive feedback on reference detection.
   - Reference updates in HTML file for changed paths originally only available
     for upload of HTML file in course, now available for uploads in all contexts.
   - Directory traversal in original HTML file via ../ etc. accommodated.

- Bug 5462. No reference warning or prompt for upload of files, if
   referenced files are already available at the specified paths.
   - work in progress (change still needed for londocs.pm).

- Standard pick_box style for upload options
- Code refactoring: Early escape in case of no file and in case of illeagal filename
- "File already exists": optimized button arrangement and wording
- Problems due to user fault (invalid extension, existing file,  ...):
    - Warning style instead of error style
    - Wrap whole message in warning style
- Filename style for filenames
- Removed deprecated font tag

- Backport 1.48 and part of 1.47 for 2.9.X.

XHTML:
- Close <option>
- HTML attributes in lower case

Changes related to modification of LON-CAPA screen header.
- Added breadcrumbs
- Added standard CSTR page header

- Replaced button text "Save" by "Upload" to make clearer what will be done.

Don't translate separator character between and domain.
Advantages: No need to change the translation files, if...
  - different separator character should be used
  - different output is wanted, e.g. just username, plainname, both, etc.
  - different style should be used for output
(work in progress to make this even more flexible by introducing a global function usernamewrapper)

XHTML conform selected/checked/multiple HTML attributes
and optimized spacing

Optimized Co-Author warnings:
- Replaced error style by warning style which fits much better here
- Don't use headline tag anymore as style to highlight message
- Optimized &mt usage
- Consistent/standard output of username:domain

- Backport 1.43.

- Regular Expression for both http and https.

- Remove duplicate concatenation operator.

- Backport 1.41, 1.42.

- Unmatched HTML tags.

- Localization: Optimized &mt() usage
- Optimized error message display (use <p> tag)

Added/updated/converted POD. Many files had their POD redone to new standards.

POD documentation changes

- fix perldoc

- When web pages are uploaded to CSTR, user will be prompted to upload any embedded objects (e.g., image files).
- Checking for existing files and valid extension for files uploaded to CSTR moved to &check_extension() subroutine.
- &phasethree() added to handle uploading of embedded objects.

Bug #5533: Untranslatable upload interface, cancel button

- switch Store to Save

- more re fix ups

- move inline text into help files
- CSS erro messages and file names

- rest of the add_entries conversion

- start_page

- eliminating the inclusion of Apache::Log (it annoys Apache 2 and aache 1 doesn't need it)

- ENV -> env

Give the form a name to avoid using forms[0].  Remoteless CSTR adds another form before this one, so forms[0].filetype no longer exists.

Bug #2927: "Back to Directory" also works on top-level

- trying to be UTF8 transparent

Modification to accommodate upload of testbanks and IMS packages.

-more xhtmlize

- xhtmlize

- retabinate

- BUG#1904
- typo in locaization code

Internationalization.

Phase 2:

* returning to phase 1 could never have worked correctly; eliminated.

* did not check if target was an existing directory, and changed mode of
  parent directory to "rw-rw" overriding the "x"; put in checking.

Working on bug #2018: could not handle absolute vs. relative URLs

Have very limited connectivity, need to do big commit while online.
Will call this JULYone in Bugzilla. Fixes several small bugs.

- BUG#1880, nice link for unviewable files that have been uploaded

best wishes to all.

Correct ad hoc mapping of urls to use HTTP::Entities::encode.

Bug 442: Two issues with special chars. solved here:
1. spaces in names - escape works fine on this issue.
2. apostrophe's in uploaded file names:

Apostrophe solution not so easy as spaces:  The problem was in the
Frame src tag for the lower frame of construction space.. it's of the form:
<frame> src='$lowerframe' ...Thanks to matt for finding this.
The embedded ' closes the src from the point of view of the html.  Amazingly the
 extra characters don't cause browsers to complain.  The problem: demonstrably,
escaping via lonnet::escape does nothing worth while.  Using my handy dandy
html pocket guide, I determined that lonnet::escape is too simple minded
and may in fact be not quite right.  did a:
1. made the quotations " rather than '
2. Substituted for " in $lowerframe by:
   $lowerframe=~s/\"/&quot\;/g;

Turning " -> &quot; as per the entity chart on pg 82 of HTML Pocket ref.
This works fine.

BUG 442 - map %20 to ' ' in filenames.

Fix bug 59: Uploaded file permissions not correct.

adding in POD documentation; changing void context map statements to
foreach statements; removing references to Apache::lonnet::fileembstyle
and using Apache::loncommon::fileembstyle -Scott Harrison

Disallow uploads of files that are marked 'hdn' in filetypes.tab or not listed
in filetypes.tab.

Added GPL preamble.
Disallow uploading of files whose extension is marked "hdn" in "filetypes.tab".

Return true value

Gets rid of Windows path in suggested upload name.

More actions in construction space

Bug fix, illegal filenames

Bugfix

Upload file functionality

File upload into construction space