--- loncom/publisher/testbankimport.pm	2012/10/29 17:38:55	1.35
+++ loncom/publisher/testbankimport.pm	2013/10/10 00:46:50	1.43
@@ -1,5 +1,5 @@
 # Handler for parsing text upload problem descriptions into .problems
-# $Id: testbankimport.pm,v 1.35 2012/10/29 17:38:55 raeburn Exp $
+# $Id: testbankimport.pm,v 1.43 2013/10/10 00:46:50 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -89,7 +89,7 @@ function createWin() {
     newWindow.document.write("<input type='hidden' name='callingmode' value='testbank' />")
     newWindow.document.write("<input type='hidden' name='inhibitmenu' value='yes' />")
     newWindow.document.write("$webpath<input type='text' name='newfilename' value='' />")
-    newWindow.document.write("<input type='button' value='$lt{'go'}' onClick='document.fileaction.submit();' /></form>")
+    newWindow.document.write("<input type='button' value='$lt{'go'}' onclick='document.fileaction.submit();' /></form>")
     newWindow.document.write('$end_page')
     newWindow.document.close()
     newWindow.focus()
@@ -289,18 +289,20 @@ function colSet(caller) {
     else {
         if ((poolForm.elements[caller*5+3].options[poolForm.elements[caller*5+3].selectedIndex].value == "MC") || (poolForm.elements[caller*5+3].options[poolForm.elements[caller*5+3].selectedIndex].value == "MA") || (poolForm.elements[caller*5+3].options[poolForm.elements[caller*5+3].selectedIndex].value == "Ord")) {
             poolForm.elements[caller*5+4].options[0] = new Option("Select","-1",true,true)
-            poolForm.elements[caller*5+4].options[1] = new Option("a.","lcperiod",false,false)
-            poolForm.elements[caller*5+4].options[2] = new Option("A.","ucperiod",false,false)
-            poolForm.elements[caller*5+4].options[3] = new Option("(a)","lcparen",false,false)
-            poolForm.elements[caller*5+4].options[4] = new Option("(A)","ucparen",false,false)
-            poolForm.elements[caller*5+4].options[5] = new Option("a)","lconeparen",false,false)
-            poolForm.elements[caller*5+4].options[6] = new Option("A)","uconeparen",false,false)
-            poolForm.elements[caller*5+4].options[7] = new Option("a.)","lcdotparen",false,false)
-            poolForm.elements[caller*5+4].options[8] = new Option("A.)","ucdotparen",false,false)
-            poolForm.elements[caller*5+4].options[9] = new Option("(i)","romparen",false,false)
-            poolForm.elements[caller*5+4].options[10] = new Option("i)","romoneparen",false,false)
-            poolForm.elements[caller*5+4].options[11] = new Option("i.)","romdotparen",false,false)
-            poolForm.elements[caller*5+4].options[12] = new Option("i.","romperiod",false,false)
+            poolForm.elements[caller*5+4].options[1] = new Option("a ","lcspace",false,false)
+            poolForm.elements[caller*5+4].options[2] = new Option("A ","ucspace",false,false) 
+            poolForm.elements[caller*5+4].options[3] = new Option("a.","lcperiod",false,false)
+            poolForm.elements[caller*5+4].options[4] = new Option("A.","ucperiod",false,false)
+            poolForm.elements[caller*5+4].options[5] = new Option("(a)","lcparen",false,false)
+            poolForm.elements[caller*5+4].options[6] = new Option("(A)","ucparen",false,false)
+            poolForm.elements[caller*5+4].options[7] = new Option("a)","lconeparen",false,false)
+            poolForm.elements[caller*5+4].options[8] = new Option("A)","uconeparen",false,false)
+            poolForm.elements[caller*5+4].options[9] = new Option("a.)","lcdotparen",false,false)
+            poolForm.elements[caller*5+4].options[10] = new Option("A.)","ucdotparen",false,false)
+            poolForm.elements[caller*5+4].options[11] = new Option("(i)","romparen",false,false)
+            poolForm.elements[caller*5+4].options[12] = new Option("i)","romoneparen",false,false)
+            poolForm.elements[caller*5+4].options[13] = new Option("i.)","romdotparen",false,false)
+            poolForm.elements[caller*5+4].options[14] = new Option("i.","romperiod",false,false)
             poolForm.elements[caller*5+4].selectedIndex = 0
         }
         else {
@@ -444,7 +446,7 @@ function verify() {
     if ($numitems > 0) {
         my $maxnum = $numitems - 1;
         my %lt = &Apache::lonlocal::texthash(
-                                              fnmb => 'File names must be unique',
+                                              fnmb => 'Filenames must be unique',
                                               isum => 'is used more than once',
                                             );
         $$jsref .= qq|
@@ -487,9 +489,9 @@ sub display_zero {
     my ($r,$fn,$page,$webpath) = @_;
     my $go_default = 'NextPage'; 
     if ($fn eq '') {
-        $r->print('<b>'.&mt('Incomplete file upload').'</b> '.&mt('Return to the [_1]construction space menu[_2] to upload a file','<a href="'.$webpath.'">','</a>'));
+        $r->print('<b>'.&mt('Incomplete file upload').'</b> '.&mt('Return to the [_1]Authoring Space menu[_2] to upload a file','<a href="'.$webpath.'">','</a>'));
     }
-    $r->print(&mt('The <b>Testbank Upload</b> utility can be used by LON-CAPA authors to generate LON-CAPA problem files from a testbank file of questions/answers.').'<br />'.
+    $r->print(&mt('The [_1]Testbank Upload[_2] utility can be used by LON-CAPA authors to generate LON-CAPA problem files from a testbank file of questions/answers.','<b>','</b>').'<br />'.
               &mt('The following question types can be converted:').'
               <ul>
                 <li>'.&mt('multiple choice').'</li>
@@ -510,7 +512,7 @@ sub display_zero {
         </ol><form name="info" method="post" action="/adm/testbank">'.
         &Apache::lonhtmlcommon::topic_bar(1,&mt('Optional: create a sub-directory in which the testbank questions will be saved')).
         &mt('By default, LON-CAPA problems generated from the testbank file will be stored in the current directory.').' '.&mt('To store them in a new sub-directory:'). 
-       ' <input type="button" name="createdir" value="'.&mt('Create sub-directory').'" onClick="javascript:createWin()" />'.
+       ' <input type="button" name="createdir" value="'.&mt('Create sub-directory').'" onclick="javascript:createWin()" />'.
        &page_footer($env{'form.newdir'},$fn,$page,$webpath).'
        </form>');
 }
@@ -536,9 +538,9 @@ sub display_one {
               &Apache::lonhtmlcommon::topic_bar(2,$topics{2}).'<p>'.
               &mt('A number in the specified format should appear at the start of each question.').'<br />'.
               &mt('For multiple choice questions, the question number must begin the line that contains the question text; foils (starting (a), (i) etc.) should occur on subsequent lines.').'<br />'."\n".
-              &mt('Correct answers should be numbered in the same way as the questions and should appear after <b>all</b> the questions (including question text and possible foils for all questions).').'<br />'."\n".
+              &mt('Correct answers should be numbered in the same way as the questions and should appear after [_1]all[_2] the questions (including question text and possible foils for all questions).','<b>','</b>').'<br />'."\n".
               &mt('Each numbered question must have a corresponding numbered answer, although the answer itself may be blank for essay questions.').'<br /><br />'."\n".
-              &mt('For example, you would select <b>1.</b> if your testbank file contained the following questions:').'<br /><blockquote>'.
+              &mt('For example, you would select [_1]1.[_2] if your testbank file contained the following questions:','<b>','</b>').'<br /><blockquote>'.
 '<pre>
  1. '.&mt('The capital of the USA is ...').'
  (a) Washington D.C.
@@ -557,7 +559,7 @@ sub display_one {
 </pre>'.
              '</blockquote></p>'.
              &Apache::lonhtmlcommon::topic_bar(3,$topics{3}).'<p>'.
-             &mt('For example, you would enter <b>6</b> if your testbank file contained the following sequence of questions:').'</p><blockquote>'.
+             &mt('For example, you would enter [_1]6[_2] if your testbank file contained the following sequence of questions:','<b>','</b>').'</p><blockquote>'.
              &mt('10 multiple choice questions').'<br />'.
              &mt('5 essay questions').'<br />'.
              &mt('5 fill-in-the-blank questions').'<br />'.
@@ -601,15 +603,15 @@ sub display_two {
     my $steptitle = &mt('Information about question types and formats in each block.');
     $r->print('<h3>'.&mt('Classification of blocks').'</h3>'.
               '<form method="post" name="display" action="/adm/testbank"><p>'.
-              &mt('You indicated that <b>all</b> questions (and the corresponding answer(s) for each question) begin with a number in the following format: [_1].','<b>'.$qnumtypes{$qnumformat}.'</b>').'</p><p>'.
-              &mt('A total of <b>[quant,_1,question]</b> and <b>[quant,_2,answer]</b> were found in the file you uploaded.',$qcount,$qcount).' '.
-              &mt('If this total does not match the number you expect, examine your original testbank file to verify that each question <i>and</i> each answer begins with a number in the specified format.').' '.
+              &mt('You indicated that [_1]all[_2] questions (and the corresponding answer(s) for each question) begin with a number in the following format: [_3].','<b>','</b>','<b>'.$qnumtypes{$qnumformat}.'</b>').'</p><p>'.
+              &mt('A total of [_1][quant,_3,question][_2] and [_1][quant,_4,answer][_2] were found in the file you uploaded.','<b>','</b>',$qcount,$qcount).' '.
+              &mt('If this total does not match the number you expect, examine your original testbank file to verify that each question [_1]and[_2] each answer begins with a number in the specified format.','<i>','</i>').' '.
               &mt('If necessary use an editor to edit your testbank file of questions, and click "Previous Page" on this page and the "Exit Now" on the preceding page, so you can upload your file again.').'</p><p>'.
-              &mt('You also indicated that the <b>[quant,_1,question]</b> can be divided into <b>[quant,_2,block]</b> of questions of a particular question type.',$qcount,$blocks).'</p><p>'.
+              &mt('You also indicated that the [_1][quant,_3,question][_2] can be divided into [_1][quant,_4,block][_2] of questions of a particular question type.','<b>','</b>',$qcount,$blocks).'</p><p>'.
               &mt('Provide additional information below, about the types of questions you have uploaded, and, if applicable, the format of answers and "foils" for specific types of questions.').'</p>'.
               &show_uploaded_data($textref,$header).
               &Apache::lonhtmlcommon::topic_bar(4,$steptitle).'<p>'.
-              &mt('For <i>each</i> of the [_1] question blocks, specify the question numbers of the first and last questions in the block (e.g., 1 and 10), and the question type of the questions in the block.','<b>'.$blocks.'</b>').' '.
+              &mt('For [_1]each[_2] of the [_3] question blocks, specify the question numbers of the first and last questions in the block (e.g., 1 and 10), and the question type of the questions in the block.','<i>','</i>','<b>'.$blocks.'</b>').' '.
               &mt('If required, provide additional information about foil formats and answer formats for the question types you select.').'</p><p>'.
               &Apache::loncommon::start_data_table().
               &Apache::loncommon::start_data_table_header_row().
@@ -627,7 +629,7 @@ sub display_two {
                  '<td valign="top">&nbsp;<input type="text" name="start_'.$i.'" value="'.$bl1st.'" size="5" />&nbsp;</td>'."\n".
                  '<td valign="top">&nbsp;<input type="text" name="end_'.$i.'" value="'.$bl1end.'" size="5" />&nbsp;</td>'."\n".
                  '<td valign="top">
-   <select name="qtype_'.$i.'" onChange="colSet('.$i.')">
+   <select name="qtype_'.$i.'" onchange="colSet('.$i.')">
     <option value="-1" selected="selected">'.&mt('Select').'</option>'."\n");
         foreach my $qtype (@types) {
             $r->print('<option value="'.$qtype.'">'.$typenames{$qtype}.'</option>'."\n");
@@ -647,14 +649,14 @@ sub display_two {
                      &Apache::loncommon::end_data_table_row()); 
     }
     $r->print(&Apache::loncommon::end_data_table().'</p><ul><li>'.
-              &mt('For <i>multiple choice</i>, <i>multiple correct answer</i> and <i>ranking</i> type questions, you must use the <b>Foil format</b> column to choose the format of the identifier used for each of the possible answers (e.g., (a), a, a., i, (i) etc.) provided for a given question stem.').'</li><li>'.
-             &mt('For <i>multiple correct answer</i> and <i>fill-in-the-blank</i> questions with more than one correct answer you must use the <b>Answer format</b> column to choose the separator used between the answers, e.g., if the correct answers for question 28. were listed as:[_1] you would choose "comma", or if they were listed as:[_2] you would choose "new line".','<blockquote><pre>28. (a),(d),(e)</pre></blockquote>','<blockquote><pre>
+              &mt('For [_1]multiple choice[_2], [_1]multiple correct answer[_2] and [_1]ranking[_2] type questions, you must use the [_3]Foil format[_4] column to choose the format of the identifier used for each of the possible answers (e.g., (a), a, a., i, (i) etc.) provided for a given question stem.','<i>','</i>','<b>','</b>').'</li><li>'.
+             &mt('For [_1]multiple correct answer[_2] and [_1]fill-in-the-blank[_2] questions with more than one correct answer you must use the [_3]Answer format[_4] column to choose the separator used between the answers, e.g., if the correct answers for question 28. were listed as:[_5] you would choose "comma", or if they were listed as:[_6] you would choose "new line".','<i>','</i>','<b>','</b>','<blockquote><pre>28. (a),(d),(e)</pre></blockquote>','<blockquote><pre>
 28. (a)
     (d)
     (e)
 </pre></blockquote>').'</li><li>'.
-             &mt('For <i>true/false</i> questions you must use the <b>Answer format</b> column to choose how the correct answer - True or False, is displayed in the text file (e.g., T or F, true or false etc.).').'</li><li>'.
-            &mt('For <i>ranking</i> questions you must use the <b>Answer format</b> column to choose the separator used between the (ranked) answers.').'</li></ul>
+             &mt('For [_1]true/false[_2] questions you must use the [_3]Answer format[_4] column to choose how the correct answer - True or False, is displayed in the text file (e.g., T or F, true or false etc.).','<i>','</i>','<b>','</b>').'</li><li>'.
+            &mt('For [_1]ranking[_2] questions you must use the [_3]Answer format[_4] column to choose the separator used between the (ranked) answers.','<i>','</i>','<b>','</b>').'</li></ul>
 <input type="hidden" name="blocks" value="'.$blocks.'" />
 <input type="hidden" name="qnumformat" value="'.$qnumformat.'" />'.
            &page_footer($env{'form.newdir'},$fn,$page).'
@@ -681,7 +683,7 @@ sub display_three {
     my %lt = &Apache::lonlocal::texthash (
                                           crt  => 'Create?',
                                           typ  => 'Type',
-                                          fnam => 'File Name',
+                                          fnam => 'Filename',
                                           ques => 'Question',
                                           answ => 'Answer',
                                           chka => 'check all',
@@ -774,7 +776,12 @@ sub display_three {
                                           '<td valign="top">'.$showqn.'<br /><br />'."\n");
                             } else {
                                 my $foiltag = '';
-                                if ($foilformats[$i] eq "lcperiod") {
+                                if ($foilformats[$i] eq "lcspace") {
+                                    $foiltag = $alphabet->[$k-1].' ';
+                                } elsif ($foilformats[$i] eq "ucspace") {
+                                    $foiltag = $alphabet->[$k-1].' ';
+                                    $foiltag =~ tr/a-z/A-Z/;
+                                } elsif ($foilformats[$i] eq "lcperiod") {
                                     $foiltag = $alphabet->[$k-1].'.'; 
                                 } elsif ($foilformats[$i] eq "lcparen") {
                                     $foiltag = '('.$alphabet->[$k-1].')';
@@ -924,7 +931,7 @@ sub final_display {
                         $items->[$k] =~ tr/A-Z/a-z/;
                         $items->[$k] =~ s/<\/?[^>]+>//g;
                         $items->[$k] =~ s/\W//g;
-                        if ($foilformats[$i] eq "lcperiod" || $foilformats[$i] eq "lcparen" || $foilformats[$i] eq "lconeparen" || $foilformats[$i] eq "lcdotparen" || $foilformats[$i] eq "ucparen" || $foilformats[$i] eq "ucperiod" || $foilformats[$i] eq "uconeparen" || $foilformats[$i] eq "ucdotparen") {
+                        if ($foilformats[$i] eq "lcspace" || $foilformats[$i] eq "ucspace" || $foilformats[$i] eq "lcperiod" || $foilformats[$i] eq "lcparen" || $foilformats[$i] eq "lconeparen" || $foilformats[$i] eq "lcdotparen" || $foilformats[$i] eq "ucparen" || $foilformats[$i] eq "ucperiod" || $foilformats[$i] eq "uconeparen" || $foilformats[$i] eq "ucdotparen") {
                             for (my $j=0; $j<@{$alphabet}; $j++) {
                                 if ($alphabet->[$j] eq $items->[$k]) {
                                     push @{$answers{$qnum}}, $j;
@@ -957,7 +964,7 @@ sub final_display {
                             } else {
                                 $correct =~s/\W//g;
                             }
-                            if ($foilformats[$i] eq "lcperiod" || $foilformats[$i] eq "lcparen" || $foilformats[$i] eq "ucparen" || $foilformats[$i] eq "ucperiod") {
+                            if ($foilformats[$i] eq "lcspace" || $foilformats[$i] eq "ucspace" || $foilformats[$i] eq "lcperiod" || $foilformats[$i] eq "lcparen" || $foilformats[$i] eq "ucparen" || $foilformats[$i] eq "ucperiod") {
                                 if (($qtype[$i] eq "Ord") && (@tied > 0)) {
                                     my @ties;
                                     foreach my $tie (@tied) {
@@ -1275,7 +1282,11 @@ sub file_split {
         if (${$numsref}[$i] > 0) {
             if ((${$qtyperef}[$i] eq "MC") || (${$qtyperef}[$i] eq "MA") || (${$qtyperef}[$i] eq "Ord")) {
                 my $splitstr = '';
-                if (${$foilsref}[$i] eq "lcperiod") {
+                if (${$foilsref}[$i] eq "lcspace") {
+                    $splitstr = '[a-z]\s';
+                } elsif (${$foilsref}[$i] eq "ucspace") {
+                    $splitstr = '[A-Z]\s';
+                } elsif (${$foilsref}[$i] eq "lcperiod") {
                     $splitstr = '[a-z]\.';
                 } elsif (${$foilsref}[$i] eq "lcparen") {
                     $splitstr = '\([a-z]\)';
@@ -1578,6 +1589,7 @@ sub create_ess {
          if (open(PROB,">$destdir$libfile")) {
              print PROB $output;
              close(PROB);
+             $result = 'ok';
          } else {
              $result = 'failed';
          }
@@ -1775,7 +1787,7 @@ sub print_header {
     my ($uname,$udom,$javascript,$loadentries,$title,$current_page,$pagesref,
         $namesref) = @_;
     my $brcrum = [{'href' => &Apache::loncommon::authorspace("/priv/$udom/$uname/"),
-                   'text' => 'Construction Space'}];
+                   'text' => 'Authoring Space'}];
     if ($env{'form.phase'} eq 'three') {
         if (ref($pagesref) eq 'ARRAY') {
             for (my $i=0; $i<$current_page; $i++) {
@@ -1837,7 +1849,7 @@ sub handler {
     my $page_name = '';
     my $current_page = '';
     my $qcount = '';
-    my $title = 'Upload testbank questions to Construction Space';
+    my $title = 'Upload testbank questions to Authoring Space';
 
 # ----------------------------------------------------------- Start page output
     &Apache::loncommon::content_type($r,'text/html');
@@ -1946,7 +1958,7 @@ sub handler {
                       &page_footer('',$fn).'</form>');
         }
     } else {
-        &Apache::lonupload::phaseone($r,$fn,'testbank');
+        &Apache::lonupload::phaseone($r,$fn,'testbank',$uname,$udom);
     }
     $r->print(&Apache::loncommon::end_page());
     return OK;