--- loncom/xml/lonplot.pm	2012/07/24 11:05:11	1.165
+++ loncom/xml/lonplot.pm	2016/01/22 22:30:07	1.176
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Dynamic plot
 #
-# $Id: lonplot.pm,v 1.165 2012/07/24 11:05:11 foxr Exp $
+# $Id: lonplot.pm,v 1.176 2016/01/22 22:30:07 damieng Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -78,7 +78,7 @@ BEGIN {
 ##  align
 ##
 ##  @labels: $labels[$i] = \%label
-##           %label: text, xpos, ypos, justify
+##           %label: text, xpos, ypos, justify, rotate, zlayer
 ##
 ##  @curves: $curves[$i] = \%curve
 ##           %curve: name, linestyle, ( function | data )
@@ -105,7 +105,7 @@ my %linetypes =			# For png use these li
     );
 my %ps_linetypes = 		# For ps the line types are different!
    (
-    solid          => 0,
+    solid          => 1,
     dashed         => 7
    );
 
@@ -132,7 +132,12 @@ my $real_test      =
     sub {$_[0]=~s/\s+//g;$_[0]=~/^[+-]?\d*\.?\d*([eE][+-]\d+)?$/};
 my $pos_real_test  =
     sub {$_[0]=~s/\s+//g;$_[0]=~/^[+]?\d*\.?\d*([eE][+-]\d+)?$/};
-my $color_test     = sub {$_[0]=~s/\s+//g;$_[0]=~/^x[\da-fA-F]{6}$/};
+my $color_test;
+if ($version < 4.6) {
+    $color_test = sub {$_[0]=~s/\s+//g;$_[0]=~s/^\#/x/;$_[0]=~/^x[\da-fA-F]{6}$/};
+} else {
+    $color_test = sub {$_[0]=~s/\s+//g;$_[0]=~s/^x/#/;$_[0]=~/^\#[\da-fA-F]{6}$/};
+}
 my $onoff_test     = sub {$_[0]=~/^(on|off)$/};
 my $key_pos_test   = sub {$_[0]=~/^(top|bottom|right|left|outside|below| )+$/};
 my $sml_test       = sub {$_[0]=~/^(\d+|small|medium|large)$/};
@@ -253,7 +258,7 @@ my %gnuplot_defaults =
 	 test        => sub {$_[0]=~/^(left|right|middle|center)$/},
 	 description => 'Alignment for image in HTML',
 	 edit_type   => 'choice',
-	 choices     => ['left','right','middle']
+	 choices     => ['left','right','middle','center']
 	 },
      texwidth     => {
          default     => '93',
@@ -416,7 +421,14 @@ my %label_defaults =
          description => 'Rotation of label (degrees)',
          edit_type   => 'entry',
          size        => '10',
-     }
+     },
+     zlayer => {
+         default => '',
+         test => sub {$_[0]=~/^(front|back)$/},
+         description => 'Z position of label',
+         edit_type   => 'choice',
+         choices     => ['front','back'], 
+     },
      );
 
 my @tic_edit_order = ('location','mirror','start','increment','end',
@@ -727,13 +739,19 @@ sub end_gnuplot {
 	$filename = &escape($filename);
 	## return image tag for the plot
 	if ($target eq 'web') {
-	    $result .= <<"ENDIMAGE";
-<img src    = "/cgi-bin/plot.$weboutputformat?file=$filename.data" 
-     width  = "$Apache::lonplot::plot{'width'}"
-     height = "$Apache::lonplot::plot{'height'}"
-     align  = "$Apache::lonplot::plot{'align'}"
-     alt    = "$Apache::lonplot::plot{'alttag'}" />
-ENDIMAGE
+            my $srcatt = "src=\"/cgi-bin/plot.$weboutputformat?file=$filename.data\"";
+            my $widthatt = "width=\"$Apache::lonplot::plot{'width'}\"";
+            my $heightatt = "height=\"$Apache::lonplot::plot{'height'}\"";
+            my $alignatt = "align=\"$Apache::lonplot::plot{'align'}\"";
+            my $altatt = "alt=\"$Apache::lonplot::plot{'alttag'}\"";
+            if ($Apache::lonplot::plot{'align'} eq 'center') {
+                $result .= '<div style="text-align:center">'.
+                    "<img $srcatt $widthatt $heightatt $altatt>".
+                    "</div>\n";
+
+            } else {
+              $result .= "<img $srcatt $widthatt $heightatt $alignatt $altatt>";
+            }
         } elsif ($target eq 'tex') {
 	    &Apache::lonxml::debug(" gnuplot wid = $Apache::lonplot::plot{'width'}");
 	    &Apache::lonxml::debug(" gnuplot ht  = $Apache::lonplot::plot{'height'}");
@@ -741,7 +759,13 @@ ENDIMAGE
 	    &Apache::lonxml::register_ssi("/cgi-bin/plot.gif?file=$filename.data&output=eps");
 	    $result  = "%DYNAMICIMAGE:$Apache::lonplot::plot{'width'}:$Apache::lonplot::plot{'height'}:$Apache::lonplot::plot{'texwidth'}\n";
 	    $result .= '\graphicspath{{'.$tmpdir.'}}'."\n";
+            if ($Apache::lonplot::plot{'align'} eq 'center') {
+                $result .= '\begin{center}';
+            }
 	    $result .= '\includegraphics[width='.$Apache::lonplot::plot{'texwidth'}.' mm]{'.&unescape($filename).'.eps}';
+            if ($Apache::lonplot::plot{'align'} eq 'center') {
+                $result .= '\end{center}';
+            }
 	}
     } elsif ($target eq 'edit') {
 	$result.=&Apache::edit::tag_end($target,$token);
@@ -1709,7 +1733,7 @@ sub generate_tics {
     my $result   = '';
 
 
-    if (defined %$spec) {
+    if ((ref($spec) eq 'HASH') && (keys(%{$spec}) > 0)) {
 
 	
 
@@ -1747,7 +1771,7 @@ sub generate_tics {
 	if ($spec->{'minorfreq'} != 0) {
 	    $result .= "set m$type $spec->{'minorfreq'}\n";
 	}
-    } else {
+    } elsif ($target eq 'tex' ) {
 	$result .= "set $type font " . '"Helvetica,22"' ."\n";
     }
     
@@ -1883,8 +1907,8 @@ sub write_gnuplot_file {
     $gnuplot_input .= "set samples $Apache::lonplot::plot{'samples'}\n";
     # title, xlabel, ylabel
     # titles
-    my $extra_space_x = ($xtics{'location'} eq 'axis') ? ' 0, -0.5 ' : '';
-    my $extra_space_y = ($ytics{'location'} eq 'axis') ? ' -0.5, 0 ' : '';
+    my $extra_space_x = ($xtics{'location'} eq 'axis') ? ' offset 0, -0.5 ' : '';
+    my $extra_space_y = ($ytics{'location'} eq 'axis') ? ' offset -0.5, 0 ' : '';
 
     if ($target eq 'tex') {
 	$gnuplot_input .= "set title  \"$title\"          font \"".$font_properties->{'printname'}.",".$fontsize."pt\"\n" if (defined($title)) ;
@@ -1962,7 +1986,10 @@ sub write_gnuplot_file {
         $gnuplot_input .= ' '.$label->{'justify'};
 
         if ($target eq 'tex') {
-	    $gnuplot_input .=' font "'.$font_properties->{'printname'}.','.$fontsize.'pt"' ;
+	    $gnuplot_input .=' font "'.$font_properties->{'printname'}.','.$fontsize.'pt"';
+        }
+        if (($label->{'zlayer'} eq 'front') || ($label->{'zlayer'} eq 'back')) {
+            $gnuplot_input .= ' '.$label->{'zlayer'};
         }
         $gnuplot_input .= $/;
     }
@@ -1979,24 +2006,26 @@ sub write_gnuplot_file {
     #
     my $linestyle_index = 50;
     my $line_width   = '';
+    my $plots = '';
 
     # If arrows are needed there will be an arrow style for each as well:
     #
 
     my $arrow_style_index = 50;
 
-    my $plot_command;
-    my $plot_type;
-
     for (my $i = 0;$i<=$#curves;$i++) {
 	$curve = $curves[$i];
-	$plot_command.= ', ' if ($i > 0);
+	my $plot_command = '';
+	my $plot_type = '';
+	if ($i > 0) {
+	    $plot_type = ', ';
+	}
 	if ($target eq 'tex') {
 	    $curve->{'linewidth'} *= 2;
 	}
 	$line_width = $curve->{'linewidth'};
 	if (exists($curve->{'function'})) {
-	    $plot_type    = 
+	    $plot_type  .= 
 		$curve->{'function'}.' title "'.
 		$curve->{'name'}.'" with '.
                 $curve->{'linestyle'};
@@ -2020,7 +2049,7 @@ sub write_gnuplot_file {
 	    print $fh $datatext;
 	    close($fh);
 	    #   generate gnuplot text
-	    $plot_type = '"'.$datafilename.'" title "'.
+	    $plot_type .= '"'.$datafilename.'" title "'.
 		$curve->{'name'}.'" with '.
 		$curve->{'linestyle'};
 	}
@@ -2042,10 +2071,6 @@ sub write_gnuplot_file {
 	my $color = $curve->{'color'};
 	$color =~ s/^x/#/;	        # Convert xhex color -> #hex color.   
 
-	my $style_command = "set style line $linestyle_index $pointtype $pointsize linetype $lt linewidth $line_width lc rgb '$color'\n";
-	$gnuplot_input .= $style_command;
-
-
 
 	if (($curve->{'linestyle'} eq 'points')      ||
 	    ($curve->{'linestyle'} eq 'linespoints') ||
@@ -2076,8 +2101,8 @@ sub write_gnuplot_file {
 	    $arrow_style_index++;
 	}
 
-
-
+        my $style_command = "set style line $linestyle_index $pointtype $pointsize linetype $lt linewidth $line_width lc rgb '$color'\n";
+        $gnuplot_input .= $style_command;
 
 	# The condition below is because gnuplot lumps the linestyle in with the 
 	# arrowstyle _sigh_.
@@ -2086,9 +2111,10 @@ sub write_gnuplot_file {
 	    $plot_command.= " ls $linestyle_index";
 	}
 
-	$gnuplot_input .= 'plot ' . $plot_type . ' ' . $plot_command . "\n";
+	$plots .= $plot_type . ' ' . $plot_command;
 	$linestyle_index++;	# Each curve get a unique linestyle.
     }
+    $gnuplot_input .= 'plot '.$plots;
     # Write the output to a file.
 
     # &Apache::lonnet::logthis($gnuplot_input); # uncomment to log the gnuplot input.