--- rat/client/parameter.html	2011/11/21 01:03:09	1.61
+++ rat/client/parameter.html	2016/08/05 17:39:45	1.64.2.3
@@ -5,7 +5,7 @@
 The LearningOnline Network with CAPA
 Parameter Input Window
 //
-// $Id: parameter.html,v 1.61 2011/11/21 01:03:09 raeburn Exp $
+// $Id: parameter.html,v 1.64.2.3 2016/08/05 17:39:45 raeburn Exp $
 //
 // Copyright Michigan State University Board of Trustees
 //
@@ -43,6 +43,7 @@ var preturn='';
 var pcode='';
 var pscat='';
 var pmarker='';
+var pmodal='';
 var pname='';
 
 var defhour=0;
@@ -71,8 +72,11 @@ function selwrite(text) {
 
 function choicestart() {
   this.window.choices.document.open();
-  choicewrite('<html><body>');
+  choicewrite('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">');
+  choicewrite('<html xmlns="http://www.w3.org/1999/xhtml">');
   choicewrite('<head>');
+  choicewrite('<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />');
+  choicewrite('<title>LON-CAPA</title>');
   choicewrite('<style type="text/css">');
   choicewrite('<!--');
   choicewrite('body {');
@@ -86,6 +90,7 @@ function choicestart() {
   choicewrite('-->');
   choicewrite('</style>');
   choicewrite('</head>');
+  choicewrite('<body>');
 }
 
 function choiceend() {
@@ -236,58 +241,66 @@ function month() {
 function intminute() {
    var thisminutes=cmins;
     var i;
-    choicewrite('<select name="minutes" onchange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="minutes" onchange="parent.intcalc();">';
     for (i=0;i<=59;i++) {
-        choicewrite('<option value="'+i+'"');
+        result += '<option value="'+i+'"';
         if (i==thisminutes) {
-            choicewrite(' selected="selected"');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
+    result += '</select>';
+    return result;
 } 
 
 function inthour() {
    var thishours=chours;
     var i;
-    choicewrite('<select name="hours" onchange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="hours" onchange="parent.intcalc();">';
     for (i=0;i<=23;i++) {
-        choicewrite('<option value="'+i+'"');
+        result += '<option value="'+i+'"';
         if (i==thishours) {
-            choicewrite(' selected="selected"');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
-} 
+    result += '</select>';
+    return result;
+}
 
 function intsecond() {
    var thisseconds=csecs;
     var i;
-    choicewrite('<select name="seconds" onchange="parent.intcalc();">');
+    var result = '';
+    result += '<select name="seconds" onchange="parent.intcalc();">';
     for (i=0;i<=59;i++) {
-        choicewrite('<option value="'+i+'"');
+        result += '<option value="'+i+'"';
         if (i==thisseconds) {
-            choicewrite(' selected="selected"');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
-} 
+    result += '</select>';
+    return result;
+}
 
 
 function intday() {
    var thisdate=cdays;
     var i;
-    choicewrite('<select name="date" onchange="parent.intcalc();">');
+    var result ='';
+    result += '<select name="date" onchange="parent.intcalc();">';
     for (i=0;i<=31;i++) {
-        choicewrite('<option value="'+i+'"');
+        result += '<option value="'+i+'"';
         if (i==thisdate) {
-            choicewrite(' selected="selected"');
+            result += ' selected="selected"';
         }
-        choicewrite('>'+i+'</option>');
+        result += '>'+i+'</option>';
     }
-    choicewrite('</select>');
+    result += '</select>';
+    return result;
 }
 
 function intcalc() {
@@ -337,9 +350,7 @@ function radiostringeval(newval) {
 }
 
 function callradiostringeval(newval) {
-   return 'onchange="parent.radiostringeval(\''
-          +newval+'\')" onclick="parent.radiostringeval(\''
-          +newval+'\')"';
+    return 'onclick="parent.radiostringeval(\''+newval+'\')"';
 }
 
 function intervaldis() {
@@ -382,6 +393,9 @@ function draw() {
    if (ptype=='string') {
       choicewrite(' action="javascript:stringeval();"');
    }
+   if (ptype != 'int' && ptype != 'float' && ptype != 'string') {
+       choicewrite(' action=""');
+   }
    choicewrite('>');
    if (ptype=='tolerance') {
 // 0: pscat
@@ -465,14 +479,17 @@ function draw() {
       }
       if (pscat=='interval') {
          tablestart('Time interval');
-         choicewrite('<tr><td colspan="3">');
-         intervaldis();
-         choicewrite('</td></tr><tr><td>Time:'
-         +'</td><td colspan="2">');
-         intday();choicewrite('days ');
-         inthour();choicewrite('hours ');
-         intminute(); choicewrite('mins '); intsecond();
-         choicewrite('secs</td></tr></table>');         
+         choicewrite( [
+            '<tr><td colspan="3">'+intervaldis()+'</td></tr>',
+            '<tr><td>Time:</td><td colspan="2">',
+                '<span style="white-space:nowrap">'+intday()+' days </span>',
+                '<span style="white-space:nowrap">'+inthour()+' hours</span>',
+                '<span style="white-space:nowrap">'+intminute()+' mins</span>',
+                '<span style="white-space:nowrap">'+intsecond()+' secs</span>',
+            '</td></tr>',
+            '</table>',
+            '<br />',
+            ].join("\n"));
       } else { 
          choicewrite('<tr><td colspan="3">'
          +cdate.toString()+
@@ -673,6 +690,22 @@ function draw() {
            if (svalue=='default') { choicewrite(' checked="checked"'); }
            choicewrite(' /> Default (only bubblesheet grading is lenient)</label><br />');
         }
+        if (pscat=='discussvote') {
+           tablestart('Discussion Voting');
+           choicewrite('<tr><td>Value:</td><td colspan="2">');
+           choicewrite('<label><input name="stringval" value="yes"'+
+                  ' type="radio" '+callradiostringeval('yes'));
+           if (svalue=='yes') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes</label><br />');
+           choicewrite('<label><input name="stringval" value="notended"'+
+                  ' type="radio" '+callradiostringeval('notended'));
+           if (svalue=='notended') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> Yes, unless discussion ended</label><br />');
+           choicewrite('<label><input name="stringval" value="no"'+
+                  ' type="radio" '+callradiostringeval('no'));
+           if (svalue=='no') { choicewrite(' checked="checked"'); }
+           choicewrite(' /> No</label><br />');
+        }
         if (pscat=='ip') {
            tablestart('IP Number/Name');
 	   choicewrite('<tr><td>Value:</td><td colspan="2">');
@@ -829,6 +862,7 @@ function init() {
      if (pair[0]=='call') { pcode=pair[1]; }
      if (pair[0]=='marker') { pmarker=pair[1]; }
      if (pair[0]=='name') { pname=pair[1]; }
+     if (pair[0]=='modal') { pmodal=pair[1]; }
      if (pair[0]=='defhour' && pair[1] >= 0 && pair[1] < 24 ) {
          defhour=pair[1];
      }
@@ -857,8 +891,11 @@ function init() {
   }
 
   this.window.selector.document.open();
-  selwrite('<html><body>');
+  selwrite('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">');
+  selwrite('<html xmlns="http://www.w3.org/1999/xhtml">');
   selwrite('<head>');
+  selwrite('<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />');
+  selwrite('<title>LON-CAPA</title>');
   selwrite('<style type="text/css">');
   selwrite('<!--');
   selwrite('body {');
@@ -870,8 +907,9 @@ function init() {
   selwrite('-->');
   selwrite('</style>');
   selwrite('</head>');
-  selwrite('<form name="fsel"><b>'+pname+'</b><br />');
-  selwrite('<select name="fcat" onchange="parent.catchange();">');
+  selwrite('<body>');
+  selwrite('<form name="fsel" action=""><b>'+pname+'</b><br />');
+  selwrite('Format of Value(s): <select name="fcat" onchange="parent.catchange();">');
 
   if (ptype=='tolerance') {
      sopt('default','Default');
@@ -936,6 +974,7 @@ function init() {
      else if (pscat == 'examtype')     { sopt('examtype','Exam Type'); }
      else if (pscat == 'questiontype') { sopt('questiontype','Question Type'); }
      else if (pscat == 'lenient')      { sopt('lenient','Lenient Grading (Partial Credit)'); }
+     else if (pscat == 'discussvote')  { sopt('discussvote','Discussion Voting'); }
      else if (pscat == 'ip')           { sopt('ip','IP Number/Name'); }
      else if (pscat == 'fileext')      { sopt('fileext','File Extension'); }
      else if (pscat == 'useslots')     { sopt('useslots','Slots control access'); }
@@ -949,56 +988,34 @@ function init() {
   }
 
   selwrite('</select></form>');
-
+  var targ='parent.opener';
+  if (pmodal==1) {
+     targ='parent.parent';
+  }  
   selwrite('<a href="javascript:parent.assemble();');
   if (preturn!='') {
-     selwrite(
-      'parent.opener.document.'+preturn+'_value.value=parent.window.svalue;');
-     selwrite(
-      'parent.opener.document.'+preturn+'_type.value=parent.window.stype;');
+     selwrite(targ+'.document.'+preturn+'_value.value=parent.window.svalue;');
+     selwrite(targ+'.document.'+preturn+'_type.value=parent.window.stype;');
   }
   if (pmarker!='') {
-     selwrite(
-     'parent.opener.document.'+preturn+'_marker.value=parent.window.pmarker;');
+     selwrite(targ+'.document.'+preturn+'_marker.value=parent.window.pmarker;');
   }
   if (pcode!='') {
-     selwrite('parent.opener.'+pcode+'();');
+     selwrite(targ+'.'+pcode+'();');
   }
   selwrite('">Save</a>&nbsp;&nbsp;');
 
   selwrite('<a href="javascript:');
-     selwrite(
-      'parent.opener.document.'+preturn+'_value.value='+"'';");
+  selwrite(targ+'.document.'+preturn+'_value.value='+"'';");
   if (pmarker!='') {
      selwrite(
-     'parent.opener.document.'+preturn+'_marker.value=parent.window.pmarker;');
+     targ+'.document.'+preturn+'_marker.value=parent.window.pmarker;');
   }
   if (pcode!='') {
-     selwrite('parent.opener.'+pcode+'();');
+     selwrite(targ+'.'+pcode+'();');
   }
   selwrite('">Delete</a>&nbsp;&nbsp;');
  
-  selwrite('<a href="javascript:');
-// Old code :
-//----------------------------------------------------------------------
-//  if (preturn!='') {
-//     selwrite('parent.opener.document.'+preturn+'_value.value='+"'';");
-//     selwrite('parent.opener.document.'+preturn+'_type.value='+"'';");
-// }
-//  if (pmarker!='') {
-//     selwrite('parent.opener.document.'+preturn+'_marker.value='+"'';");
-//  }
-//  if (pcode!='') {
-//     selwrite('parent.opener.'+pcode+'();');
-//  }
-//----------------------------------------------------------------------
-// Just close the window to 'cancel' the operation.  There are javascript
-// errors in the above commented out code that I have not been able to 
-// track down.  I think they reside in 'parent.opener.'+pcode+'();'
-//
-  selwrite('this.parent.close();');
-  selwrite('">Cancel</a>'); 
- 
   selwrite('</body></html>');
   this.window.selector.document.close();
   draw();
