--- rat/lonratparms.pm	2008/11/20 15:19:05	1.26
+++ rat/lonratparms.pm	2011/12/08 22:11:48	1.29
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Set parameters inside of the RAT
 #
-# $Id: lonratparms.pm,v 1.26 2008/11/20 15:19:05 jms Exp $
+# $Id: lonratparms.pm,v 1.29 2011/12/08 22:11:48 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -80,22 +80,16 @@ sub handler {
     my %lt=&Apache::lonlocal::texthash('pa' => 'Parameter',
 			               'de' => 'Default',
 				       'va' => 'Value',
-				       'se' => 'Set');
+				       'se' => 'Set?');
     my $js = (<<ENDHEADER);
 <script type="text/javascript">
 
-    function pclose() {
-        parmwin=window.open("/adm/rat/empty.html","LONCAPAparms",
-                 "height=350,width=350,scrollbars=no,menubar=no");
-        parmwin.close();
-    }
-
     $pjump_def
 
     function stpr() {
         eval("document.parameters."+document.parameters.pres_marker.value+
             ".value=document.parameters.pres_value.value");
-        pclose();
+        modalWindow.close();
     }
 
 
@@ -120,11 +114,11 @@ ENDHEADER
     $r->print(<<ENDDOCUMENT);
 $start_page
 <form action="javascript:setparms();" method="post" name="parameters">
-<input type="hidden" value='' name="pres_value">
-<input type="hidden" value='' name="pres_type">
-<input type="hidden" value='' name="pres_marker">
-<table border=2>
-<tr><th>$lt{'pa'}</th><th>$lt{'de'}</th><th>$lt{'va'}</th><th>$lt{'se'}?</th></tr>
+<input type="hidden" value="" name="pres_value" />
+<input type="hidden" value="" name="pres_type" />
+<input type="hidden" value="" name="pres_marker" />
+<table border="2">
+<tr><th>$lt{'pa'}</th><th>$lt{'de'}</th><th>$lt{'va'}</th><th>$lt{'se'}</th></tr>
 ENDDOCUMENT
 
 ###    %display=&Apache::lonlocal::texthash(%display);
@@ -134,17 +128,17 @@ ENDDOCUMENT
         # Should if(defined($value{$key})) be if(exists($value{$key})) ?
         if (defined($value{$key})) { $cur=$value{$key}; };
         $r->print(<<"END");
-<tr><td><b>$display{$key}</b><br><tt>$key</tt></td>
+<tr><td><b>$display{$key}</b><br /><tt>$key</tt></td>
 <td>&nbsp;$content{$key}</td>
-<td><input type="text" size="10" name="$key" value="$cur">&nbsp;
+<td><input type="text" size="10" name="$key" value="$cur" />&nbsp;
 <a href='javascript:pjump("$type{$key}","$display{$key}",document.parameters.$key.value,"$key","parameters.pres","stpr");'>$enter</a></td>
 <td><input type="checkbox" name="def_$key" 
 END
-        if ($value{$key}) { $r->print(' checked'); }
-        $r->print('></td></tr>');
+        if ($value{$key}) { $r->print(' checked="checked"'); }
+        $r->print(' /></td></tr>');
     }
     $r->print('</table><br />
-               <input type="submit" value="'.&mt('Set').'"></form>'.
+               <input type="submit" value="'.&mt('Set').'" /></form>'.
 	      &Apache::loncommon::end_page());
     return OK;
 }