--- rat/lonratparms.pm	2001/07/01 02:21:18	1.4
+++ rat/lonratparms.pm	2001/07/03 22:37:37	1.6
@@ -13,7 +13,7 @@
 #
 # 3/1 Gerd Kortemeyer)
 #
-# 03/03/01,06/15,06/25,06/26,06/30 Gerd Kortemeyer
+# 03/03/01,06/15,06/25,06/26,06/30,07/02,07/03 Gerd Kortemeyer
 #
 package Apache::lonratparms;
 
@@ -47,11 +47,14 @@ sub handler {
   
   my %content;
   my %type;
+  my %display;
   my %value;
   
   map {
       if ($_=~/^parameter\_/) {
          $content{$_}=&Apache::lonnet::metadata($uri,$_);
+         $type{$_}=&Apache::lonnet::metadata($uri,$_.'.type');
+         $display{$_}=&Apache::lonnet::metadata($uri,$_.'.display');
       }
   } split(/\,/,&Apache::lonnet::metadata($uri,'keys'));
 
@@ -59,9 +62,9 @@ sub handler {
 
   map {
       my ($ptype,$pname,$pvalue)=split(/\_\_\_/,$_);
-      $type{$pname}=$ptype;
+      unless ($type{$pname}) { $type{$pname}=$ptype; }
       $value{$pname}=$pvalue;
-  } split(/\:/,$ENV{'form.params'});
+  } split(/\:/,$ENV{'form.parms'});
   
 # --------------------------------------------------- Print input screen header
     $r->print(<<ENDHEADER);
@@ -71,13 +74,15 @@ sub handler {
 <script language="JavaScript">
 function setparms() {
 ENDHEADER
-    $r->print('opener.objparms['.$ENV{'form.resid'}.']="";');
+    $r->print('var colon=""; opener.objparms['.$ENV{'form.resid'}.']="";');
     map {
        $r->print("\nif (document.parameters.def_".$_.
-       '.value=="on") { opener.objparms['.$ENV{'form.resid'}.
-       ']+="'.$type{$_}.'___'.$_.'___"+document.parameters.'.$_.'.value; }');       
+       '.checked) { opener.objparms['.$ENV{'form.resid'}.
+       ']+=colon+"'.$type{$_}.
+       '___'.$_.'___"+document.parameters.'.$_.'.value; colon=":"; }'); 
     } keys %content;
     $r->print(<<ENDDOCUMENT);
+    opener.save();
     window.close();
 }
 </script>
@@ -88,13 +93,16 @@ ENDHEADER
 <table border=2>
 <tr><th>Parameter</th><th>Default</th><th>Value</th><th>Set?</th></tr>
 ENDDOCUMENT
-    my $cur=$content{$_};
-    if (defined($value{$_})) { $cur=$value{$_}; }
     map {
-        $r->print('<tr><td>'.$_.'</td><td>&nbsp;'.$content{$_}.
+        my $cur=$content{$_};
+        if (defined($value{$_})) { $cur=$value{$_}; };
+        $r->print('<tr><td><b>'.$display{$_}.'</b><br><tt>'.$_.
+        '</tt></td><td>&nbsp;'.$content{$_}.
         '</td><td><input type="text" name="'.$_.'" value="'.$cur.
         '"></td><td><input type="checkbox" name="def_'.$_.
-        '" value="off"></td></tr>');
+        '""');
+        if ($value{$_}) { $r->print(' checked'); }
+        $r->print('></td></tr>');
     } keys %content;
     $r->print(
         '</table><br><input type="submit" value="Set"></form></body></html>');